From patchwork Fri Jan 24 09:30:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 232946 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA01CC35242 for ; Fri, 24 Jan 2020 11:24:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B0F1A22527 for ; Fri, 24 Jan 2020 11:24:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579865056; bh=pVYcKDklVNe3eP66ozhKfPS28/oI1pn2K1p+tP0NuVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=tdDaBa7FMXJWhaSq/nVXTlpOLl7QFLe2rrHSVBb1UUbL7hpfWHxpCI6mKLjFrbBge zKu93e/pWEe+d5OIcPVgcvED2/Dv75U6Ulv7o3sSrs/whD4b4Pm51W2mkwheKbNdj8 DAg3n/KaBqbZx/sYygwwLee1nnpB6WKxMsr+nSpI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403755AbgAXLYP (ORCPT ); Fri, 24 Jan 2020 06:24:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:37496 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403769AbgAXLYP (ORCPT ); Fri, 24 Jan 2020 06:24:15 -0500 Received: from localhost (ip-213-127-102-57.ip.prioritytelecom.net [213.127.102.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 542C92077C; Fri, 24 Jan 2020 11:24:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579865054; bh=pVYcKDklVNe3eP66ozhKfPS28/oI1pn2K1p+tP0NuVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YQipTolbRalAZFgIVTNmmqvRjL/oSDel9o0tUIvm0y8ZVDFtVrptZHaLlPYl/bLqH /4Cc+Ta7/ZPJcfAeU803+ZuRErEgfAh0qSgLEw3dXuMKqTs+idc7iW64g2jXZHKfT5 umLsGqN02SHZZ6Y7O3yN6qzDj7m5IX8vvkp7dbE4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chen-Yu Tsai , Alexandre Belloni , Sasha Levin Subject: [PATCH 4.19 440/639] rtc: pcf8563: Fix interrupt trigger method Date: Fri, 24 Jan 2020 10:30:10 +0100 Message-Id: <20200124093142.195904861@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Chen-Yu Tsai [ Upstream commit 65f662cbf829834fa4d94190eb7691e5a9cb92d8 ] The PCF8563 datasheet says the interrupt line is active low and stays active until the events are cleared, i.e. a level trigger interrupt. Fix the flags used to request the interrupt. Fixes: ede3e9d47cca ("drivers/rtc/rtc-pcf8563.c: add alarm support") Signed-off-by: Chen-Yu Tsai Signed-off-by: Alexandre Belloni Signed-off-by: Sasha Levin --- drivers/rtc/rtc-pcf8563.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c index 3efc86c25d27a..e358313466f19 100644 --- a/drivers/rtc/rtc-pcf8563.c +++ b/drivers/rtc/rtc-pcf8563.c @@ -605,7 +605,7 @@ static int pcf8563_probe(struct i2c_client *client, if (client->irq > 0) { err = devm_request_threaded_irq(&client->dev, client->irq, NULL, pcf8563_irq, - IRQF_SHARED|IRQF_ONESHOT|IRQF_TRIGGER_FALLING, + IRQF_SHARED | IRQF_ONESHOT | IRQF_TRIGGER_LOW, pcf8563_driver.driver.name, client); if (err) { dev_err(&client->dev, "unable to request IRQ %d\n",