From patchwork Fri Jan 24 09:24:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 233055 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAD21C35244 for ; Fri, 24 Jan 2020 11:05:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77BB620663 for ; Fri, 24 Jan 2020 11:05:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579863954; bh=9kGmsPvxyK6zjwEok+yfdcPPcLazU72h6rWtyF4TURw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=H2PtlT/TnQxtPM7htnBXcUx5EnXvUtKlIYdHGK0ZF2cgWe9s93KpRix2IHNTYE24v 3Aajfw0QTRrkhjmMcjdm683nsHqmX/M1tDkgWw8RBqAGktFvHK26nrr7RCMzwwX9cX FI5f2obO6BcV55m1bgamSMjSGCvoRb6Gpq677NVY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387690AbgAXLES (ORCPT ); Fri, 24 Jan 2020 06:04:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:38324 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388458AbgAXLEQ (ORCPT ); Fri, 24 Jan 2020 06:04:16 -0500 Received: from localhost (ip-213-127-102-57.ip.prioritytelecom.net [213.127.102.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 857902075D; Fri, 24 Jan 2020 11:04:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579863856; bh=9kGmsPvxyK6zjwEok+yfdcPPcLazU72h6rWtyF4TURw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2mmuYU6ST7+utOCWHVq+SplFAsoNwdsExmSu+h0TJWQqLClrX9AF8pmVkg2CnBcTX EhArWCYBl5SgwfxWVQV9Eg/SOBMu4ZT73dxn5MMuZTxKTrTw0Gf+NF8W1a9BvzVszC WOm554axvUDDrdnDBfx9czE9uhmws1gsIhs96ScI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yangtao Li , Stephen Boyd , Sasha Levin Subject: [PATCH 4.19 106/639] clk: imx6q: fix refcount leak in imx6q_clocks_init() Date: Fri, 24 Jan 2020 10:24:36 +0100 Message-Id: <20200124093100.633236098@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Yangtao Li [ Upstream commit c9ec1d8fef31b5fc9e90e99f9bd685db5caa7c5e ] The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount. Signed-off-by: Yangtao Li Fixes: 2acd1b6f889c ("ARM: i.MX6: implement clocks using common clock framework") Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/imx/clk-imx6q.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c index c509324f63385..8ddf9b1f1677c 100644 --- a/drivers/clk/imx/clk-imx6q.c +++ b/drivers/clk/imx/clk-imx6q.c @@ -424,6 +424,7 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node) np = of_find_compatible_node(NULL, NULL, "fsl,imx6q-anatop"); anatop_base = base = of_iomap(np, 0); WARN_ON(!base); + of_node_put(np); /* Audio/video PLL post dividers do not work on i.MX6q revision 1.0 */ if (clk_on_imx6q() && imx_get_soc_revision() == IMX_CHIP_REVISION_1_0) {