From patchwork Fri Jan 24 09:29:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 233200 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9752C32771 for ; Fri, 24 Jan 2020 09:54:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85547214AF for ; Fri, 24 Jan 2020 09:54:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859642; bh=kKrsRJvjV2pYirmKjjV3sByo0K9LXiyXcWpNm3rB+pE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=e63zTqorHHl4VeJyV6RYluFz4vl3hYGw8erAkRlCq5cfi2We/Wu9asjdjYMwiauEG 7dr5cKrnemtk0kelOPBRc3fMsJwp5ia5MQ647wDNsFva+xw8Xu+iF+FN+IhPdAURDs q0pyIoWpsaVizP8c/uaVYFLd2zzIw/SN3b+5VPD8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387561AbgAXJyC (ORCPT ); Fri, 24 Jan 2020 04:54:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:56920 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730133AbgAXJyA (ORCPT ); Fri, 24 Jan 2020 04:54:00 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B87820718; Fri, 24 Jan 2020 09:53:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859639; bh=kKrsRJvjV2pYirmKjjV3sByo0K9LXiyXcWpNm3rB+pE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h+PyHj5GmRvJl7MnGROBMjXW/UrZYCn+nP6Z26pzZDgKJ06oRvf3z0x3REqoXVp1q Dgxz/iY6m2JiMP3UDjNaJGsLKDi7+sut5mdjKyR3Tp1x/pdLomUiqUavYql2/fQ8qA 2y+Din84QsYZWqidTM+S4RTs6jBxc2KAGBdXI8Lc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sowjanya Komatineni , Mark Brown , Sasha Levin Subject: [PATCH 4.14 156/343] spi: tegra114: clear packed bit for unpacked mode Date: Fri, 24 Jan 2020 10:29:34 +0100 Message-Id: <20200124092940.493754980@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092919.490687572@linuxfoundation.org> References: <20200124092919.490687572@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Sowjanya Komatineni [ Upstream commit 7b3d10cdf54b8bc1dc0da21faed9789ac4da3684 ] Fixes: Clear packed bit when not using packed mode. Packed bit is not cleared when not using packed mode. This results in transfer timeouts for the unpacked mode transfers followed by the packed mode transfers. Signed-off-by: Sowjanya Komatineni Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-tegra114.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c index 2ad04796ef298..3a6b202dfffe0 100644 --- a/drivers/spi/spi-tegra114.c +++ b/drivers/spi/spi-tegra114.c @@ -730,6 +730,8 @@ static int tegra_spi_start_transfer_one(struct spi_device *spi, if (tspi->is_packed) command1 |= SPI_PACKED; + else + command1 &= ~SPI_PACKED; command1 &= ~(SPI_CS_SEL_MASK | SPI_TX_EN | SPI_RX_EN); tspi->cur_direction = 0;