From patchwork Thu Jan 16 23:18:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 233799 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28543C33CAF for ; Thu, 16 Jan 2020 23:30:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6FF22082F for ; Thu, 16 Jan 2020 23:30:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579217415; bh=g6zQrEQnchlPBkNT7HLvg3TWp3rkuyvuXY9e8M2F708=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Gmk7pQJSOFGAg02h9dbtIezSDaCBDBv04naYmsPs9J8VibuYLVfAdOokp6rBBOUh0 a3Z0xUwbuYXLASX8Qcd1XWEYJOwQxKT9vzoV4dBWsvnrlcwC4i/ZSeW0NGp7/UqZE2 OO/3WGWHvlW7K+b+s9/298KjhXrBJrX6wQDGhbMU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403795AbgAPXaM (ORCPT ); Thu, 16 Jan 2020 18:30:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:36726 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403789AbgAPXaK (ORCPT ); Thu, 16 Jan 2020 18:30:10 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DD9A7214AF; Thu, 16 Jan 2020 23:30:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579217410; bh=g6zQrEQnchlPBkNT7HLvg3TWp3rkuyvuXY9e8M2F708=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p9jQ5jgWPdVkgcW4nXHAI8u1xet+lrkwoCKrXsYnLYUTkhG1Q3iiK9WaNaH/Por9I nIaP30xFiSMIofe21x+ofziLPNBAYoQcB6uv1JHNIDpXMbPQ2/65cwQIDgg+clhIsf IIOUideKrjQVeUXp3bsLCQ5U/fuFKdjo+FZYc4KM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chuhong Yuan , Florian Fainelli , Alexandre Belloni Subject: [PATCH 4.19 72/84] rtc: brcmstb-waketimer: add missed clk_disable_unprepare Date: Fri, 17 Jan 2020 00:18:46 +0100 Message-Id: <20200116231722.032232143@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200116231713.087649517@linuxfoundation.org> References: <20200116231713.087649517@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Chuhong Yuan commit 94303f8930ed78aea0f189b703c9d79fff9555d7 upstream. This driver forgets to disable and unprepare clock when remove. Add a call to clk_disable_unprepare to fix it. Fixes: c4f07ecee22e ("rtc: brcmstb-waketimer: Add Broadcom STB wake-timer") Signed-off-by: Chuhong Yuan Acked-by: Florian Fainelli Link: https://lore.kernel.org/r/20191105160043.20018-1-hslester96@gmail.com Signed-off-by: Alexandre Belloni Signed-off-by: Greg Kroah-Hartman --- drivers/rtc/rtc-brcmstb-waketimer.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/rtc/rtc-brcmstb-waketimer.c +++ b/drivers/rtc/rtc-brcmstb-waketimer.c @@ -287,6 +287,7 @@ static int brcmstb_waketmr_remove(struct struct brcmstb_waketmr *timer = dev_get_drvdata(&pdev->dev); unregister_reboot_notifier(&timer->reboot_notifier); + clk_disable_unprepare(timer->clk); return 0; }