From patchwork Tue Jan 14 10:02:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 233951 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B813EC33CB1 for ; Tue, 14 Jan 2020 10:10:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8ED3E24677 for ; Tue, 14 Jan 2020 10:10:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578996636; bh=waBl7ROoFPsc/9UWf46eDsE3TrDdXns07b8qxe6XbEc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=BGHrNzS7nL+bu88tHghYg2ug8ddFsm1uJl1DjNluClWaF99f6nDeE2sUxYm88zcF6 mIeHYuTGKQxiy9xyzvkZkdR5eWtvK2HSSrkd3p3YTWTBznXamfhhhf2nG6gXFb/tsB 4cANzPeSgueNIPvErALnyr+VpCdE8cPyU4OhRCSU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731712AbgANKKd (ORCPT ); Tue, 14 Jan 2020 05:10:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:44580 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731272AbgANKKc (ORCPT ); Tue, 14 Jan 2020 05:10:32 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 09F4E20678; Tue, 14 Jan 2020 10:10:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578996632; bh=waBl7ROoFPsc/9UWf46eDsE3TrDdXns07b8qxe6XbEc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hNgu3hJXVlNfs4TXm05yEmAX4quPkUIOdm501w6HVbfbsHjSAYxAafY9COoI8Zt6h RMSlG6zJLJI4gofnhwtEGQ80p3Z8FAJ1Ic1CxEYUTDc8S/zzIWLE9lRzjQS+QzkrTZ oOFzmJfSBUCnfd3fQlU7DXo4xHI+QIoLn6CjTSx8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Kenneth R. Crudup" , Sudip Mukherjee Subject: [PATCH 4.14 27/39] tty: always relink the port Date: Tue, 14 Jan 2020 11:02:01 +0100 Message-Id: <20200114094344.924166131@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200114094336.210038037@linuxfoundation.org> References: <20200114094336.210038037@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Sudip Mukherjee commit 273f632912f1b24b642ba5b7eb5022e43a72f3b5 upstream. If the serial device is disconnected and reconnected, it re-enumerates properly but does not link it. fwiw, linking means just saving the port index, so allow it always as there is no harm in saving the same value again even if it tries to relink with the same port. Fixes: fb2b90014d78 ("tty: link tty and port before configuring it as console") Reported-by: Kenneth R. Crudup Signed-off-by: Sudip Mukherjee Cc: stable Link: https://lore.kernel.org/r/20191227174434.12057-1-sudipm.mukherjee@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/tty_port.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/tty/tty_port.c +++ b/drivers/tty/tty_port.c @@ -88,8 +88,7 @@ void tty_port_link_device(struct tty_por { if (WARN_ON(index >= driver->num)) return; - if (!driver->ports[index]) - driver->ports[index] = port; + driver->ports[index] = port; } EXPORT_SYMBOL_GPL(tty_port_link_device);