From patchwork Sat Jan 11 09:49:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 234223 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53566C33CA3 for ; Sat, 11 Jan 2020 09:51:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 216892077C for ; Sat, 11 Jan 2020 09:51:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578736288; bh=IUY4U44esFWbfleDsjrVa7BP0ZvlKMaCIMck05qsgsw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1xBNBFQvxxyu5qt8VAjM6+4kRLhTtEBMg+hKpUoyfC8d1Yq4jawASXSGZct3JSFg8 9iAe0Ry2W3Xky7ppw+ZvFi0zXJTnvZBYo8sVslKCEiHdZKWbSKm80OA5LQUcKDCr3Q zqhJ7LdxIuRd/he4OQZn6vPW+loTW0Ol4KnJCKDc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728923AbgAKJv1 (ORCPT ); Sat, 11 Jan 2020 04:51:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:34928 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728818AbgAKJv0 (ORCPT ); Sat, 11 Jan 2020 04:51:26 -0500 Received: from localhost (unknown [62.119.166.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 339092082E; Sat, 11 Jan 2020 09:51:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578736286; bh=IUY4U44esFWbfleDsjrVa7BP0ZvlKMaCIMck05qsgsw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JyTMZnF5otCDhMUA+KG0+IUABGabiPzQ4KiCWw1DFZRuHSqDmKAncDccH2szodJmR er9w03zFpMpZOvYu+iKZIJFAp3gtZGyLyfhAbzRv2v1VRwx3kZlVYEKhGukUSVEyoD 8ZzxRtemCY+NNcRPBLucHdZGsoGzWEKDiABK9CM4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.4 05/59] scsi: iscsi: qla4xxx: fix double free in probe Date: Sat, 11 Jan 2020 10:49:14 +0100 Message-Id: <20200111094837.616117360@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200111094835.417654274@linuxfoundation.org> References: <20200111094835.417654274@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter [ Upstream commit fee92f25777789d73e1936b91472e9c4644457c8 ] On this error path we call qla4xxx_mem_free() and then the caller also calls qla4xxx_free_adapter() which calls qla4xxx_mem_free(). It leads to a couple double frees: drivers/scsi/qla4xxx/ql4_os.c:8856 qla4xxx_probe_adapter() warn: 'ha->chap_dma_pool' double freed drivers/scsi/qla4xxx/ql4_os.c:8856 qla4xxx_probe_adapter() warn: 'ha->fw_ddb_dma_pool' double freed Fixes: afaf5a2d341d ("[SCSI] Initial Commit of qla4xxx") Link: https://lore.kernel.org/r/20191203094421.hw7ex7qr3j2rbsmx@kili.mountain Signed-off-by: Dan Carpenter Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla4xxx/ql4_os.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index d220b4f691c7..f714d5f917d1 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -4285,7 +4285,6 @@ static int qla4xxx_mem_alloc(struct scsi_qla_host *ha) return QLA_SUCCESS; mem_alloc_error_exit: - qla4xxx_mem_free(ha); return QLA_ERROR; }