From patchwork Tue Jan 7 20:53:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 234296 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD45CC33C9B for ; Tue, 7 Jan 2020 21:20:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7AB752072A for ; Tue, 7 Jan 2020 21:20:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578432038; bh=4tMV4Id3RxV0FDgukzjlM9Vz9xgkrFl0MLncXahA350=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=AI2tenT76AFxgnRq0GNZ78M/JPPcEff4/vAVu/b3OX78uvR+cMV8NwIxPhaL3hZuw BGvaptkh6DOY+O2prkZ79cENOIaSkcMv0Fx3fGiY3Oob23iE7ECzc/r6s8lfpRf7K5 4DpfAvodwC7bPTHKTuf8bNLeyS93LsY+Sa8kfwsw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727709AbgAGVUd (ORCPT ); Tue, 7 Jan 2020 16:20:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:48044 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729030AbgAGVEO (ORCPT ); Tue, 7 Jan 2020 16:04:14 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 613F92187F; Tue, 7 Jan 2020 21:04:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578431053; bh=4tMV4Id3RxV0FDgukzjlM9Vz9xgkrFl0MLncXahA350=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FZE5H35nV8ViYXQ62pJN6OKYcu6NlYwnhlQ2IlMVhjaEloG3qSyUAm9Tnac9uKeB5 9ouCT3meiG3QHzFXimwJCf/KHx8KTAKdv/dy/jqoYJplZ0D8/hs0WUVhMfP2n2lJhy pLrpYESN/nl5JRWwpzKACXdI2+G9dnmLTMCYleFw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Quinn Tran , Himanshu Madhani , Hannes Reinecke , Bart Van Assche , Roman Bolshakov , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.19 015/115] scsi: qla2xxx: Drop superfluous INIT_WORK of del_work Date: Tue, 7 Jan 2020 21:53:45 +0100 Message-Id: <20200107205249.773080125@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200107205240.283674026@linuxfoundation.org> References: <20200107205240.283674026@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Roman Bolshakov [ Upstream commit 600954e6f2df695434887dfc6a99a098859990cf ] del_work is already initialized inside qla2x00_alloc_fcport, there's no need to overwrite it. Indeed, it might prevent complete traversal of workqueue list. Fixes: a01c77d2cbc45 ("scsi: qla2xxx: Move session delete to driver work queue") Cc: Quinn Tran Link: https://lore.kernel.org/r/20191125165702.1013-5-r.bolshakov@yadro.com Acked-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Tested-by: Hannes Reinecke Reviewed-by: Bart Van Assche Signed-off-by: Roman Bolshakov Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_target.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 210ce294038d..8eda55e917e0 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -1261,7 +1261,6 @@ void qlt_schedule_sess_for_deletion(struct fc_port *sess) "Scheduling sess %p for deletion %8phC\n", sess, sess->port_name); - INIT_WORK(&sess->del_work, qla24xx_delete_sess_fn); WARN_ON(!queue_work(sess->vha->hw->wq, &sess->del_work)); }