From patchwork Tue Jan 7 20:55:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 234361 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20DBDC282DD for ; Tue, 7 Jan 2020 21:10:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E3AFC208C4 for ; Tue, 7 Jan 2020 21:10:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578431420; bh=J2LAd74nz1EcG7XUaiods4G6rL7IaKdXblBVr60qVLg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=lYG4zvq8SbzqckelzMRaJZ2nXH92a/QDG7HcWaZsFJ2lovc8z59mm6FgbtL8FQG8E Kidu+NOZI7qliP1Db4KLnaRVBSKboLmUfIxsl9Mfz2gTZ7BX8bCseyQDXe5W4pqi6d qAHxkGY8uxj2Yl6zFA18o04pvlnLaFnXk5csPgvY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729117AbgAGVKR (ORCPT ); Tue, 7 Jan 2020 16:10:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:36642 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729937AbgAGVKP (ORCPT ); Tue, 7 Jan 2020 16:10:15 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CD58D2080A; Tue, 7 Jan 2020 21:10:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578431415; bh=J2LAd74nz1EcG7XUaiods4G6rL7IaKdXblBVr60qVLg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NAbYVz93ZVlBGD5nz1E3hENte/6ZkP7GNhfinMU0KAU3U6o0hNkvjcg6+x9ejhbna t9dpdP/AllRjC8Wly06nLUUyafc+BBFR/zfRql7/2bQHq1yx129DptvWu6H3NKfDXQ D5Oh0FJgKr0QI88ySeNCdq3UWaorsChgq6hQJiuA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Leonard Crestez , Matthias Kaehlcke , Chanwoo Choi Subject: [PATCH 4.14 47/74] PM / devfreq: Check NULL governor in available_governors_show Date: Tue, 7 Jan 2020 21:55:12 +0100 Message-Id: <20200107205214.385436100@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200107205135.369001641@linuxfoundation.org> References: <20200107205135.369001641@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Leonard Crestez commit d68adc8f85cd757bd33c8d7b2660ad6f16f7f3dc upstream. The governor is initialized after sysfs attributes become visible so in theory the governor field can be NULL here. Fixes: bcf23c79c4e46 ("PM / devfreq: Fix available_governor sysfs") Signed-off-by: Leonard Crestez Reviewed-by: Matthias Kaehlcke Reviewed-by: Chanwoo Choi Signed-off-by: Chanwoo Choi Signed-off-by: Greg Kroah-Hartman --- drivers/devfreq/devfreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -974,7 +974,7 @@ static ssize_t available_governors_show( * The devfreq with immutable governor (e.g., passive) shows * only own governor. */ - if (df->governor->immutable) { + if (df->governor && df->governor->immutable) { count = scnprintf(&buf[count], DEVFREQ_NAME_LEN, "%s ", df->governor_name); /*