From patchwork Wed Dec 11 15:06:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "gregkh@linuxfoundation.org" X-Patchwork-Id: 181284 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp716547ile; Wed, 11 Dec 2019 07:57:05 -0800 (PST) X-Google-Smtp-Source: APXvYqyqhYe1u0bugUnDkAPA4QvPeX+QYVZ30NfdqiN6uh/kL3wrn9oWdsF9SxNp91gsuJiZks3u X-Received: by 2002:a05:6830:145:: with SMTP id j5mr2666308otp.242.1576079825610; Wed, 11 Dec 2019 07:57:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576079825; cv=none; d=google.com; s=arc-20160816; b=OW4Ui98GYe3/rTyqoveXw4Q9RxI6ckh7qwynQPtCbyEPWKi/Jmi4wSpxsKViJ3qMfl ki5EiAElnxOTUYgEQwMNariPJuHug7YDbelBQXBwSGHjQDsju+Ft+04jV3FN4j1S2tUO t+8Idn0v+A0ORONlGNjz8RNNOay//yseaI6nws9XKMfFfcdi39Zw3Cv5Kw5aTbOHvBmn kQICPEJpwLYxz6G7ETzV3drdMvJkpaHc3yg/L95Mqbjqa6OIOcKtlB6q/IIWNZH6Yti7 xF9lyYD7vc/UpfGxlPbpmJTxpoVsGwQD4gzd7X+NOCn3PBSARdWU12cYjAW54lYPDNMe 83tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=UhOp/l3ujFqz6RAm/8VTdFIsvCu9tVGgETC5hzpHcUo=; b=UAl7HVD+Vl+04QZBzX6UeGNtDYiFS36eRl7w0KLEacnPzQdfiDPWVnnoaAGblT804N O18dlyjuFUeNV/HdJgRanVFo8PHMcSo2PI1kbwdH8H23WBD+L82Y1q7vGcEYTCntNFXL bRhoDsJ4BEwvzqByiM6uHfv15kRFF1Tu/Ql1RXi1lBVZeePVi2xVTDhDPbAkBPrq8Cec 3PlgG9fwqLdFFtfnQDOlXuDCtYI65ASV5N53qORjcHmDUSbGdg1eArVgbLD0yZH8rVlW 0za1gLdFAHqIHYJXpQnQj0c3x3ehUnYtvR8nvAb5gp03oX2EGh60b0fWk1KmmAqCeYA7 cvcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fVzuyl3Q; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u20si1586844otg.193.2019.12.11.07.57.05; Wed, 11 Dec 2019 07:57:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fVzuyl3Q; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730284AbfLKP5E (ORCPT + 14 others); Wed, 11 Dec 2019 10:57:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:41284 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730821AbfLKPPR (ORCPT ); Wed, 11 Dec 2019 10:15:17 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E0E4424654; Wed, 11 Dec 2019 15:15:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576077316; bh=bMEM8CgX/6uIErmN9B5ttGlNi4wBwVVcAmuXfFf4Z8U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fVzuyl3QbVp58nLw8ZDixxTGDWA0rigQ6sGrlPXl6MVMhpQn5FcW1V3rrDCPUsnyk k71hVPWyYOfdU8rdACZp0dAeDhjMN2QqiG/6/sMcm9jTDqfPlqcaE3GC4H8wNdUVPt Ask8T1Vrk/8nW3pNt/MCnNqHuIhStHdzo04xVQEQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Viresh Kumar , Jason Gunthorpe , Sasha Levin Subject: [PATCH 5.3 099/105] RDMA/qib: Validate ->show()/store() callbacks before calling them Date: Wed, 11 Dec 2019 16:06:28 +0100 Message-Id: <20191211150303.441176134@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191211150221.153659747@linuxfoundation.org> References: <20191211150221.153659747@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Viresh Kumar commit 7ee23491b39259ae83899dd93b2a29ef0f22f0a7 upstream. The permissions of the read-only or write-only sysfs files can be changed (as root) and the user can then try to read a write-only file or write to a read-only file which will lead to kernel crash here. Protect against that by always validating the show/store callbacks. Link: https://lore.kernel.org/r/d45cc26361a174ae12dbb86c994ef334d257924b.1573096807.git.viresh.kumar@linaro.org Signed-off-by: Viresh Kumar Reviewed-by: Greg Kroah-Hartman Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/hw/qib/qib_sysfs.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/drivers/infiniband/hw/qib/qib_sysfs.c +++ b/drivers/infiniband/hw/qib/qib_sysfs.c @@ -301,6 +301,9 @@ static ssize_t qib_portattr_show(struct struct qib_pportdata *ppd = container_of(kobj, struct qib_pportdata, pport_kobj); + if (!pattr->show) + return -EIO; + return pattr->show(ppd, buf); } @@ -312,6 +315,9 @@ static ssize_t qib_portattr_store(struct struct qib_pportdata *ppd = container_of(kobj, struct qib_pportdata, pport_kobj); + if (!pattr->store) + return -EIO; + return pattr->store(ppd, buf, len); }