From patchwork Tue Dec 3 22:33:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 180756 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp2157583ile; Tue, 3 Dec 2019 14:52:24 -0800 (PST) X-Google-Smtp-Source: APXvYqyLlu+ipcWGQlgn5/WnUoBX0F5SVXSfyCosZru97ekpZ4FKncQJ80Tj7ZiMBQtK4QJlgMFO X-Received: by 2002:a9d:7a88:: with SMTP id l8mr214679otn.187.1575413543528; Tue, 03 Dec 2019 14:52:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575413543; cv=none; d=google.com; s=arc-20160816; b=fn+Yli+Q32jH+cjTqbuzou0+FcOMZJ1oAC6xGBscfMnVY5jJFd9HXdIfO3IiP6zGfj PmJkCUOnByBb2N1lMO1eAXSx50HBwpbZ6Gi4P8GfYqgLcAstSm0n7xlCwQ0jgFy1mN7+ x8PLcQDOan8rHJtuPtDyhtjwKD13rsBVUO1DTQcH4s3xkiyYv3yuTGqTYs0pN0HiN0Ou UEn/nsz64wpc2tsgAnPpdoxQOlek3lrj3Lt3LzPKACRoB3bc8TsY1DC+L6Ufw97YmadH pUc4Kt3o12rxpZxjT0PGETT4zOAefuAFmsbkNJMLO0r79e9FiWr5Z4O+0eMHr/vqmfkz vwVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hv99ZPkbPHYXDMKF1iJv2I4lWRpnTTyd+Ih/liTrp4E=; b=bk3QT0JZpgMgN6FiMmMieJqYTWMsBuf+lqjUELSR8SIzDUKYgNvyCYNrG5nEc0BzBD mXUJmsuwK4ASm1wO66gTtB3CaiwJk0ZlS+GkIKm8aYMnV4MDIqqYZGKeJgmH0VajRqYX uz47y5AnCTllHMf8bPvuPfamHzGkZoY07y9wHRprqf98zTtDcDUx3m1r0ZWcLf/pq5ps iirJ7BhbmZRL3zmeE/Yt7darjGOiQaGtxFV7nH1ilo/WF6UqDRU9zjwspmhcSzKY+ger YiQGaccTJSDzzwGE0IQaIxtEEphNDRSwk4jr8+E40EztryetqCysmbe0lypK+AzJErh5 Wp7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=f5c5hUHT; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p5si2298832oto.116.2019.12.03.14.52.22; Tue, 03 Dec 2019 14:52:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=f5c5hUHT; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729735AbfLCWwV (ORCPT + 15 others); Tue, 3 Dec 2019 17:52:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:45022 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730009AbfLCWwU (ORCPT ); Tue, 3 Dec 2019 17:52:20 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE62A2084B; Tue, 3 Dec 2019 22:52:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413539; bh=0BKgJK0ru3iRADVaPyo5g95TkJZb3iLxgNnyE9BBUxQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f5c5hUHTp7Gq0seKtv8ZuU7FjoDUKrWxhKBxE5Yqx6UUT43eCexhEOFJg/rntZh44 y1gvuEXvo6GLAC0MBXvU/vgW3I9UJEH8HvChY21ZyGVHJ8COwTJs5g6LQEq270M9su F03hlnZuY7Zq1po2NKd2v3paXysdnyJUiGigibTQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Joel Stanley , Nick Desaulniers , Michael Ellerman , Sasha Levin Subject: [PATCH 4.19 165/321] powerpc/32: Avoid unsupported flags with clang Date: Tue, 3 Dec 2019 23:33:51 +0100 Message-Id: <20191203223435.722372817@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191203223427.103571230@linuxfoundation.org> References: <20191203223427.103571230@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Joel Stanley [ Upstream commit 72e7bcc2cdf82bf03caaa5e6c9b0134c2fc2ee7d ] When building for ppc32 with clang these flags are unsupported: -ffixed-r2 and -mmultiple llvm's lib/Target/PowerPC/PPCRegisterInfo.cpp marks r2 as reserved on when building for SVR4ABI and !ppc64: // The SVR4 ABI reserves r2 and r13 if (Subtarget.isSVR4ABI()) { // We only reserve r2 if we need to use the TOC pointer. If we have no // explicit uses of the TOC pointer (meaning we're a leaf function with // no constant-pool loads, etc.) and we have no potential uses inside an // inline asm block, then we can treat r2 has an ordinary callee-saved // register. const PPCFunctionInfo *FuncInfo = MF.getInfo(); if (!TM.isPPC64() || FuncInfo->usesTOCBasePtr() || MF.hasInlineAsm()) markSuperRegs(Reserved, PPC::R2); // System-reserved register markSuperRegs(Reserved, PPC::R13); // Small Data Area pointer register } This means we can safely omit -ffixed-r2 when building for 32-bit targets. The -mmultiple/-mno-multiple flags are not supported by clang, so platforms that might support multiple miss out on using multiple word instructions. We wrap these flags in cc-option so that when Clang gains support the kernel will be able use these flags. Clang 8 can then build a ppc44x_defconfig which boots in Qemu: make CC=clang-8 ARCH=powerpc CROSS_COMPILE=powerpc-linux-gnu- ppc44x_defconfig ./scripts/config -e CONFIG_DEVTMPFS -d DEVTMPFS_MOUNT make CC=clang-8 ARCH=powerpc CROSS_COMPILE=powerpc-linux-gnu- qemu-system-ppc -M bamboo \ -kernel arch/powerpc/boot/zImage \ -dtb arch/powerpc/boot/dts/bamboo.dtb \ -initrd ~/ppc32-440-rootfs.cpio \ -nographic -serial stdio -monitor pty -append "console=ttyS0" Link: https://github.com/ClangBuiltLinux/linux/issues/261 Link: https://bugs.llvm.org/show_bug.cgi?id=39556 Link: https://bugs.llvm.org/show_bug.cgi?id=39555 Signed-off-by: Joel Stanley Reviewed-by: Nick Desaulniers Signed-off-by: Michael Ellerman Signed-off-by: Sasha Levin --- arch/powerpc/Makefile | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) -- 2.20.1 diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile index c4c03992ee828..dfcb698ec8f3b 100644 --- a/arch/powerpc/Makefile +++ b/arch/powerpc/Makefile @@ -145,7 +145,14 @@ endif CFLAGS-$(CONFIG_PPC64) += $(call cc-option,-mcmodel=medium,$(call cc-option,-mminimal-toc)) CFLAGS-$(CONFIG_PPC64) += $(call cc-option,-mno-pointers-to-nested-functions) -CFLAGS-$(CONFIG_PPC32) := -ffixed-r2 $(MULTIPLEWORD) +# Clang unconditionally reserves r2 on ppc32 and does not support the flag +# https://bugs.llvm.org/show_bug.cgi?id=39555 +CFLAGS-$(CONFIG_PPC32) := $(call cc-option, -ffixed-r2) + +# Clang doesn't support -mmultiple / -mno-multiple +# https://bugs.llvm.org/show_bug.cgi?id=39556 +CFLAGS-$(CONFIG_PPC32) += $(call cc-option, $(MULTIPLEWORD)) + CFLAGS-$(CONFIG_PPC32) += $(call cc-option,-mno-readonly-in-sdata) ifdef CONFIG_PPC_BOOK3S_64