From patchwork Thu Oct 3 15:49:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 175125 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp551684ill; Thu, 3 Oct 2019 09:25:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqziiQet92Ef5CRkgvNcQc04K/LeHN+5mowPoiAMFHY2lrWGQ8+2tn3/+v23mABQOcWLy00W X-Received: by 2002:aa7:d313:: with SMTP id p19mr10305263edq.197.1570119946605; Thu, 03 Oct 2019 09:25:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570119946; cv=none; d=google.com; s=arc-20160816; b=u51Iq0twO1/Dy4JE/0FR5Bk2Tqz5htLutdy5rCu9bahf6ZoDAFjBwN2cia1+O1UpVk iuhr7Q8BNoSeTKCV8+Zp8egOgkgGLB1ASoihc2QN2hWMox4SxcS2scEAQcvBwJiFDtva oAuW4jhAsgYp2AMtBJekgev3d4r4/qNWlX5UZGlQDNTy7XbreS2xI0t242XkFIdsITJP ePjf04XA3JR8ssDP3i+xGGISzoYFxuKCGkCQYcVB0522DF08jitDkMQn/zUyOE3NBp8T oilFr1gFKj6T26crXEhme63b4uFhn6CHfyLo5rkayqNQ9ZjiPfCbe+87f21C/rBBz/3K oDLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wnTM9D7gjE73iv/01ERT6DtJGUzHADOdRS2lRhk8bJU=; b=yJiC9qY5adi86J+6v3gdq81htkpGAyVtHR9sllDaQcFzISaQoGEmrrJ8MSR9e4zPx0 GDd+jyiXa7vVNQzEFg1RNzPeX2o/IMNtsZ2A1lwa/Mb40HYivCOl0PzGGnBnXBM2yaJB JIwJ6axuH8C0ONBdmmfEevkvfldeYkEGb2b0cJxKPPPF/tsRHk4m7CKP8OZPqowhm0LY PGeo8eW3hS5ZJgUKZNP2oye91QQseqpYpy6QRjdcQdiZFMxxkPZA2omKWr6Q9nADSXr/ A24A+fOqRucZENwbc+JHtECkPeXtN0ZyKC7CK0DKkWksxwlb5ZhyNbsn21ziylCXHo2K PAWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="PUh30/eW"; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w14si1764581edx.197.2019.10.03.09.25.46; Thu, 03 Oct 2019 09:25:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="PUh30/eW"; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733002AbfJCQZn (ORCPT + 14 others); Thu, 3 Oct 2019 12:25:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:56112 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390958AbfJCQZm (ORCPT ); Thu, 3 Oct 2019 12:25:42 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 79B4220867; Thu, 3 Oct 2019 16:25:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570119942; bh=kvo8e6FkZ7qO+5CeiOkhJiM1oUsYCDpijb9DiyqS2Zs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PUh30/eWyVuCo3Wqxh2PoCYnVuuJE4ezug3WJfCIzrlqDM7zxZMaYmEGhSfUB1Gjb XSjCG7N1jkQt8cLxdR+DMUyZ2LuW9TX1jNV2LW6a3LTGPJZ3d0Rop+oFxdqLWu2jz6 MXkS01c4xEql6ta2KVvninDI5XzdgKpHxxkGQouM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bjorn Andersson , Jakub Kicinski Subject: [PATCH 5.2 006/313] net: qrtr: Stop rx_worker before freeing node Date: Thu, 3 Oct 2019 17:49:44 +0200 Message-Id: <20191003154534.142045176@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154533.590915454@linuxfoundation.org> References: <20191003154533.590915454@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Bjorn Andersson [ Upstream commit 73f0c11d11329a0d6d205d4312b6e5d2512af7c5 ] As the endpoint is unregistered there might still be work pending to handle incoming messages, which will result in a use after free scenario. The plan is to remove the rx_worker, but until then (and for stable@) ensure that the work is stopped before the node is freed. Fixes: bdabad3e363d ("net: Add Qualcomm IPC router") Cc: stable@vger.kernel.org Signed-off-by: Bjorn Andersson Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/qrtr/qrtr.c | 1 + 1 file changed, 1 insertion(+) --- a/net/qrtr/qrtr.c +++ b/net/qrtr/qrtr.c @@ -150,6 +150,7 @@ static void __qrtr_node_release(struct k list_del(&node->item); mutex_unlock(&qrtr_node_lock); + cancel_work_sync(&node->work); skb_queue_purge(&node->rx_queue); kfree(node); }