From patchwork Wed Sep 18 17:19:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 173985 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp2731840ill; Wed, 18 Sep 2019 10:19:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqzUQaRsRmYtinEVjHA9D9qflk960FoGiVGi/zr+D1DNrUmAcybhufh3qcwjdP1PKncxqSYR X-Received: by 2002:a50:cf0d:: with SMTP id c13mr11384940edk.125.1568827167345; Wed, 18 Sep 2019 10:19:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568827167; cv=none; d=google.com; s=arc-20160816; b=QDAijPBBQSO9X4ZfVqA3y6bZlRYqUmO3OAfqLF66iS/VZcPg5xDK+XD3S5xIpAyvBL ldnFakr16b8hhPFtVmhdb/9RK5k6RHqdMRQVHaAAKO/92bMFsYf2MNkjoOcJSKi+I+r9 P1gZUwzmIEHGgKHs826GrriG4cGq/dEEq1q3KDG7nvGB1KMOFuso4qes7mh7iR4Z9N2w Ru/EPk76nj+yBqA7EDBwahfZBZqvJWVjaU3tqsJ2neEZKn8Plkrti+KuHVAQVBtepKwi vY64xpE812GLF4TcC8Hjhnkge8nRtd3/CdtC1k96JQSIKUs1mEjnCNrmvuesl8NJ7lBM inJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=j0roT+o44pSB3MM7mlqj6crjaHtjbvUFCdPy0FOZOMU=; b=Qc8yHfjg5n2L1PgxTRD0pcyZBVEtZIXw4vAH2GKqs5lKdUr3Q3fpKbmElpNBsZ6/Du OVwpy7Kg9dpWam/L/Yp+jLoCfmCSKaFAN9n5cuEAbFpbhVWtvyHxveBVNYXuzXcH9/ms ALO5ZXIbAtGBwFntu1hlh+0kq7lBYewFlgSzGn1noKszm/JwZiq4UwHN7Y1ZQBfqmmC/ IGySLaBV2HebYobQvV4+H/VONNONBKxPCcE1Db+NNCSKJ0Skw/yzR7FOCFZnSE7oAB7J akUbXRLKWD3u8SRzf+dNC6mV4hlqyjRjWoF4crfcAbc0YFOXz5ohq2Y5IvFaDjb/pqjA tDqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=O4JEUjWN; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id om23si3416800ejb.194.2019.09.18.10.19.27; Wed, 18 Sep 2019 10:19:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=O4JEUjWN; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732100AbfIRRTX (ORCPT + 14 others); Wed, 18 Sep 2019 13:19:23 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:39131 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732099AbfIRRTX (ORCPT ); Wed, 18 Sep 2019 13:19:23 -0400 Received: by mail-pg1-f195.google.com with SMTP id u17so219208pgi.6 for ; Wed, 18 Sep 2019 10:19:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=j0roT+o44pSB3MM7mlqj6crjaHtjbvUFCdPy0FOZOMU=; b=O4JEUjWNfJnoTHf3Kz89DjXTVO8W5+rzHM+ls2mRU28W2FV8b8nZpi6L4cqrkJ3F9M YNXjD36ZsIeuhFahMECAXywua8oqYrxpt1YatcxAwxFJK9o8yNXSuTbqI2vXKYbh9p6N m6cO55tIKUoEWfQv6zUtFnHHhSEaHEkcJ9GU5jj8LdOugJZpZqqSyw4shaBwj57pe2vE d4kyc4biEk89OMh2r0LCFn+HzKVVH0MLLffXz+uCuT8rhq7ATBdYujE5awZYqY1PKdfZ ZdaThZ6464sjkSOeHGmwdi2hbFJGRoV9AsQs0ByhiPZzcpKm6rrL7HIXmoiFAxGyDUqs bklQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=j0roT+o44pSB3MM7mlqj6crjaHtjbvUFCdPy0FOZOMU=; b=jJMkOefPGwNBMakgSBT06K4BJuWVcRJ1jdKNeyWmm0e5dx+1nhTjXUn1jloyPkg6yU Op+NXUZjFqkHL15aGQdu/TWMXbCvY995wqpbFDU7MoSms6hlZhOKtcMH0y5Vodb0RJGa zdTvSA74PgcXH730pMF+WiM3xIPvbcteIyZX3vShd6UjWxPNsgtd83wod8O5VH3OnjQu G/LB5jLUM1qQRwbFJTLIBmpDXVsYpOxEgAlCHpNxAsEHYxmEYjsIoP3Hp0M9BDz4KWeX Ggb2+/ioDUv0FSR0KQS4j6wrmsW6Di5HzperWq2xj+GLuGqc/f84KLcjLD0mcZimnkbB i2/Q== X-Gm-Message-State: APjAAAUyKzH1LsW+wF3I3/XviuTQTtqiIT7F4DcOq9saHUyGig8iSU+M mHTWG59ruaJYo3Hk/JB7xqzGKQ== X-Received: by 2002:aa7:9216:: with SMTP id 22mr5574508pfo.214.1568827162439; Wed, 18 Sep 2019 10:19:22 -0700 (PDT) Received: from localhost.localdomain (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id y4sm2614981pjn.19.2019.09.18.10.19.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Sep 2019 10:19:21 -0700 (PDT) From: Bjorn Andersson To: Ohad Ben-Cohen , Bjorn Andersson , Srinivas Kandagatla , Jorge Ramirez Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 2/6] rpmsg: glink: Fix use after free in open_ack TIMEOUT case Date: Wed, 18 Sep 2019 10:19:12 -0700 Message-Id: <20190918171916.4039-3-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20190918171916.4039-1-bjorn.andersson@linaro.org> References: <20190918171916.4039-1-bjorn.andersson@linaro.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arun Kumar Neelakantam Extra channel reference put when remote sending OPEN_ACK after timeout causes use-after-free while handling next remote CLOSE command. Remove extra reference put in timeout case to avoid use-after-free. Fixes: b4f8e52b89f6 ("rpmsg: Introduce Qualcomm RPM glink driver") Cc: stable@vger.kernel.org Signed-off-by: Arun Kumar Neelakantam Signed-off-by: Bjorn Andersson --- drivers/rpmsg/qcom_glink_native.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) -- 2.18.0 diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index 9355ce26fd98..72ed671f5dcd 100644 --- a/drivers/rpmsg/qcom_glink_native.c +++ b/drivers/rpmsg/qcom_glink_native.c @@ -1103,13 +1103,12 @@ static int qcom_glink_create_remote(struct qcom_glink *glink, close_link: /* * Send a close request to "undo" our open-ack. The close-ack will - * release the last reference. + * release qcom_glink_send_open_req() reference and the last reference + * will be relesed after receiving remote_close or transport unregister + * by calling qcom_glink_native_remove(). */ qcom_glink_send_close_req(glink, channel); - /* Release qcom_glink_send_open_req() reference */ - kref_put(&channel->refcount, qcom_glink_channel_release); - return ret; }