From patchwork Wed Sep 18 17:19:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 173984 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp2731817ill; Wed, 18 Sep 2019 10:19:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqy0N/H8CHnxtkbV81gKQusM4ASXFEWIVe6F9lQzEL6+Wzey3FBKSDbj+WJ1C/fDOgwGUJg8 X-Received: by 2002:a17:906:82d3:: with SMTP id a19mr250151ejy.151.1568827165997; Wed, 18 Sep 2019 10:19:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568827165; cv=none; d=google.com; s=arc-20160816; b=jY8vsTeFC93T7eoXt8E1OFvlQLsx8N1oJltOsddxImUP+GCDfgs+bMhKNPQt6EYfuk KAzmCWMDuHGCmDaQYmbMggDO+YZooys1cb2/TGzQ+PSV9+a0xoEQm98HlsUEdHeLMS0x N+0S9jSbzi+XqHVCU3IJ0sTHRWY3oxwU+0ef/x6vupxKhAmfJ45wVTFca0uwKHJCEde0 pYlwJ7U4/w2cOqnI676VTMBOFPS4OTsiM0yJD5gWoSQYvEmfPYnDHezal/L0IKL5u3Pi Lizt/BA6K7fY17p3fCXqP4v/43ZAc8EzAZj2iCHKp6VRe2ojo8t5VycDj8A/Uxa0+f44 bD9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=KEWAXnlLjNC2nv8CVNynnjfMbw9zNY+Gb9tPaivirx0=; b=brYxIGms7jF20NAXx37P3TTgp81fTsBG+wko0pMUUUTS9SqGd02bFuhN5JSamclpdf wWppgmS7ppg/cElOSlGyZLYC+HrdrdxD0sQWbi41zjd8Zs5nINbY6ZRCFSaPwWanGNKt Po15cFnvRv7rnWEIHtf31VkRxzVQs+RmRibWwaYSCRFEyP6OWjnLpSQ4AnIuCtAmKJBW +63tR0m1i+Kw9Me/3VJnE/1rvnZqFlGlzGLQcxf3fVFMR+IIIu42ujyg4iK4IdqDC/y0 qFEMjt1R6SxGlQD7ihlpIlS7IZ/Xuw84fLLalthWE3ACQh7NvMAg0qUqmyZV2YwSMfX1 JzaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DrV6yqHP; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id om23si3416800ejb.194.2019.09.18.10.19.25; Wed, 18 Sep 2019 10:19:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DrV6yqHP; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732065AbfIRRTW (ORCPT + 14 others); Wed, 18 Sep 2019 13:19:22 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:35933 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731322AbfIRRTV (ORCPT ); Wed, 18 Sep 2019 13:19:21 -0400 Received: by mail-pg1-f196.google.com with SMTP id m29so230555pgc.3 for ; Wed, 18 Sep 2019 10:19:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KEWAXnlLjNC2nv8CVNynnjfMbw9zNY+Gb9tPaivirx0=; b=DrV6yqHPlQC+6968RW8zY7OfYQOEud2XhRgMxa0V/FestL0ujwS6mS1ef4P3er4CFx YhWMA+vNLvjFQ9iRqdji403DJ31sUwHdAgCrOSEwodwZ4HEtgNUhTGAS9pYSYV8TsKK0 jX0niNN4fqvKG5a5c7wA5iv3Rq7IZrPBSkH7hHwIDgTMEZwsx73F0rBhsKqD2l9BGt4u FkEKnZs3m6FFnr/MH8qGU1wYzvI7h3XeonN6pg0R7tlNWSm6AndB+HnUKy2bw6F9aVcH qUKstThFhTPriRymtDqCK5s7H8ajExcPNAf7kUcTRQEW/LOdA7Q/T0i7oD3tOd1TPXC1 wDeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KEWAXnlLjNC2nv8CVNynnjfMbw9zNY+Gb9tPaivirx0=; b=AJtkd1BE6EGaMnv18U9acJFO7Mhl2CrQO+mAlYAhMbaWaTKflWhk7Qi3Zp8+p6eQW6 Spw17V4G8OSfy6EGKoExMVx0aujqspd677hPu/53TlUMeKx4ebA7qL36eRyZxjO6LANj 7xet0ySHSvZK1AGt9X0+/vdzwoBkcU+got1ccrDjS1XVU/1WTGp5sr5B0kvh7Ufift3x gxkmx/QIm06dMCVsawnQiDFuHg2NZHY+WCrBJXRMJwvbfbMFYe5/02EEJRe+cO7o1Pdz Z0lbBIbMHg3RLLcGUjTwNtqWhau3qzCyX+xMavlMd8rOveEWkHSKGO4WDxTBbhlFuyfw 1MEg== X-Gm-Message-State: APjAAAUpM129QB9Mo2j7THfbtChKvlLSCUwmwWLdUkPzKsumXvIhekAp f9gD4GbFosegVp0FDfjxJ6A04A== X-Received: by 2002:a62:2b4d:: with SMTP id r74mr5507565pfr.30.1568827161136; Wed, 18 Sep 2019 10:19:21 -0700 (PDT) Received: from localhost.localdomain (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id y4sm2614981pjn.19.2019.09.18.10.19.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Sep 2019 10:19:20 -0700 (PDT) From: Bjorn Andersson To: Ohad Ben-Cohen , Bjorn Andersson , Srinivas Kandagatla , Jorge Ramirez Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 1/6] rpmsg: glink: Fix reuse intents memory leak issue Date: Wed, 18 Sep 2019 10:19:11 -0700 Message-Id: <20190918171916.4039-2-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20190918171916.4039-1-bjorn.andersson@linaro.org> References: <20190918171916.4039-1-bjorn.andersson@linaro.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arun Kumar Neelakantam Memory allocated for re-usable intents are not freed during channel cleanup which causes memory leak in system. Check and free all re-usable memory to avoid memory leak. Fixes: 933b45da5d1d ("rpmsg: glink: Add support for TX intents") Cc: stable@vger.kernel.org Signed-off-by: Arun Kumar Neelakantam Reported-by: Srinivas Kandagatla Signed-off-by: Bjorn Andersson --- drivers/rpmsg/qcom_glink_native.c | 9 +++++++++ 1 file changed, 9 insertions(+) -- 2.18.0 diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c index 621f1afd4d6b..9355ce26fd98 100644 --- a/drivers/rpmsg/qcom_glink_native.c +++ b/drivers/rpmsg/qcom_glink_native.c @@ -241,10 +241,19 @@ static void qcom_glink_channel_release(struct kref *ref) { struct glink_channel *channel = container_of(ref, struct glink_channel, refcount); + struct glink_core_rx_intent *tmp; unsigned long flags; + int iid; spin_lock_irqsave(&channel->intent_lock, flags); + idr_for_each_entry(&channel->liids, tmp, iid) { + kfree(tmp->data); + kfree(tmp); + } idr_destroy(&channel->liids); + + idr_for_each_entry(&channel->riids, tmp, iid) + kfree(tmp); idr_destroy(&channel->riids); spin_unlock_irqrestore(&channel->intent_lock, flags);