From patchwork Thu Feb 14 02:10:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Long X-Patchwork-Id: 158287 Delivered-To: patches@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp793895jaa; Wed, 13 Feb 2019 18:10:44 -0800 (PST) X-Received: by 2002:ac8:31ab:: with SMTP id h40mr1094668qte.122.1550110244337; Wed, 13 Feb 2019 18:10:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550110244; cv=none; d=google.com; s=arc-20160816; b=czIaJv8BIBAXEic/3EJAPcgIBKQt23BAfMYCyAmqSZnTtEsf0pCKqv26FBQ7appKBv iddOelp2RFa/wzUhy+fZuq4LFkvyBGSUNV+IWUUVES9kdJc/qgp/IK8i1aEm7EI4L79Y DNKDas0fvpm7+EiJt4+zArID0C3z4sjlNPK0HdbiPCGmdh9621SDpcUW2zJgEetnsoFF ilD05z3dt2IOkA5j7KagwvwgD51lSikiGwNv0dBBislbl28PcPHK98WmEdpqkGlhg45V IUckmMMOAd/qlB0QS7v+L9o8IS/L/19cY+ZBjW7rs/goEnnHSyyq7zFsiQ5kApua16+0 TPCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=t952pQdCO8vFdgrbc2uvLXfj7ukUT0YFXZtA0v/0jfM=; b=dXjmgcQJSVjzFCANq3IoYABxSd0LFlndhL8cWoq3GXFcyBo9ZttLNVWePJ29wIUrRX gTOdnJ+JMapyfQsp2tpxB9ymTs/zED/mo88hD81W2RUuY+Q8Vx7zUQtEZ8HR8ecoKnuP Sva0VspULwVs7axdQEfsUbwvpdtkwpaWWQJhk2zj3qmSO1jAeXbkw2q1flW51fuSVkXp kxyY8TogZ881Afp3TFgCZVDCPz6xqCL8uGVe7yjakO3pXIXkqco30zX+gwtjUgFU7LHd PN9Pdlf1bPmMhjwmIv75idlHTKSHwOVUJDUimEjZ98GPB5200H+t0toiFBvrLJ5xaEEh smqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uTNUl8vM; spf=pass (google.com: domain of dave.long@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=dave.long@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id e185sor645088qkd.87.2019.02.13.18.10.44 for (Google Transport Security); Wed, 13 Feb 2019 18:10:44 -0800 (PST) Received-SPF: pass (google.com: domain of dave.long@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uTNUl8vM; spf=pass (google.com: domain of dave.long@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=dave.long@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=t952pQdCO8vFdgrbc2uvLXfj7ukUT0YFXZtA0v/0jfM=; b=uTNUl8vMExmK2zTMmjR5pyJVKk/vJ96uti0dKLmR4uAnsllgao7RXVm750HfOIA1mT fkCGGWowkflUyM7cuzEkpSZnKJJtNKOtygnz6KdsxDSgOROKzQFTjpjHgqr23pKtmTxv mLcbtWhM/L+alcePlNwJZL+v0PgGcrX78u2xx2h2QXZCp4fu5ggQbxsImyAbBIL6IUsx GWGbWdhrnFG3LFAFhr4AaUS3GQEoNCSUOXbN9cH5Dbb9UzEk9MINU7EFv+bxpsSXzduU bnnCV02aZjZ2DUKoXbJURmeKdvbmEmpT/+S5tsm7izBNIATBVn8eAvN7nUbhgToKwOvJ /Qkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=t952pQdCO8vFdgrbc2uvLXfj7ukUT0YFXZtA0v/0jfM=; b=aio7z63nU+XfNgtvmjWjH8zaQ/QGDi+UYCjdOe8aGLKaFvpExNRjnhyqs3+1Xa9D7G Ui2JpbUWVYHWIkpfYWu/HsSghJiovWrUvs3sTThVRuct0kxbDN/a+VrrKCHxiVit9uDj oTX7qDXkuBJmnbkprM0zLkbS7oso7GyenGZC/1H0LQSQWCYbFngLkTRl5St6+4vEM+s0 CeDE5GeMMdYO7vUYUegMf/yMjvkCRrjSqbWUowh2yUFim5Z9tHjwFLi4SruPyRgsGLJ9 QljdfkcPmb0c231Ceh1iJksujo9jTthintwRgQ5H7Xx6465aQrYD81SiSzz/nf6xs08T Vmsw== X-Gm-Message-State: AHQUAuZrjb99QyxWRglu9Kq4w4G18eZazqbnLgN1DWe/NEiHI0YXYIZT rIVXR8uoPyQnFH+5zsUBQUcFu7MB X-Google-Smtp-Source: AHgI3IbKk2PzwlnIZZvylG7tKCx9qyB6fAFytvU+qfIiwprqSesCnhZ6jknn6IY+mfL+l5wJJ9ivRw== X-Received: by 2002:a37:9286:: with SMTP id u128mr1030206qkd.0.1550110244064; Wed, 13 Feb 2019 18:10:44 -0800 (PST) Return-Path: Received: from localhost.localdomain (pool-72-71-243-63.cncdnh.fast00.myfairpoint.net. [72.71.243.63]) by smtp.googlemail.com with ESMTPSA id d63sm1091575qka.22.2019.02.13.18.10.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 18:10:43 -0800 (PST) From: David Long To: stable@vger.kernel.org, Russell King - ARM Linux , Florian Fainelli , Julien Thierry , Tony Lindgren , Marc Zyngier , Greg KH , Mark Rutland Cc: Will Deacon , Mark Brown , linux-kernel@vger.kernel.org Subject: [PATCH 4.14 V2 14/17] ARM: add PROC_VTABLE and PROC_TABLE macros Date: Wed, 13 Feb 2019 21:10:19 -0500 Message-Id: <20190214021022.5313-15-dave.long@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190214021022.5313-1-dave.long@linaro.org> References: <20190214021022.5313-1-dave.long@linaro.org> From: Russell King Commit e209950fdd065d2cc46e6338e47e52841b830cba upstream. Allow the way we access members of the processor vtable to be changed at compile time. We will need to move to per-CPU vtables to fix the Spectre variant 2 issues on big.Little systems. However, we have a couple of calls that do not need the vtable treatment, and indeed cause a kernel warning due to the (later) use of smp_processor_id(), so also introduce the PROC_TABLE macro for these which always use CPU 0's function pointers. Reviewed-by: Julien Thierry Signed-off-by: Russell King Signed-off-by: David A. Long --- arch/arm/include/asm/proc-fns.h | 39 ++++++++++++++++++++++----------- arch/arm/kernel/setup.c | 4 +--- 2 files changed, 27 insertions(+), 16 deletions(-) -- 2.17.1 diff --git a/arch/arm/include/asm/proc-fns.h b/arch/arm/include/asm/proc-fns.h index 30c499146320..c259cc49c641 100644 --- a/arch/arm/include/asm/proc-fns.h +++ b/arch/arm/include/asm/proc-fns.h @@ -23,7 +23,7 @@ struct mm_struct; /* * Don't change this structure - ASM code relies on it. */ -extern struct processor { +struct processor { /* MISC * get data abort address/flags */ @@ -79,9 +79,13 @@ extern struct processor { unsigned int suspend_size; void (*do_suspend)(void *); void (*do_resume)(void *); -} processor; +}; #ifndef MULTI_CPU +static inline void init_proc_vtable(const struct processor *p) +{ +} + extern void cpu_proc_init(void); extern void cpu_proc_fin(void); extern int cpu_do_idle(void); @@ -98,18 +102,27 @@ extern void cpu_reset(unsigned long addr, bool hvc) __attribute__((noreturn)); extern void cpu_do_suspend(void *); extern void cpu_do_resume(void *); #else -#define cpu_proc_init processor._proc_init -#define cpu_check_bugs processor.check_bugs -#define cpu_proc_fin processor._proc_fin -#define cpu_reset processor.reset -#define cpu_do_idle processor._do_idle -#define cpu_dcache_clean_area processor.dcache_clean_area -#define cpu_set_pte_ext processor.set_pte_ext -#define cpu_do_switch_mm processor.switch_mm -/* These three are private to arch/arm/kernel/suspend.c */ -#define cpu_do_suspend processor.do_suspend -#define cpu_do_resume processor.do_resume +extern struct processor processor; +#define PROC_VTABLE(f) processor.f +#define PROC_TABLE(f) processor.f +static inline void init_proc_vtable(const struct processor *p) +{ + processor = *p; +} + +#define cpu_proc_init PROC_VTABLE(_proc_init) +#define cpu_check_bugs PROC_VTABLE(check_bugs) +#define cpu_proc_fin PROC_VTABLE(_proc_fin) +#define cpu_reset PROC_VTABLE(reset) +#define cpu_do_idle PROC_VTABLE(_do_idle) +#define cpu_dcache_clean_area PROC_TABLE(dcache_clean_area) +#define cpu_set_pte_ext PROC_TABLE(set_pte_ext) +#define cpu_do_switch_mm PROC_VTABLE(switch_mm) + +/* These two are private to arch/arm/kernel/suspend.c */ +#define cpu_do_suspend PROC_VTABLE(do_suspend) +#define cpu_do_resume PROC_VTABLE(do_resume) #endif extern void cpu_resume(void); diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c index 1a041ad4881e..c1588e31aa83 100644 --- a/arch/arm/kernel/setup.c +++ b/arch/arm/kernel/setup.c @@ -693,9 +693,7 @@ static void __init setup_processor(void) cpu_name = list->cpu_name; __cpu_architecture = __get_cpu_architecture(); -#ifdef MULTI_CPU - processor = *list->proc; -#endif + init_proc_vtable(list->proc); #ifdef MULTI_TLB cpu_tlb = *list->tlb; #endif