From patchwork Wed Feb 13 21:32:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Long X-Patchwork-Id: 158260 Delivered-To: patches@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp560919jaa; Wed, 13 Feb 2019 13:32:37 -0800 (PST) X-Received: by 2002:a37:c30d:: with SMTP id a13mr247938qkj.18.1550093557134; Wed, 13 Feb 2019 13:32:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550093557; cv=none; d=google.com; s=arc-20160816; b=gBajyWq1527EK5ZyNR28Z9ZsKu83gXAr5RPoHMVoBi8BpjXMlGuI1vecyY+hkIxdM3 j3SqPfVGzcM5v4QFNg7twDJwcs0pHDkXYl0Lg3te6s8pdmviuxbiYWe5GvrvMMytscla oGfNYWQSXIFcPjYUGqnGG7lqILhBFSnPwavPxMUdI0hj3eHQvOly9ik8y7+V0AW/G0J5 GrpfKw+4xMJ1iHWICdKhG8+NjCfBmhvyzip9P+1MUh5BDvmXNn+AvIyFJZBzcmXkjh1C LKNpXd2DRydkEL6ReAqxqjfxjBxJCzFFPTpPNYMHyEDPp8tC2f8hyk6tF6Yl48gxoVli +vvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rK+V5Bt5jiMQbW7MEfKBAMfmgwoZSjPrByJHM+oVMeo=; b=A/QQF9sZOtEtRpI1kJI4I0G7DKgeZg8Tcv8CcJIGobV+HbkJbNd2DbFcQJnzdCnQx1 o64YDbzFUfHQV95qxDVX7GIYOQp4A6S+9JJhbdo6AJZJIXPi5HUtZr3JsGUnZtHOKNNo chzbiPCBZMWJBZA2HnmiOQOdlQYgDiPv1lLN8jeQNIfZ0co8qH6VhOQ1mvfqCHYtxG7O QcB6gnZoHjglRFfYJ4R/zD3lobbUb7/k6T/1swxR+8XYFPsGHT0n5a9fH9CWNHleyCb5 rC7bHf/iMsbmJFD22ERRs96RSUSRn+lPKCyns3PGJhnciirjuc0IUByKtooDjy4v6uCV OMKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="GTJ/bm4f"; spf=pass (google.com: domain of dave.long@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=dave.long@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id m89sor589927qte.5.2019.02.13.13.32.37 for (Google Transport Security); Wed, 13 Feb 2019 13:32:37 -0800 (PST) Received-SPF: pass (google.com: domain of dave.long@linaro.org designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="GTJ/bm4f"; spf=pass (google.com: domain of dave.long@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=dave.long@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=rK+V5Bt5jiMQbW7MEfKBAMfmgwoZSjPrByJHM+oVMeo=; b=GTJ/bm4fEru5IpP4vE+G1cANhMJFH2iFjAYzU/wHNNGNCwI+nz6rQOavzMJnf+tdmz Ap1od0Qvoqs1tG719Cp3mvlcOMz8/tjSGFQmxmFns3VpNswa7Y/etgTGt7uJVxT/rvEy 5n2hMb6jBYK4122o8N1rIHPGv6Y4ID/+IxcCm/swWZxPYAb/zbxXrG4/vCSIjDTPUutc AQEbWgTmEuyoKkWaXWLpZuQVHxGthkZbN0XxqwgmGW7lyZGU9KHse1r5L31bOfkBcWuF 5gFGrsP8/N76vlwfkFAaJtunv5NFkicZIyxvzZ+Xhssaefi+LF4jDyAmzmUE9BI3Bk69 D4Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=rK+V5Bt5jiMQbW7MEfKBAMfmgwoZSjPrByJHM+oVMeo=; b=guTHCzQMIi62MOeTl08HvLNof82+9MVq18T47prLpb2MHT/4hMEkgvn1lv5mD1sdfN m0dSgG1MJmJ/2xnTzpdracfHRG/KdOrseZBi4XmKsHx+6BwcooCzoWGuU0fJ6jBRJWWv aFlFY8kD9iK21ETkUq3hIwDaU/LGGHKuD7vRTgUpeQFKnOd18aGXR5ZAcRSLI4qy93RP aa+uZx7NLfuI+896kybnrh+JQtu0uM3M+wXN/42PjiajL7dAtJnhvFQ9J1n4PH3JAoHB pKjdhH1ifzzM7CyDrHhkeWlRowG64BxnxpUw3WCIxDN2RWNv8R7gYip5JphGrxYVjGc5 lfpA== X-Gm-Message-State: AHQUAuaLCxCG0dW8v+PFMuw6MPlgUZMtBzw1nC/iNV6dJZ5FJjL+2YOm HuthxQZ8w7rukorMtI1NAZn9A/kZ X-Google-Smtp-Source: AHgI3IZkKR2llmVo8RdV9zV7WDCBMsjzMV5rSO5HFmnFH7Xd80JGy4FrAg8iUKvUppos0QoYTbSBGw== X-Received: by 2002:ac8:1e04:: with SMTP id n4mr224614qtl.378.1550093556875; Wed, 13 Feb 2019 13:32:36 -0800 (PST) Return-Path: Received: from localhost.localdomain (pool-72-71-243-63.cncdnh.fast00.myfairpoint.net. [72.71.243.63]) by smtp.googlemail.com with ESMTPSA id 8sm382675qtr.7.2019.02.13.13.32.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 13:32:36 -0800 (PST) From: David Long To: stable@vger.kernel.org, Russell King - ARM Linux , Florian Fainelli , Julien Thierry , Tony Lindgren , Marc Zyngier , Greg KH , Mark Rutland Cc: Will Deacon , Mark Brown , linux-kernel@vger.kernel.org Subject: [PATCH 4.19 08/17] ARM: 8796/1: spectre-v1, v1.1: provide helpers for address sanitization Date: Wed, 13 Feb 2019 16:32:14 -0500 Message-Id: <20190213213223.916-9-dave.long@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190213213223.916-1-dave.long@linaro.org> References: <20190213213223.916-1-dave.long@linaro.org> From: Julien Thierry Commit afaf6838f4bc896a711180b702b388b8cfa638fc upstream. Introduce C and asm helpers to sanitize user address, taking the address range they target into account. Use asm helper for existing sanitization in __copy_from_user(). Signed-off-by: Julien Thierry Signed-off-by: Russell King Signed-off-by: David A. Long --- arch/arm/include/asm/assembler.h | 11 +++++++++++ arch/arm/include/asm/uaccess.h | 26 ++++++++++++++++++++++++++ arch/arm/lib/copy_from_user.S | 6 +----- 3 files changed, 38 insertions(+), 5 deletions(-) -- 2.17.1 diff --git a/arch/arm/include/asm/assembler.h b/arch/arm/include/asm/assembler.h index b17ee03d280b..88286dd483ff 100644 --- a/arch/arm/include/asm/assembler.h +++ b/arch/arm/include/asm/assembler.h @@ -467,6 +467,17 @@ THUMB( orr \reg , \reg , #PSR_T_BIT ) #endif .endm + .macro uaccess_mask_range_ptr, addr:req, size:req, limit:req, tmp:req +#ifdef CONFIG_CPU_SPECTRE + sub \tmp, \limit, #1 + subs \tmp, \tmp, \addr @ tmp = limit - 1 - addr + addhs \tmp, \tmp, #1 @ if (tmp >= 0) { + subhss \tmp, \tmp, \size @ tmp = limit - (addr + size) } + movlo \addr, #0 @ if (tmp < 0) addr = NULL + csdb +#endif + .endm + .macro uaccess_disable, tmp, isb=1 #ifdef CONFIG_CPU_SW_DOMAIN_PAN /* diff --git a/arch/arm/include/asm/uaccess.h b/arch/arm/include/asm/uaccess.h index 1191e7da8fab..c136eef8f690 100644 --- a/arch/arm/include/asm/uaccess.h +++ b/arch/arm/include/asm/uaccess.h @@ -99,6 +99,32 @@ static inline void set_fs(mm_segment_t fs) #define __inttype(x) \ __typeof__(__builtin_choose_expr(sizeof(x) > sizeof(0UL), 0ULL, 0UL)) +/* + * Sanitise a uaccess pointer such that it becomes NULL if addr+size + * is above the current addr_limit. + */ +#define uaccess_mask_range_ptr(ptr, size) \ + ((__typeof__(ptr))__uaccess_mask_range_ptr(ptr, size)) +static inline void __user *__uaccess_mask_range_ptr(const void __user *ptr, + size_t size) +{ + void __user *safe_ptr = (void __user *)ptr; + unsigned long tmp; + + asm volatile( + " sub %1, %3, #1\n" + " subs %1, %1, %0\n" + " addhs %1, %1, #1\n" + " subhss %1, %1, %2\n" + " movlo %0, #0\n" + : "+r" (safe_ptr), "=&r" (tmp) + : "r" (size), "r" (current_thread_info()->addr_limit) + : "cc"); + + csdb(); + return safe_ptr; +} + /* * Single-value transfer routines. They automatically use the right * size if we just have the right pointer type. Note that the functions diff --git a/arch/arm/lib/copy_from_user.S b/arch/arm/lib/copy_from_user.S index a826df3d3814..6709a8d33963 100644 --- a/arch/arm/lib/copy_from_user.S +++ b/arch/arm/lib/copy_from_user.S @@ -93,11 +93,7 @@ ENTRY(arm_copy_from_user) #ifdef CONFIG_CPU_SPECTRE get_thread_info r3 ldr r3, [r3, #TI_ADDR_LIMIT] - adds ip, r1, r2 @ ip=addr+size - sub r3, r3, #1 @ addr_limit - 1 - cmpcc ip, r3 @ if (addr+size > addr_limit - 1) - movcs r1, #0 @ addr = NULL - csdb + uaccess_mask_range_ptr r1, r2, r3, ip #endif #include "copy_template.S"