From patchwork Fri Jun 22 15:46:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jason A. Donenfeld" X-Patchwork-Id: 139716 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp1028778lji; Fri, 22 Jun 2018 08:46:34 -0700 (PDT) X-Google-Smtp-Source: ADUXVKK7kRupvxsJGvkSt+87iPOAvZG2C1VbLRSRYL9ih2wpjTFxPcVEXrFmgvfwFFhunbkP/h23 X-Received: by 2002:a63:8dca:: with SMTP id z193-v6mr1893368pgd.451.1529682394254; Fri, 22 Jun 2018 08:46:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529682394; cv=none; d=google.com; s=arc-20160816; b=txhsJB1MDVSrKWyg6aFaUtgEUfKeDwtOcMKaIphmpMEGN/SAicDk3L9uMlxf2Za5pJ wa6MKHbwbbwySmgXsK6CGZ55dThRzfG/7yxoqTyiTAD652CZ8XEp0z5ZuwDsG0L2h9xv Zh9fIJZfvEbwvHBElDQl5UtWR2MynFs2MW4PEtJn+C74M6vO//LktHsVWpJmtJWZHk2s DP7Qx/Mqergw71Vxu2kczB6z3Gu40dqBalc41jzSkF60w6C/f27dslakTonRjEDsJdO9 POD9xyRlNGHKrJSfQdPDQUv8n122IDcK4HbixTb+a6ZR851u+2uWCaOi9QcEwipm1IJd 8CiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=jpZnm1YyIdLqnSXPTxrZgdSED/90cNSisvGzPI6ptbU=; b=FRZl60QVWhQSBfu6mtkfiTxogdPhE6B0VNHrbMpeor/9hpzHMjKenNJAptqmwopXSO SNp5r4vYdRIHJwe5mA1iJO7D1iZvPr8MUi3QR5KITOcch5+BhDGyrFfx6YTs1gK8FtPE g7SXadU5eYwJhWR740ss/09XdSCjdeXxH9DyZkTSjJHJo/3wbM9HgDZmn8mHuCURp89N MM8xIuhrM55PC4cEEvONFWLUVrkE6lq6QMFx0Gs7hbrCQr1R0Yo2ZeIBHu181NUv6oj7 7Lvzh65z4xZ45RM03lwFP2F19ZF0YW0hhT/TdoF5Q0fwihoeiFclR9mWmb4c64Xtq1vO a68g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=mail header.b=ffNjqBT1; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t1-v6si6298123pge.439.2018.06.22.08.46.33; Fri, 22 Jun 2018 08:46:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=mail header.b=ffNjqBT1; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933700AbeFVPqc (ORCPT + 13 others); Fri, 22 Jun 2018 11:46:32 -0400 Received: from frisell.zx2c4.com ([192.95.5.64]:34461 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933670AbeFVPqc (ORCPT ); Fri, 22 Jun 2018 11:46:32 -0400 Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTP id b6585bef; Fri, 22 Jun 2018 15:40:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=from:to:cc :subject:date:message-id:in-reply-to:references; s=mail; bh=KW60 zVfrC8Hwr589uxTW8kpYXS0=; b=ffNjqBT1w6jjw84lejxF+5ntbUZqSN56rWHf HFe/wfV7l16uX3hZk+Xr7Aj1M2VW6nIDGwhGDslEId54vCDcXiTiQ6djPGYNSXbE EmiaraXNeTzD3DaoxZ6lhm10xdHqAkLQ+JLLmRl0ZvWEfk+DUQzD74hIZWeluvHK 2Z1/qUCCYGRt9lXbnclZT4nTiNuJXuvUqptkvAh/WkM7R5crP1JACs31AwlByHsO 2LUKBN8sy+n7m9nmqOSh30gxyIQNbUQgerrRNboDr8W3n4Mpac31Pb6SyJ6GBF1p uvAYP4RIuOBMF1QW2MUCoaPkkSe4GziWp7xOOjoIGrFFDhs7NQ== Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 00b1b5ac (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Fri, 22 Jun 2018 15:40:15 +0000 (UTC) From: "Jason A. Donenfeld" To: Shakeel Butt Cc: "Jason A. Donenfeld" , David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Andrey Ryabinin , stable@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] kasan: depend on CONFIG_SLUB_DEBUG Date: Fri, 22 Jun 2018 17:46:23 +0200 Message-Id: <20180622154623.25388-1-Jason@zx2c4.com> In-Reply-To: References: Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org KASAN depends on having access to some of the accounting that SLUB_DEBUG does; without it, there are immediate crashes [1]. So, the natural thing to do is to make KASAN select SLUB_DEBUG. [1] http://lkml.kernel.org/r/CAHmME9rtoPwxUSnktxzKso14iuVCWT7BE_-_8PAC=pGw1iJnQg@mail.gmail.com Fixes: f9e13c0a5a33 ("slab, slub: skip unnecessary kasan_cache_shutdown()") Cc: Shakeel Butt Cc: David Rientjes Cc: Christoph Lameter Cc: Pekka Enberg Cc: Joonsoo Kim Cc: Andrew Morton Cc: Andrey Ryabinin Cc: Cc: Cc: Signed-off-by: Jason A. Donenfeld --- lib/Kconfig.kasan | 1 + 1 file changed, 1 insertion(+) -- 2.17.1 Acked-by: Michal Hocko Reviewed-by: Shakeel Butt diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan index 3d35d062970d..c253c1b46c6b 100644 --- a/lib/Kconfig.kasan +++ b/lib/Kconfig.kasan @@ -6,6 +6,7 @@ if HAVE_ARCH_KASAN config KASAN bool "KASan: runtime memory debugger" depends on SLUB || (SLAB && !DEBUG_SLAB) + select SLUB_DEBUG if SLUB select CONSTRUCTORS select STACKDEPOT help