From patchwork Wed Oct 25 01:56:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Levin, Alexander \(Sasha Levin\)" X-Patchwork-Id: 117006 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp329420qgn; Tue, 24 Oct 2017 19:09:48 -0700 (PDT) X-Google-Smtp-Source: ABhQp+RqUXR2O9VOEuyIJbqo5Ii4DMS74zljEB6DwVsACcopH/oRFzhylmKu1nCDsSRdHM+nJecw X-Received: by 10.98.198.28 with SMTP id m28mr605460pfg.217.1508897388243; Tue, 24 Oct 2017 19:09:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508897388; cv=none; d=google.com; s=arc-20160816; b=vfGHpQCJR/1CtT1a/GoxZ68uUBr0PmDWE8nceWWZnbIEVQ0QfJHyUwgR4o6jBokGCN zEc+p/Lck6OMZk0NeylItWZWE3hRBZG7WEQJIu8ktxaJX1bSpNwOL1tm3dyu7OdBHJmo ROr6riRZ6h7Wg95CV2N9P0qHHTFIPToiIhZolBBszxwYywAvnhwiDvVlJin6KBWOJg1R jBIliyyE5Gi9Pea/lyaLdaKe/jN8qdhEou0HtmzBMewf/UymGgBLMEM06+DGPgszBTRR dZhhclU8LgtWSORYENtZUQFLmvuZ17aSkQfMkVRe5Zhxd/UYKeLxAi7HWhr2ocVgFpqT 8t9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:to:dkim-signature :dkim-signature:cc:from:dkim-signature:arc-authentication-results; bh=zCpxbJpq29w+ZUbxvnIWqpHsaNs98LaBH6WY5s/Hxnc=; b=lrahclcAHns0+6c4OfJrdhEwO3OLGJWaf6R6wGrsWl5EeaUQLBs4NkksJzsfPNahaK gSfjWKrjv9Z3U3pXgfbeHHEEGK/QG2h5EbPclpsbs/S3cKXEa4ymmLqImIu283AoQKt0 ZuYI5sG2sVek7VCpe1E9Qn4TZY5NZqbJithgGHCpREG6sdicUL0kITH3YNG5QLVnQ09y LsDUmT1KDD2Fk19i8wnJTDM9AJ6UQ9VEUK6ClzqqLQo9Wm999xMQ6jyPx7ZfO7s0JTrF 2YSINccA7TxZkWSZs/ENcq1zlqF4G4U4ZrVvorXhw6wu3zsB2ugx09SD5B5fA0hdFHZe UmEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@verizon.com header.s=corp header.b=IiwAkr1f; dkim=fail header.i=@verizon.com header.s=corp header.b=INw3p6vS; dkim=fail header.i=@verizon.com header.s=corp header.b=INw3p6vS; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=verizon.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k15si1020886pgr.633.2017.10.24.19.09.47; Tue, 24 Oct 2017 19:09:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@verizon.com header.s=corp header.b=IiwAkr1f; dkim=fail header.i=@verizon.com header.s=corp header.b=INw3p6vS; dkim=fail header.i=@verizon.com header.s=corp header.b=INw3p6vS; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=verizon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751918AbdJYCJo (ORCPT + 9 others); Tue, 24 Oct 2017 22:09:44 -0400 Received: from omzsmtpe01.verizonbusiness.com ([199.249.25.210]:57664 "EHLO omzsmtpe01.verizonbusiness.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932464AbdJYB53 (ORCPT ); Tue, 24 Oct 2017 21:57:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1508896649; x=1540432649; h=from:cc:to:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=24mzLNqv07mMk4ABWvYhaWuTjV/rMihaBAGR0dkOxvQ=; b=IiwAkr1fGRgjHOKwXDHa+dfd83vPueA1+587RJVgXLKVn5g6XlrSPtcd HoH0QMRpXv/E/CyRhstZiZk+mnuqFTXwGKZ1Impe4gknZKmcm8gTiFvVP Jhn+hOgBUOe42npweglafKZfVIXhkxNs110BYggEP6m/duzjUkzUrAe4+ g=; Received: from unknown (HELO fldsmtpi03.verizon.com) ([166.68.71.145]) by omzsmtpe01.verizonbusiness.com with ESMTP; 25 Oct 2017 01:57:28 +0000 From: "Levin, Alexander (Sasha Levin)" Cc: Bjorn Andersson , Kalle Valo , "Levin, Alexander (Sasha Levin)" Received: from rogue-10-255-192-101.rogue.vzwcorp.com (HELO atlantis.verizonwireless.com) ([10.255.192.101]) by fldsmtpi03.verizon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 25 Oct 2017 01:56:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1508896613; x=1540432613; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=24mzLNqv07mMk4ABWvYhaWuTjV/rMihaBAGR0dkOxvQ=; b=INw3p6vSBlmnY7Z/E3UfMT0z6XLVvb5YmUTcpq6gGDvGSoR54FE22mJl rfBWow4cvLKihKIcenMXmOrnaDRkReTITKvxKxJ/TBAap867vmbGq82jO znfOPNnoiJge/7jZkYkUdLGeF4tM48H/Znl0QHudUF+HNVdxiGf8Sw/JA g=; Received: from pioneer.tdc.vzwcorp.com (HELO eris.verizonwireless.com) ([10.254.88.34]) by atlantis.verizonwireless.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 24 Oct 2017 21:56:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1508896613; x=1540432613; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=24mzLNqv07mMk4ABWvYhaWuTjV/rMihaBAGR0dkOxvQ=; b=INw3p6vSBlmnY7Z/E3UfMT0z6XLVvb5YmUTcpq6gGDvGSoR54FE22mJl rfBWow4cvLKihKIcenMXmOrnaDRkReTITKvxKxJ/TBAap867vmbGq82jO znfOPNnoiJge/7jZkYkUdLGeF4tM48H/Znl0QHudUF+HNVdxiGf8Sw/JA g=; X-Host: pioneer.tdc.vzwcorp.com Received: from ohtwi1exh003.uswin.ad.vzwcorp.com ([10.144.218.45]) by eris.verizonwireless.com with ESMTP/TLS/AES128-SHA256; 25 Oct 2017 01:56:52 +0000 Received: from tbwexch17apd.uswin.ad.vzwcorp.com (153.114.162.41) by OHTWI1EXH003.uswin.ad.vzwcorp.com (10.144.218.45) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 24 Oct 2017 21:56:52 -0400 Received: from OMZP1LUMXCA12.uswin.ad.vzwcorp.com (144.8.22.187) by tbwexch17apd.uswin.ad.vzwcorp.com (153.114.162.41) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Tue, 24 Oct 2017 21:56:52 -0400 Received: from OMZP1LUMXCA17.uswin.ad.vzwcorp.com (144.8.22.195) by OMZP1LUMXCA12.uswin.ad.vzwcorp.com (144.8.22.187) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Tue, 24 Oct 2017 20:56:51 -0500 Received: from OMZP1LUMXCA17.uswin.ad.vzwcorp.com ([144.8.22.195]) by OMZP1LUMXCA17.uswin.ad.vzwcorp.com ([144.8.22.195]) with mapi id 15.00.1263.000; Tue, 24 Oct 2017 20:56:51 -0500 To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: [PATCH AUTOSEL for 4.9 47/50] wcn36xx: Don't use the destroyed hal_mutex Thread-Topic: [PATCH AUTOSEL for 4.9 47/50] wcn36xx: Don't use the destroyed hal_mutex Thread-Index: AQHTTTRqqVeWnDK1+k2gLf9I5wEf7g== Date: Wed, 25 Oct 2017 01:56:03 +0000 Message-ID: <20171025015539.24525-47-alexander.levin@verizon.com> References: <20171025015539.24525-1-alexander.levin@verizon.com> In-Reply-To: <20171025015539.24525-1-alexander.levin@verizon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.144.60.250] MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Bjorn Andersson [ Upstream commit d53628882255481b710641dd0118fbd80af6e983 ] ieee80211_unregister_hw() might invoke operations to stop the interface, that uses the hal_mutex. So don't destroy it until after we're done using it. Signed-off-by: Bjorn Andersson Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/wcn36xx/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.11.0 diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index e1d59da2ad20..ca8797c65312 100644 --- a/drivers/net/wireless/ath/wcn36xx/main.c +++ b/drivers/net/wireless/ath/wcn36xx/main.c @@ -1165,11 +1165,12 @@ static int wcn36xx_remove(struct platform_device *pdev) wcn36xx_dbg(WCN36XX_DBG_MAC, "platform remove\n"); release_firmware(wcn->nv); - mutex_destroy(&wcn->hal_mutex); ieee80211_unregister_hw(hw); iounmap(wcn->dxe_base); iounmap(wcn->ccu_base); + + mutex_destroy(&wcn->hal_mutex); ieee80211_free_hw(hw); return 0;