From patchwork Sun Sep 24 18:42:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Levin, Alexander \(Sasha Levin\)" X-Patchwork-Id: 114142 Delivered-To: patch@linaro.org Received: by 10.140.106.117 with SMTP id d108csp1807324qgf; Sun, 24 Sep 2017 11:45:13 -0700 (PDT) X-Google-Smtp-Source: AOwi7QCdxPLbsLKcBZzhchrspuw1/y1Pru/WrJo8RILKlzRMYx27xoLGRvg3rAXezSrG6PtnmaNm X-Received: by 10.99.117.81 with SMTP id f17mr5273721pgn.181.1506278713790; Sun, 24 Sep 2017 11:45:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1506278713; cv=none; d=google.com; s=arc-20160816; b=u2ObsRkyusleedzLrjjQiXm5+XiaNaOR5ByJ6HQjGdz2pDXR8hZdO+qRuIx5O4kfmd btYCf4LzZlvB6KbM8LAOCJH/IaUN+IBgRvCGQ5r825JA+aqhZI6pD/VIoXOQJPwn9DT1 hPLhExMOORyZ5jG7NhMX5kDQyYNOdCKphNWlhoIDiDdjxDcb0BLvXTaZSbdHGrA+3cq8 MTHfsP1SKO2Wag591L3rvxsAlXf3a+TCLULnKRRo934Z9RfrEok+C13CFUH9dhCSDT6h 5jNOw51Eh3bSN/7m/WY74OFfDP2W48VjIF5ZLpwGrhm3jGYhmNXhjWm0+c2GPUDmv7DK 3Tdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:dkim-signature :dkim-signature:from:dkim-signature:arc-authentication-results; bh=RLheaW3NL0g4N2nIQMPXYjJ0PiIyPFK5Z0H3Pvm5Ns4=; b=Kkem8OqwXXekAeLx/g+/VxZx1qtBz03ARjqtR6rZZdHKUuc1fCoB/xOVpLTFtAH3uP UcisI1JBpO5cxVxwdr6ZZx+oLix8bzpR36QpvFeQqb6ctyKfnSb65VrG/x6VvOwf2H+I wqx/VR5wxVjnenwNt44h+cynbgoKYlx4irCc4aINj+IUbam76b3Plu7riayPjGB5QFap BPBn48ktDv0THpHstAK3C2YOzXZqJF9BmGm8L5luEuyJZ8ZJ9M7aL9a3StqobUcwEhgr /sGcdsV3GXvtrxbSVknIaLJlm4aI3G8nOCkkV4Llw1XvtsSKtRm/Pipa8845bgJRm+Lr 3OkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@verizon.com header.s=corp header.b=Ba9yK8IC; dkim=fail header.i=@verizon.com header.s=corp header.b=uOZKZVbO; dkim=fail header.i=@verizon.com header.s=corp header.b=uOZKZVbO; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=verizon.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h4si3003187pgs.34.2017.09.24.11.45.13; Sun, 24 Sep 2017 11:45:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@verizon.com header.s=corp header.b=Ba9yK8IC; dkim=fail header.i=@verizon.com header.s=corp header.b=uOZKZVbO; dkim=fail header.i=@verizon.com header.s=corp header.b=uOZKZVbO; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=verizon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753038AbdIXSpL (ORCPT + 8 others); Sun, 24 Sep 2017 14:45:11 -0400 Received: from omzsmtpe02.verizonbusiness.com ([199.249.25.209]:26008 "EHLO omzsmtpe02.verizonbusiness.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753016AbdIXSpH (ORCPT ); Sun, 24 Sep 2017 14:45:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1506278707; x=1537814707; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=1yontPG1P74X54WmVcMbw2nWm8YKYQddXpV6SIhxGWw=; b=Ba9yK8ICz1zWVkO1Ihg6tspfxAi5HEDZskD31Cz8HH/gHJI7jJ2RhG4H tslpH8lb6Ive1QTKP+TgzZPc7LDNV1UllfZ+lUogXW6JLTtIMJNPveuax rAXm4BHP9ArXpoo1QuF1abaxyUNEy38XatDOHGRgxrtW7k38+QjcXQZK5 g=; Received: from unknown (HELO fldsmtpi02.verizon.com) ([166.68.71.144]) by omzsmtpe02.verizonbusiness.com with ESMTP; 24 Sep 2017 18:45:05 +0000 From: "Levin, Alexander (Sasha Levin)" Received: from rogue-10-255-192-101.rogue.vzwcorp.com (HELO atlantis.verizonwireless.com) ([10.255.192.101]) by fldsmtpi02.verizon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 24 Sep 2017 18:44:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1506278699; x=1537814699; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=1yontPG1P74X54WmVcMbw2nWm8YKYQddXpV6SIhxGWw=; b=uOZKZVbOZDhOmt6j7mtqhAU+OTyqnjG1iwbsm1e+u/DWqV7t5MYFC/6p YAcTxKRr4E0VzFkF1C5eRgys9YwgKG+VNtx+creauCwBIl3UutxlH1Sp4 wuYV0vZqQewbYDaki6I6jQ+SDUrr8gjKYsvjwJKnfArxrtehG0g+Uhm39 4=; Received: from discovery.odc.vzwcorp.com (HELO mercury.verizonwireless.com) ([10.255.240.25]) by atlantis.verizonwireless.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 24 Sep 2017 14:44:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=verizon.com; i=@verizon.com; q=dns/txt; s=corp; t=1506278699; x=1537814699; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=1yontPG1P74X54WmVcMbw2nWm8YKYQddXpV6SIhxGWw=; b=uOZKZVbOZDhOmt6j7mtqhAU+OTyqnjG1iwbsm1e+u/DWqV7t5MYFC/6p YAcTxKRr4E0VzFkF1C5eRgys9YwgKG+VNtx+creauCwBIl3UutxlH1Sp4 wuYV0vZqQewbYDaki6I6jQ+SDUrr8gjKYsvjwJKnfArxrtehG0g+Uhm39 4=; X-Host: discovery.odc.vzwcorp.com Received: from casac1exh002.uswin.ad.vzwcorp.com ([10.11.218.44]) by mercury.verizonwireless.com with ESMTP/TLS/AES128-SHA256; 24 Sep 2017 18:44:58 +0000 Received: from scwexch02apd.uswin.ad.vzwcorp.com (153.114.130.21) by CASAC1EXH002.uswin.ad.vzwcorp.com (10.11.218.44) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 24 Sep 2017 11:44:58 -0700 Received: from OMZP1LUMXCA12.uswin.ad.vzwcorp.com (144.8.22.187) by scwexch02apd.uswin.ad.vzwcorp.com (153.114.130.21) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Sun, 24 Sep 2017 11:44:57 -0700 Received: from OMZP1LUMXCA17.uswin.ad.vzwcorp.com (144.8.22.195) by OMZP1LUMXCA12.uswin.ad.vzwcorp.com (144.8.22.187) with Microsoft SMTP Server (TLS) id 15.0.1263.5; Sun, 24 Sep 2017 13:44:56 -0500 Received: from OMZP1LUMXCA17.uswin.ad.vzwcorp.com ([144.8.22.195]) by OMZP1LUMXCA17.uswin.ad.vzwcorp.com ([144.8.22.195]) with mapi id 15.00.1263.000; Sun, 24 Sep 2017 13:44:56 -0500 To: "gregkh@linuxfoundation.org" CC: "stable@vger.kernel.org" Subject: [GIT PULL for-4.4 29/46] MIPS: Lantiq: Fix another request_mem_region() return code check Thread-Topic: [GIT PULL for-4.4 29/46] MIPS: Lantiq: Fix another request_mem_region() return code check Thread-Index: AQHTNWTe1gIEcw9ZhEOO2PF308Uh4Q== Date: Sun, 24 Sep 2017 18:42:26 +0000 Message-ID: <20170924184213.29599-30-alexander.levin@verizon.com> References: <20170924184213.29599-1-alexander.levin@verizon.com> In-Reply-To: <20170924184213.29599-1-alexander.levin@verizon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.144.60.250] MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit 98ea51cb0c8ce009d9da1fd7b48f0ff1d7a9bbb0 ] Hauke already fixed a couple of them, but one instance remains that checks for a negative integer when it should check for a NULL pointer: arch/mips/lantiq/xway/sysctrl.c: In function 'ltq_soc_init': arch/mips/lantiq/xway/sysctrl.c:473:19: error: ordered comparison of pointer with integer zero [-Werror=extra] Fixes: 6e807852676a ("MIPS: Lantiq: Fix check for return value of request_mem_region()") Signed-off-by: Arnd Bergmann Cc: John Crispin Cc: linux-mips@linux-mips.org Cc: linux-kernel@vger.kernel.org Patchwork: https://patchwork.linux-mips.org/patch/15043/ Signed-off-by: Ralf Baechle Signed-off-by: Sasha Levin --- arch/mips/lantiq/xway/sysctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.11.0 diff --git a/arch/mips/lantiq/xway/sysctrl.c b/arch/mips/lantiq/xway/sysctrl.c index daf580ce5ca2..2528181232fd 100644 --- a/arch/mips/lantiq/xway/sysctrl.c +++ b/arch/mips/lantiq/xway/sysctrl.c @@ -469,8 +469,8 @@ void __init ltq_soc_init(void) panic("Failed to load xbar nodes from devicetree"); if (of_address_to_resource(np_xbar, 0, &res_xbar)) panic("Failed to get xbar resources"); - if (request_mem_region(res_xbar.start, resource_size(&res_xbar), - res_xbar.name) < 0) + if (!request_mem_region(res_xbar.start, resource_size(&res_xbar), + res_xbar.name)) panic("Failed to get xbar resources"); ltq_xbar_membase = ioremap_nocache(res_xbar.start,