From patchwork Fri May 5 19:46:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 98667 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp292695qge; Fri, 5 May 2017 12:48:21 -0700 (PDT) X-Received: by 10.99.1.198 with SMTP id 189mr5347598pgb.229.1494013701036; Fri, 05 May 2017 12:48:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1494013701; cv=none; d=google.com; s=arc-20160816; b=MQ1OxsjSnVS0yRGs8QDN8KOfrqqQNqRtt8EgZL205luOxqeECLANE0Z0xQRjbuESEw kwXH9pq9jBNmEg7tfoxngTDwwSVhMgHva1O/jzYHRLWJtzXnLnoK4PZofaYQQfuta9Ij JD60KxsNT7KxNiD+87cQUMJ/EoGGvk0GvDKJszrKdvVKqIJjtZcSCGfg/hban5YzG8U0 JGSVCKhbeoIwF1Wgm6Y5AE3YX2Abt1EwnmB2x5WmedVSFW+x0bQdYlF5z2ViirDZ9Swi /QHLyjspwWrivZlpyj39W3wYhXsNFQrQAbvfC7typ4EgSCtnKKajOnE36EfrctifFwi5 +4pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=lvJFJfkFJw1XtqcV0w1Z/YbFiNAT76ydpT/T1xW3vJQ=; b=HlxfLay+wKMcm8wJsAhJssUd0qO7sw9QFcxeV7UlO3+A+Vgtpkl7TP93Xt0qWp82ub phMsSYTDUTJKI/6TbPEePJwPE5dFJ38NvCkhr5KIJrJmoOAkGibvWnq4smUlWYF0L0/k nvP8gxMhSoQ4NTIC9c1yWlOF6AykIPzS6KPptnA+wWnJQ7ACiHMnEhkWlDNJ0g+R/d5R kx0oDc5wIzWMrUwHGmQRrJ6D7SuYAAk801jQskeCpeGT6mq71ZYg7gWJzTQLGFjEOi5e AUrP4ti7qk4AZrYxYckzkvNgwOLGexjcmiGxw9dkTkhq62X4F6fe4HaEQY0VHyLQaMPj DLyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 144si6012850pfa.118.2017.05.05.12.48.20; Fri, 05 May 2017 12:48:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755501AbdEETsT (ORCPT + 6 others); Fri, 5 May 2017 15:48:19 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:56758 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755323AbdEETsQ (ORCPT ); Fri, 5 May 2017 15:48:16 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue002 [212.227.15.129]) with ESMTPA (Nemesis) id 0M4Nqe-1dyP9W0CZo-00ydrV; Fri, 05 May 2017 21:48:14 +0200 From: Arnd Bergmann To: Ben Hutchings Cc: stable@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman Subject: [PATCH 3.16-stable 30/87] tty/isicom: fix big-endian compile warning Date: Fri, 5 May 2017 21:46:48 +0200 Message-Id: <20170505194745.3627137-31-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170505194745.3627137-1-arnd@arndb.de> References: <20170505194745.3627137-1-arnd@arndb.de> X-Provags-ID: V03:K0:zTd0Wv11wMH7M2GxRuPRvVhI7zcNK1UBQncrwhAqTKr0Rz7Xr5q x5i1QD/o1mAboKAK4kc9gN1CYg9KfYqa0dz0KBwXBMVv/bPMonnKnBdTo/UhIoMOpRm7qSV ZErlPm6dJpnW1/sY1NZHShJ+/VfJan8kxFjMTvvkNLdftM2wDKqZd84DcWsdn1sL08fJEoY 9rqx08UqReQMySb4tbqfA== X-UI-Out-Filterresults: notjunk:1; V01:K0:QuOzAM8f6Kk=:IcWvjcOvgOrhANDw9zUBsP czlrDNid7LHu6WMJRHo6rCFrpWG2eBGeCxxYIO2BkeUrWGsHvSvYor4BzzKD0yYfLFUJOD9cf B7X4K9O1805EjQHsUzMGUp+ijzD65f8Tq17JtYQZJPq01cWuJ79e6pWzGtexP8Vmqd0UkwKwg NUtP86/WZ/9aer2N9+W75TnM/2VGIRQvCNI7VWYEAiFIinfovmFrxsSGGcyr04CdYmOAfh0gP 7fMJF9vpJTDgLMH/WlpHvPwSV6Zct/fmCZ35QuiYzyAzyJxZETO/hYqArTRRVTx8MFR+I4BJn 83sVYBi8zvMjedED33j23RqlBShVpE8JPUQvSIOKjd7bZORM5hGhyQk0Y/hEjIZClCVuN2nB4 rKwMVKo1eV5Au6g9LyL7BVtfqPbnvbP3k+O7PR7taB+iAhwSAhrd+DIe9bn5+xz49ZM0SCKfW Fone3XkETv8Jav/7j+DWg/W3QqhCMM5c6ivLRQ++35EqXznfjNVqbvzTGAYsuutbQi2wDWcNl iXliw4Loj3mbjs3YutP6n65JlYHhr4VIizMUHRgYRizcXir1wpmnKP/jBjT76ySGdsn0ggqqZ IdLwuzzEmwz2kTiPIL3DpC3w1oAJBhNxtFWIwvx+PS6sGBnDsm9B/kuzRZ5rdCL4ewi9SlyWq XmLh0xxp/MQW1VQbx7uCdMArWCfWjB8gYXuciNzCs9bJIdnV/qtGmWeEG/rRX/kGHnns= Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Commit f3e2d56dce47dbd0bb3f69f84741b439542fef37 upstream. Building an arm allmodconfig kernel triggers a lengthy but harmless warning in the isicom driver: drvers/tty/isicom.c: In function 'isicom_send_break': uapi/linux/swab.h:13:15: warning: integer overflow in expression [-Woverflow] (((__u16)(x) & (__u16)0x00ffU) << 8) | \ ^ uapi/linux/swab.h:107:2: note: in expansion of macro '___constant_swab16' ___constant_swab16(x) : \ ^ uapi/linux/byteorder/big_endian.h:34:43: note: in expansion of macro '__swab16' #define __cpu_to_le16(x) ((__force __le16)__swab16((x))) ^ linux/byteorder/generic.h:89:21: note: in expansion of macro '__cpu_to_le16' #define cpu_to_le16 __cpu_to_le16 ^ include/asm/io.h:270:6: note: in expansion of macro 'cpu_to_le16' cpu_to_le16(v),__io(p)); }) ^ drivers/tty/isicom.c:1058:2: note: in expansion of macro 'outw' outw((length & 0xff00), base); ^ Apparently, the problem is related to the fact that the value 0xff00, when used as a 16-bit number, is negative and passed into bitwise operands of the generic byte swapping code. Marking the input argument as unsigned in both technically correct and avoids the warning. Signed-off-by: Arnd Bergmann Signed-off-by: Greg Kroah-Hartman Signed-off-by: Arnd Bergmann --- drivers/tty/isicom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 diff --git a/drivers/tty/isicom.c b/drivers/tty/isicom.c index 858291ca889c..c03ecaa0af7f 100644 --- a/drivers/tty/isicom.c +++ b/drivers/tty/isicom.c @@ -1055,7 +1055,7 @@ static int isicom_send_break(struct tty_struct *tty, int length) outw(0x8000 | ((port->channel) << (card->shift_count)) | 0x3, base); outw((length & 0xff) << 8 | 0x00, base); - outw((length & 0xff00), base); + outw((length & 0xff00u), base); InterruptTheCard(base); unlock_card(card);