From patchwork Tue Jul 25 20:07:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Pundir X-Patchwork-Id: 108687 Delivered-To: patch@linaro.org Received: by 10.182.45.195 with SMTP id p3csp14287obm; Tue, 25 Jul 2017 13:07:51 -0700 (PDT) X-Received: by 10.98.29.72 with SMTP id d69mr14201332pfd.226.1501013270985; Tue, 25 Jul 2017 13:07:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501013270; cv=none; d=google.com; s=arc-20160816; b=nK0ECzAOZccdR5Lc1Z1WiMAVADvcuh0GKnml4PN7IDAQ1u+kYv90WlnxL1NR0QDWtY gv3aK9kRxcOHeAvzeNbRW6cwkxMVlVGmDxStI4ctpqoHrJPx0KQbinfl/SMKrMHZRqKg jGpQdaRT6GnZRSmNVpXhdKzNslk207lbpWDxciCXTlhO2xjxwgCfo5sz3scxVWkGDk8b 28kCNkTPlMUy8kv1JgpYGGLzDR0zd143B1nHchUXNz664j3ha+wUUUQr9wlKJrla2Yhb Tdw+39LYg38vZEWvwlkShp47QhQPdmJF3auaQUiCyD8W3SKXJG5GzMo25ivncOF1HNj5 lZdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=+IT8FuLYyNifhF7YAD4hYXJgW8YkQ4S8/FTml/GrQyI=; b=XLRXnXjNNW+XtV6hvLQDUBgi6sHnq3t5qq8uiky3pWabcZPipufWtrefxthcku9WLp lHicg7H0V1mdZMZI/mqf7xBUjH6k9w0RRD6kriBDDSlvV9eV5894LQfty48F2vtBdqJa ugZAuxTRGqWuwOmupZdwY5vcJnd/HG+fBcHpuHtfqNZBeggRh6Qn1agCcuQqnVaLMdPg mfWWcHTpFxN4oq3H1DScJh6UMoKWIsJJI1CLqzE6vPxWTU5bYiaemMOx+zLlX4e3OHHq rOtyF+xg9VGh7xSOypx+TSTxpj2K3owHvmBNbbLwR8QUmG7LjOUdwQRYg/xUGQDZ6D2F oQOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.b=OFW97K+1; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h10si8970990plk.237.2017.07.25.13.07.50; Tue, 25 Jul 2017 13:07:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.b=OFW97K+1; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753464AbdGYUHt (ORCPT + 6 others); Tue, 25 Jul 2017 16:07:49 -0400 Received: from mail-pg0-f47.google.com ([74.125.83.47]:33225 "EHLO mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752116AbdGYUHs (ORCPT ); Tue, 25 Jul 2017 16:07:48 -0400 Received: by mail-pg0-f47.google.com with SMTP id g14so25599254pgu.0 for ; Tue, 25 Jul 2017 13:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+IT8FuLYyNifhF7YAD4hYXJgW8YkQ4S8/FTml/GrQyI=; b=OFW97K+1wLBVc+0kQeiy96xDcW8G7586NHigWzAozDcyojRFagdcu6UEx8q5ggG/n6 xkaN5W13bAAieV0Dnoc+o2GKYa2faIZ5L49KgytZ0HoR+udrTY0mx5bBsQXDAbexQyHm X79OCY50s6395WhDdh6BT6C6BLw//7RNGGw1w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+IT8FuLYyNifhF7YAD4hYXJgW8YkQ4S8/FTml/GrQyI=; b=eQhBW2Z8jA9ykQUBK7VgaaPapIIbCdgu+E6q4VRlG7+Ivl2im5oMJiB5KbPrcCCx04 /t9qAjYpRqJsla3E0rbK0JQKh0X/q7dnUHJKb6PdcYgD3JFwODYT2kCj3rlrLcCxQAFq jCskm2gkLN6TlQ/8tDegvEJ+r1gqPBPggw3RM87alRExOtNjNTTvkUvn9RQtvMSWWkbK h0WOoDZtJIrCgaUKFzdHjFFVL3YHUZaV/HEBHO/YdJWbt4ccMhSXbaiu82zUVno692XO x2K+6kDhNxvpV9p0Zac6fTW9KLIoz9+WnzdP1FphZ1JJGOswwfKYGeoq+IwsJrHAN+fj 8oyg== X-Gm-Message-State: AIVw110Eo4VXFv9E6ngjLSM/TGCWgXbhnk/h8kgjXF4FXNheX9rAzhif DNF7MprdOtqTLeUXfJn6NQ== X-Received: by 10.99.107.135 with SMTP id g129mr20114287pgc.179.1501013267642; Tue, 25 Jul 2017 13:07:47 -0700 (PDT) Received: from localhost.localdomain ([106.51.135.235]) by smtp.gmail.com with ESMTPSA id c76sm27684356pfj.91.2017.07.25.13.07.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 25 Jul 2017 13:07:46 -0700 (PDT) From: Amit Pundir To: Greg KH Cc: Stable , Jia-Ju Bai , "David S . Miller" Subject: [PATCH for-4.4 07/13] isdn: Fix a sleep-in-atomic bug Date: Wed, 26 Jul 2017 01:37:15 +0530 Message-Id: <1501013241-31961-8-git-send-email-amit.pundir@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1501013241-31961-1-git-send-email-amit.pundir@linaro.org> References: <1501013241-31961-1-git-send-email-amit.pundir@linaro.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jia-Ju Bai commit e8f4ae85439f34bec3b0ab69223a41809dab28c9 upstream. The driver may sleep under a spin lock, the function call path is: isdn_ppp_mp_receive (acquire the lock) isdn_ppp_mp_reassembly isdn_ppp_push_higher isdn_ppp_decompress isdn_ppp_ccp_reset_trans isdn_ppp_ccp_reset_alloc_state kzalloc(GFP_KERNEL) --> may sleep To fixed it, the "GFP_KERNEL" is replaced with "GFP_ATOMIC". Signed-off-by: Jia-Ju Bai Signed-off-by: David S. Miller Signed-off-by: Amit Pundir --- drivers/isdn/i4l/isdn_ppp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/drivers/isdn/i4l/isdn_ppp.c b/drivers/isdn/i4l/isdn_ppp.c index 9c1e8adaf4fc..bf3fbd00a091 100644 --- a/drivers/isdn/i4l/isdn_ppp.c +++ b/drivers/isdn/i4l/isdn_ppp.c @@ -2364,7 +2364,7 @@ static struct ippp_ccp_reset_state *isdn_ppp_ccp_reset_alloc_state(struct ippp_s id); return NULL; } else { - rs = kzalloc(sizeof(struct ippp_ccp_reset_state), GFP_KERNEL); + rs = kzalloc(sizeof(struct ippp_ccp_reset_state), GFP_ATOMIC); if (!rs) return NULL; rs->state = CCPResetIdle;