From patchwork Tue Jul 25 20:07:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Pundir X-Patchwork-Id: 108685 Delivered-To: patch@linaro.org Received: by 10.182.45.195 with SMTP id p3csp14102obm; Tue, 25 Jul 2017 13:07:39 -0700 (PDT) X-Received: by 10.99.0.207 with SMTP id 198mr16123359pga.452.1501013259453; Tue, 25 Jul 2017 13:07:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1501013259; cv=none; d=google.com; s=arc-20160816; b=Gd1P04sZG5osKTIUfNoHAD2erent1y1kpKZJsH9kuHzdrX63a7BMXe3Se2xRxo3yDs w4WuzTlEaiTMhdBSA+vkVk7y4yL4xtO0W0PN8XYr8L/w4ftRy12yoBLCfjak2dC0Puaz tqbyhCGWWEcgEhtGhLOhoOGZdghDYGqh9xSwpoNHCmgHiBl0W4GuDN/nzI+W+5HsK6Uf mkvx2QlXrajTS0bWcIq2o9Npi5L7qdCckptu3gGBuM6AIxZIgJu32WgL9WSndIy+KLmk ZaQeJpYtEkKANzHsnaIRpJi51B+g3Vu3VYzB/9OVS+S7zEPAxKfujhZU6Z85CUzh4Njp B87w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=b5tO56SzytrPmfByZSvQFcD1yEIxUVma23Nz0sB9CgI=; b=L9AaIYclKe5m2zoV5cTE0L1/hEgRXwm20fGDVAFTh8GnX1wJWCdF3u2tUe0xL0WSow 7rOB5pjDdpjaLUPR4/jU2YtnxYGMAPDsOf577hHurfShiNYQX53BskiAqWKvJJQK74GZ hSSek61PfPcFJWz33BH2R4nnjjL2owPFWLxCorHtBIAu9dYpzwOKEP9jTMudhtleRZ/2 AF7Ar/s2JGUXU9hvx1Y65asMuCIBLtDmjNo49u2TVlbvjTNgwKGItp6Dma89J/PbDYzv e2yExyUjPbVJrQKUBffmFbnvlbEncHJYcUuYFqF9vOQT9nIZlGNWSggZOGAuqwC7A90z 0eKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.b=ahq7k6ya; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h10si8970990plk.237.2017.07.25.13.07.39; Tue, 25 Jul 2017 13:07:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.b=ahq7k6ya; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751579AbdGYUHi (ORCPT + 6 others); Tue, 25 Jul 2017 16:07:38 -0400 Received: from mail-pg0-f42.google.com ([74.125.83.42]:35793 "EHLO mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751641AbdGYUHg (ORCPT ); Tue, 25 Jul 2017 16:07:36 -0400 Received: by mail-pg0-f42.google.com with SMTP id v190so74470361pgv.2 for ; Tue, 25 Jul 2017 13:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=b5tO56SzytrPmfByZSvQFcD1yEIxUVma23Nz0sB9CgI=; b=ahq7k6yaQFVVun+TP8s7/gFD0H1CHYJTdhsLdkDfdBw1ROK7lzHQpofViNihgrCDIk o7EtvwqAJ+RIgLqPD7ASZ73aA2SXRPbIDuc9mu8d20W+24gmrbIH8fbiId3jDRn8diWt H4vErflZbdejYWPcstuG998ze/qWOvsJz6zcw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=b5tO56SzytrPmfByZSvQFcD1yEIxUVma23Nz0sB9CgI=; b=UnHaIl42JGKjOn7+nQNXrcFIoFiuYllftqaHkfLvsUFGQ3lKzusRnDJqgTq5BF0pU9 9R8MX7uXi5A/dboP8cHP/Mawl02d0xWl9V+dINx5sZAJyrCD3X4ItJx/tKQ3tmOF+wos kZbshC33YrmqfqXfZOojQCADqNbYx7NiXQeGW21P8E8+QawaMNdaUgJxfPqPChsAt1MM niq5vm7FbP4Eq3kQ2anFB+XYTWk3uY4koZtk/xHxPAbAe92OhvS3xvI5miirK1qIuNOp 1gaezsNijVKNjQOImsDLnMTGXtSJ5IhZRFI+3kcy949ERpQ6LYuknKK4bEEKIS35Zjpg D/0A== X-Gm-Message-State: AIVw1102UNB6AvLuiADrmT3KhVq8Nkk1rqpoGxGXu7NdN/BHtW7ORaFp zvkTHRu3ZQlQOtI4 X-Received: by 10.84.139.40 with SMTP id 37mr18266155plq.153.1501013256015; Tue, 25 Jul 2017 13:07:36 -0700 (PDT) Received: from localhost.localdomain ([106.51.135.235]) by smtp.gmail.com with ESMTPSA id c76sm27684356pfj.91.2017.07.25.13.07.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 25 Jul 2017 13:07:34 -0700 (PDT) From: Amit Pundir To: Greg KH Cc: Stable , Oliver Neukum , "David S . Miller" Subject: [PATCH for-4.4 03/13] kaweth: fix firmware download Date: Wed, 26 Jul 2017 01:37:11 +0530 Message-Id: <1501013241-31961-4-git-send-email-amit.pundir@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1501013241-31961-1-git-send-email-amit.pundir@linaro.org> References: <1501013241-31961-1-git-send-email-amit.pundir@linaro.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Oliver Neukum commit 60bcabd080f53561efa9288be45c128feda1a8bb upstream. This fixes the oops discovered by the Umap2 project and Alan Stern. The intf member needs to be set before the firmware is downloaded. Signed-off-by: Oliver Neukum Signed-off-by: David S. Miller Signed-off-by: Amit Pundir --- drivers/net/usb/kaweth.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c index f64b25c221e8..9f900eee27be 100644 --- a/drivers/net/usb/kaweth.c +++ b/drivers/net/usb/kaweth.c @@ -1029,6 +1029,7 @@ static int kaweth_probe( kaweth = netdev_priv(netdev); kaweth->dev = udev; kaweth->net = netdev; + kaweth->intf = intf; spin_lock_init(&kaweth->device_lock); init_waitqueue_head(&kaweth->term_wait); @@ -1139,8 +1140,6 @@ err_fw: dev_dbg(dev, "Initializing net device.\n"); - kaweth->intf = intf; - kaweth->tx_urb = usb_alloc_urb(0, GFP_KERNEL); if (!kaweth->tx_urb) goto err_free_netdev;