From patchwork Fri Jun 30 05:46:37 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Pundir X-Patchwork-Id: 106671 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp1904866qge; Thu, 29 Jun 2017 22:47:35 -0700 (PDT) X-Received: by 10.84.224.199 with SMTP id k7mr21747984pln.207.1498801655572; Thu, 29 Jun 2017 22:47:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1498801655; cv=none; d=google.com; s=arc-20160816; b=Pl299C7hdGvlu1pgR1XBQIwd+oAPNV9o8D4ztab4tYP4kfhz9QLv3rnKhrsKyFVvQy UeIryEieDNbcUIdX5ejA2+dExXf1KyGNoxflTHC2/YP/NIcyuCfKGicvSFhkrKEIRTBO DSICvG9WDLPr5loYu/J0bVjK3eeeTzDEwCCg8guknenTAbaoug00BOGN6/0Og1+3/aMN RdzUXvplTgKTdGV7S3/c2+WmWHr1O4UjQfbKk1cR16fMVHxn/pv5It6Hiuk2TfNRLArk w41Rz1jFWiZJlGV9burSbu4wYg26jg8vgYrnaYV1YnO+JnWjSzLvXSRW+++wx6qUuCxi RlnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=qML/s3vfAjQVuPGfZvNeTdTTrX2C2ywk5qf2Kci2uJU=; b=l9Gv5T+FDgutqUDZdhakjruhAH2EMIfoyhTsWmZaD4ZxvPyOwNeUXvJRZIAR3u9uEE JhdxVS4Rc/udUcXoZOSrmskpchoUPTqu5LCnyBxwbI5m9UHnqNAw+bd8v/jMuT7ZxLo1 Z9Lzbr52RgE5ZQmzBcI4pI1jNxZIfcfAZIhxS/RBCM820ROoDnPY2XLTRTn3O/Ij//G2 TfYwfIDZxX3Jna3+TWRuGDJiS18F/LSvM7ii5R4zCv0kKT684n4SCLxo00TOOmrukvbT Gim471y2Yk4cDGoCamTJgtFizBBb1B5/lvRg5ielR+U1pJfb4ms/sCihunqnSRWLvmsJ DFcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.b=ENSIwzdw; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m5si4519277pgj.463.2017.06.29.22.47.35; Thu, 29 Jun 2017 22:47:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.b=ENSIwzdw; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752085AbdF3Frd (ORCPT + 6 others); Fri, 30 Jun 2017 01:47:33 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:35202 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752071AbdF3Frb (ORCPT ); Fri, 30 Jun 2017 01:47:31 -0400 Received: by mail-pf0-f176.google.com with SMTP id c73so61642443pfk.2 for ; Thu, 29 Jun 2017 22:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=qML/s3vfAjQVuPGfZvNeTdTTrX2C2ywk5qf2Kci2uJU=; b=ENSIwzdwerBst7RQjkPVKsNji1HOL8BTvzYuaRVbOTi40J+WU29lgbiQImTNRhc6W2 +6ohs12u38YpCv6l9F1riAFcEZZUYvcRO2ZG77xOzAYMN/h+vXUJ4ttpGtlzSS9K1VrW KO4M5YHu7TYwZeP6BxSTfF6SPV1FtCADZcjHI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=qML/s3vfAjQVuPGfZvNeTdTTrX2C2ywk5qf2Kci2uJU=; b=JP4sjbb3L8VyTMK1wwU4mzILVeMr6qyRUFCCQUIwVZe5llyIXjrodIQWbPy5G2JuRf 9i5IttOkIGbOxgi5pY+fGD9g59hgVB841MM/SFmZZMOCr8+ZeVk3Jm3wqYcV1BpXUSWJ MIpzEZAi++1mGWbTNFZtaA/Lp4FFslf792P+ubvRqVMm0lOMWRcyVxdoCd/cbzxSVQIH y4Z44ea3/MZNHQlIRKQPT7hjx+sMCWgGKA8HnB2xhp/+ekXEukuqDTqik7M/CoQmgQmc y/Gk1V3wnKDNpNn28joULMgzPOc/vI3nUTv0HPicZ3CMzKCLBpnFFTKCs6dhMTWMiZac ZT/Q== X-Gm-Message-State: AKS2vOz19M0YvFJjk8RPiB3393lR0cxorj1fnEltXkLnNvCrqIIdTNcW D2VGNp6R5CzBqSo7 X-Received: by 10.98.245.22 with SMTP id n22mr20192641pfh.96.1498801646155; Thu, 29 Jun 2017 22:47:26 -0700 (PDT) Received: from localhost.localdomain ([106.51.129.233]) by smtp.gmail.com with ESMTPSA id a187sm11405550pgc.37.2017.06.29.22.47.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 29 Jun 2017 22:47:24 -0700 (PDT) From: Amit Pundir To: Greg KH Cc: Stable , "David S. Miller" Subject: [PATCH for-4.4 13/16] bgmac: Fix reversed test of build_skb() return value. Date: Fri, 30 Jun 2017 11:16:37 +0530 Message-Id: <1498801600-20896-14-git-send-email-amit.pundir@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1498801600-20896-1-git-send-email-amit.pundir@linaro.org> References: <1498801600-20896-1-git-send-email-amit.pundir@linaro.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: "David S. Miller" commit 750afbf8ee9c6a1c74a1fe5fc9852146b1d72687 upstream. Fixes: f1640c3ddeec ("bgmac: fix a missing check for build_skb") Signed-off-by: David S. Miller Signed-off-by: Amit Pundir --- drivers/net/ethernet/broadcom/bgmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c index b7e10e1b9131..20356755b708 100644 --- a/drivers/net/ethernet/broadcom/bgmac.c +++ b/drivers/net/ethernet/broadcom/bgmac.c @@ -469,7 +469,7 @@ static int bgmac_dma_rx_read(struct bgmac *bgmac, struct bgmac_dma_ring *ring, len -= ETH_FCS_LEN; skb = build_skb(buf, BGMAC_RX_ALLOC_SIZE); - if (unlikely(skb)) { + if (unlikely(!skb)) { bgmac_err(bgmac, "build_skb failed\n"); put_page(virt_to_head_page(buf)); break;