From patchwork Wed Apr 12 17:43:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumit Semwal X-Patchwork-Id: 97333 Delivered-To: patch@linaro.org Received: by 10.140.109.52 with SMTP id k49csp374426qgf; Wed, 12 Apr 2017 10:44:43 -0700 (PDT) X-Received: by 10.98.92.1 with SMTP id q1mr68618070pfb.209.1492019083056; Wed, 12 Apr 2017 10:44:43 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l17si21057414pgj.292.2017.04.12.10.44.42; Wed, 12 Apr 2017 10:44:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755308AbdDLRoh (ORCPT + 6 others); Wed, 12 Apr 2017 13:44:37 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:36261 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754869AbdDLRoe (ORCPT ); Wed, 12 Apr 2017 13:44:34 -0400 Received: by mail-pf0-f181.google.com with SMTP id o126so16982354pfb.3 for ; Wed, 12 Apr 2017 10:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pJPpAxTCXAFWsJOMqb2N3RYGj35hZ9PAsgs24tOjD04=; b=Z4BrXYrl/bMffWeJBXj3e/VH88UTJcfiNyzkt7Q2geBekfdssxnt+a3vsDRDy2qTRX dqQuPVijsjsupeBZIbotLzNyFZtJksUGCAhkaXAdGCdSJ+1Y6omhevjEBHbC2d3tE+/1 myUV8q7HXJXklmNEzrvu3q2qozMi10otB5BXo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pJPpAxTCXAFWsJOMqb2N3RYGj35hZ9PAsgs24tOjD04=; b=DBFb+UAhxE8zcHY7r+gVBYIP42iv7ffRu+Jzed4JVQw4D9WkMxWrEF1BWeHZwzgn6A Do0lrk/j0H8NyzEOz4nWzMd57nSroa6rZvbaSlK8no5chMSqk9hmHTAHkv4i5dBrvWpk LAeNc1sHTyrltdpVl7dSMtJIpCEiQIh0FRD4YDtByWllnify2+2K6xl02DgMc+AooqHU H4DbyjbdwgfVI93AXGrNFX5AtLHWTtdP3+5BI/RYEzUX7sIe5i2/s6hAc7tJBgtX2wNw aDuUSxFbs+8VJpaINU4AvWNuRtElgWDPAo66d3v6YL4fV8dg84bWkMKSyLAutjc0oQAf Ju5w== X-Gm-Message-State: AN3rC/4gsloGJr6NLgUACqJlqbzh7DMgr6jY47ZBdfr+/US6tX6lpMJqDLHuG4tB455MUjVr X-Received: by 10.84.131.97 with SMTP id 88mr11144591pld.40.1492019073410; Wed, 12 Apr 2017 10:44:33 -0700 (PDT) Received: from phantom.lan ([106.51.225.38]) by smtp.gmail.com with ESMTPSA id r17sm37750019pfa.13.2017.04.12.10.44.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 12 Apr 2017 10:44:32 -0700 (PDT) From: Sumit Semwal To: stable@vger.kernel.org Cc: Vitaly Kuznetsov , "K . Y . Srinivasan" , Greg Kroah-Hartman , Sumit Semwal Subject: [v2 PATCH for-4.4 11/16] Tools: hv: kvp: ensure kvp device fd is closed on exec Date: Wed, 12 Apr 2017 23:13:45 +0530 Message-Id: <1492019030-13567-12-git-send-email-sumit.semwal@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1492019030-13567-1-git-send-email-sumit.semwal@linaro.org> References: <1492019030-13567-1-git-send-email-sumit.semwal@linaro.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Vitaly Kuznetsov [ Upstream commit 26840437cbd6d3625ea6ab34e17cd34bb810c861 ] KVP daemon does fork()/exec() (with popen()) so we need to close our fds to avoid sharing them with child processes. The immediate implication of not doing so I see is SELinux complaining about 'ip' trying to access '/dev/vmbus/hv_kvp'. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sumit Semwal --- tools/hv/hv_kvp_daemon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c index 0d9f48e..bc7adb8 100644 --- a/tools/hv/hv_kvp_daemon.c +++ b/tools/hv/hv_kvp_daemon.c @@ -1433,7 +1433,7 @@ int main(int argc, char *argv[]) openlog("KVP", 0, LOG_USER); syslog(LOG_INFO, "KVP starting; pid is:%d", getpid()); - kvp_fd = open("/dev/vmbus/hv_kvp", O_RDWR); + kvp_fd = open("/dev/vmbus/hv_kvp", O_RDWR | O_CLOEXEC); if (kvp_fd < 0) { syslog(LOG_ERR, "open /dev/vmbus/hv_kvp failed; error: %d %s",