From patchwork Wed Apr 12 17:43:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumit Semwal X-Patchwork-Id: 97330 Delivered-To: patch@linaro.org Received: by 10.140.109.52 with SMTP id k49csp374418qgf; Wed, 12 Apr 2017 10:44:42 -0700 (PDT) X-Received: by 10.99.7.3 with SMTP id 3mr70669085pgh.95.1492019082246; Wed, 12 Apr 2017 10:44:42 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l17si21057414pgj.292.2017.04.12.10.44.42; Wed, 12 Apr 2017 10:44:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755256AbdDLRoa (ORCPT + 6 others); Wed, 12 Apr 2017 13:44:30 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:32936 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755308AbdDLRo2 (ORCPT ); Wed, 12 Apr 2017 13:44:28 -0400 Received: by mail-pf0-f170.google.com with SMTP id s16so17038186pfs.0 for ; Wed, 12 Apr 2017 10:44:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=x0wPPRlTP+hG57wtidoHWk2+vjoeHDkgoaF0MMqIcI8=; b=Y1qsapLzBaufqwdHjHxRoZIpDR8wgEkea6b+wIDzDR38ifKZ4BpfUGxWXYerBtnIP6 E926UJny7UIf+iPCIVSGMyogECu7d5/1ULdlXWCXZ4EM+9aRsKvefOCmc71ierRS8Wx7 N6r+sn+4J3KmehBTHMl37+YrKCxIDhgVV2iGE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=x0wPPRlTP+hG57wtidoHWk2+vjoeHDkgoaF0MMqIcI8=; b=htuKg/m32BD10J8urKR1V3AGLxNvVEFqytTz/Zpv/ftMoyp63lu6sYby0i9TYJ9WAq 2t7NuAblFX/uUIWPznnLVrkeHl7r2G3MURPd5RiyG+byb1R0P8fOQNe6wW0CaOfOe78N KuFRRtj7ZVIU5vbjni7AmjqSom0VxrZKdNogC7MQWLhmqwR1f9yXLmjc3s72s68Qorfj 8CHswjrLxkWQ4xATwbussOzbP24FYLdiq9MoRL/cR1X6dsYzbITvHxUTNa2pLpUnJDUE Z+ETv7+Qr9oDsGS1xLRgOoWzJoHYtf0NLxZ45Vz3i3thNsfvhQl0OddASd4br7EQ6mEk HoYA== X-Gm-Message-State: AN3rC/5A+GdSotFTJyQCxVrMKjFEOaBdUIIVbKU/Je5Ie/NPdtZ8ev45wpauPkQ/sGER76Oe X-Received: by 10.84.173.67 with SMTP id o61mr36874212plb.46.1492019067633; Wed, 12 Apr 2017 10:44:27 -0700 (PDT) Received: from phantom.lan ([106.51.225.38]) by smtp.gmail.com with ESMTPSA id r17sm37750019pfa.13.2017.04.12.10.44.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 12 Apr 2017 10:44:25 -0700 (PDT) From: Sumit Semwal To: stable@vger.kernel.org Cc: Vitaly Kuznetsov , "K . Y . Srinivasan" , Greg Kroah-Hartman , Sumit Semwal Subject: [v2 PATCH for-4.4 09/16] Drivers: hv: get rid of timeout in vmbus_open() Date: Wed, 12 Apr 2017 23:13:43 +0530 Message-Id: <1492019030-13567-10-git-send-email-sumit.semwal@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1492019030-13567-1-git-send-email-sumit.semwal@linaro.org> References: <1492019030-13567-1-git-send-email-sumit.semwal@linaro.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Vitaly Kuznetsov [ Upstream commit 396e287fa2ff46e83ae016cdcb300c3faa3b02f6 ] vmbus_teardown_gpadl() can result in infinite wait when it is called on 5 second timeout in vmbus_open(). The issue is caused by the fact that gpadl teardown operation won't ever succeed for an opened channel and the timeout isn't always enough. As a guest, we can always trust the host to respond to our request (and there is nothing we can do if it doesn't). Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sumit Semwal --- drivers/hv/channel.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) -- 2.7.4 diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c index ec61ad8..800598c 100644 --- a/drivers/hv/channel.c +++ b/drivers/hv/channel.c @@ -73,7 +73,6 @@ int vmbus_open(struct vmbus_channel *newchannel, u32 send_ringbuffer_size, void *in, *out; unsigned long flags; int ret, err = 0; - unsigned long t; struct page *page; spin_lock_irqsave(&newchannel->lock, flags); @@ -183,11 +182,7 @@ int vmbus_open(struct vmbus_channel *newchannel, u32 send_ringbuffer_size, goto error1; } - t = wait_for_completion_timeout(&open_info->waitevent, 5*HZ); - if (t == 0) { - err = -ETIMEDOUT; - goto error1; - } + wait_for_completion(&open_info->waitevent); spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags); list_del(&open_info->msglistentry);