From patchwork Mon Apr 10 17:44:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumit Semwal X-Patchwork-Id: 97201 Delivered-To: patch@linaro.org Received: by 10.182.246.10 with SMTP id xs10csp1456497obc; Mon, 10 Apr 2017 10:45:56 -0700 (PDT) X-Received: by 10.99.113.18 with SMTP id m18mr58034851pgc.235.1491846356355; Mon, 10 Apr 2017 10:45:56 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w21si14197944pgh.90.2017.04.10.10.45.56; Mon, 10 Apr 2017 10:45:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753487AbdDJRpe (ORCPT + 5 others); Mon, 10 Apr 2017 13:45:34 -0400 Received: from mail-pg0-f48.google.com ([74.125.83.48]:34630 "EHLO mail-pg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752473AbdDJRpc (ORCPT ); Mon, 10 Apr 2017 13:45:32 -0400 Received: by mail-pg0-f48.google.com with SMTP id 21so109454556pgg.1 for ; Mon, 10 Apr 2017 10:45:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VLHjgau/bHn36t9u38eVY9C1h0TFKG2NxVBdYg6dTE8=; b=M3IA9k6QUEYbH+B9MzvFdHJ8fl7vHx4ZeoydqRzl3KZJmEMoZnSrPRu06GA9g5ct/B Z98rLwa7EtDLg5yQtH2WZgiD6ox/y7P6hedM9gWybZ3A4FvKHkmMMKY3mwFZlyeG040Q V2cz1YvRD9EuTvs4NaTxr4AMvcdTMN/YpLSBM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VLHjgau/bHn36t9u38eVY9C1h0TFKG2NxVBdYg6dTE8=; b=H1Bi2F7lvnfMjIxNIXopcdysqfAmcYB725lG3I3oAvDyRQOLAPhx1icsZmsepL0ooO 9o0ESxB4VV2RSK3Ctum5Rd1kswaYvn6388S55YTmpAaa3yxmK1/wXtlv8DiyzVK2eVkx N9k91sGdLe4DeRdFue3CgEVsNv72DCCKYs6/q2BmcnTyTYnOID4OLNw6GAEZAp5xseph rTpBgU3L3zFuD4Od+W3+P2+/JDdSrjftnHh0rLaGs/fYEZm41SviW3FpYFuSMe8FhuD4 Q0m3jQWSF6bWdpfhmH0fWHOW/gTr+PYCNTr77CKLnjvZRH66wOfGs35q8SsSDnif36GI ruUw== X-Gm-Message-State: AFeK/H3ta03E0PX+OM0b+7r+DoNFkuP8lHhW3cMQovh+JRs/jJp11N3E1ucmHJMHcLQc+Wb+ X-Received: by 10.99.178.6 with SMTP id x6mr57681698pge.80.1491846331763; Mon, 10 Apr 2017 10:45:31 -0700 (PDT) Received: from phantom.lan ([106.51.225.38]) by smtp.gmail.com with ESMTPSA id y6sm768833pfa.83.2017.04.10.10.45.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 10 Apr 2017 10:45:30 -0700 (PDT) From: Sumit Semwal To: stable@vger.kernel.org Cc: Vitaly Kuznetsov , "K . Y . Srinivasan" , Greg Kroah-Hartman , Sumit Semwal Subject: [PATCH for-4.4 08/16] Drivers: hv: don't leak memory in vmbus_establish_gpadl() Date: Mon, 10 Apr 2017 23:14:24 +0530 Message-Id: <1491846272-14882-9-git-send-email-sumit.semwal@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1491846272-14882-1-git-send-email-sumit.semwal@linaro.org> References: <1491846272-14882-1-git-send-email-sumit.semwal@linaro.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Vitaly Kuznetsov [ Upstream commit 7cc80c98070ccc7940fc28811c92cca0a681015d ] In some cases create_gpadl_header() allocates submessages but we never free them. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sumit Semwal --- drivers/hv/channel.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) -- 2.7.4 diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c index fb1e3df..ec61ad8 100644 --- a/drivers/hv/channel.c +++ b/drivers/hv/channel.c @@ -373,7 +373,7 @@ int vmbus_establish_gpadl(struct vmbus_channel *channel, void *kbuffer, struct vmbus_channel_gpadl_header *gpadlmsg; struct vmbus_channel_gpadl_body *gpadl_body; struct vmbus_channel_msginfo *msginfo = NULL; - struct vmbus_channel_msginfo *submsginfo; + struct vmbus_channel_msginfo *submsginfo, *tmp; struct list_head *curr; u32 next_gpadl_handle; unsigned long flags; @@ -430,6 +430,10 @@ cleanup: spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags); list_del(&msginfo->msglistentry); spin_unlock_irqrestore(&vmbus_connection.channelmsg_lock, flags); + list_for_each_entry_safe(submsginfo, tmp, &msginfo->submsglist, + msglistentry) { + kfree(submsginfo); + } kfree(msginfo); return ret;