From patchwork Mon Apr 10 17:44:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumit Semwal X-Patchwork-Id: 97209 Delivered-To: patch@linaro.org Received: by 10.182.246.10 with SMTP id xs10csp1456525obc; Mon, 10 Apr 2017 10:45:59 -0700 (PDT) X-Received: by 10.84.134.36 with SMTP id 33mr71305851plg.34.1491846359564; Mon, 10 Apr 2017 10:45:59 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w21si14197944pgh.90.2017.04.10.10.45.59; Mon, 10 Apr 2017 10:45:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753027AbdDJRpx (ORCPT + 5 others); Mon, 10 Apr 2017 13:45:53 -0400 Received: from mail-pg0-f47.google.com ([74.125.83.47]:36829 "EHLO mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753940AbdDJRpv (ORCPT ); Mon, 10 Apr 2017 13:45:51 -0400 Received: by mail-pg0-f47.google.com with SMTP id g2so107977625pge.3 for ; Mon, 10 Apr 2017 10:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pJPpAxTCXAFWsJOMqb2N3RYGj35hZ9PAsgs24tOjD04=; b=XEUHbFhK/M65gm+auu64Nk3tB5pU5cLP0ZWpV0qlIpbxE/7qX8cJ1cX7uHq/fCMp2v JdF+yGKCM0Zc+wZ2zPLYteebHM/8+R3SauH2aaqPEP4wwL9kkyVTB0Ho+u6jurg6D92C P7FlPbXU69lHu08H7e6yYT1mkACszhbqhSAqU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pJPpAxTCXAFWsJOMqb2N3RYGj35hZ9PAsgs24tOjD04=; b=S62nHhivNCjNq3WXWc7DeHjf47aJX1MR3eb3+O95WLX0PnHK6nruSQ1Db0aytV8ELp eE7NAO+LaPBVsvE+3kLQ3erT6irrvDp5qNJ3P8Pkg8nQjqk6CyA2HAw2HRpb8X5tMnvw /W2cwtQfjfcvQuag/S/Dr585jy1ibz69U0zevQZ6DCes+IH4hSoJSBnrMlZ11dJhxPhv y3xbxb+6/uaH/TL0AfJqTQmJrql8pE2X/p4kNORt8dfuBckxzdD4p3/c4gM4MlUg8efE Dfvd39sghZiwW54sc+Xnjj7j/AsyFHgNiMh6e5HMZVv3LsqXfcydBTeUisyJd1sukSQG QXEQ== X-Gm-Message-State: AFeK/H1cXHGBqyE42eE2P6e5C/feu4x7z++gbx8zuNnPrEstaZ3s376phkXpda93LrXsP5gh X-Received: by 10.98.141.67 with SMTP id z64mr52687776pfd.91.1491846340391; Mon, 10 Apr 2017 10:45:40 -0700 (PDT) Received: from phantom.lan ([106.51.225.38]) by smtp.gmail.com with ESMTPSA id y6sm768833pfa.83.2017.04.10.10.45.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 10 Apr 2017 10:45:39 -0700 (PDT) From: Sumit Semwal To: stable@vger.kernel.org Cc: Vitaly Kuznetsov , "K . Y . Srinivasan" , Greg Kroah-Hartman , Sumit Semwal Subject: [PATCH for-4.4 11/16] Tools: hv: kvp: ensure kvp device fd is closed on exec Date: Mon, 10 Apr 2017 23:14:27 +0530 Message-Id: <1491846272-14882-12-git-send-email-sumit.semwal@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1491846272-14882-1-git-send-email-sumit.semwal@linaro.org> References: <1491846272-14882-1-git-send-email-sumit.semwal@linaro.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Vitaly Kuznetsov [ Upstream commit 26840437cbd6d3625ea6ab34e17cd34bb810c861 ] KVP daemon does fork()/exec() (with popen()) so we need to close our fds to avoid sharing them with child processes. The immediate implication of not doing so I see is SELinux complaining about 'ip' trying to access '/dev/vmbus/hv_kvp'. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sumit Semwal --- tools/hv/hv_kvp_daemon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c index 0d9f48e..bc7adb8 100644 --- a/tools/hv/hv_kvp_daemon.c +++ b/tools/hv/hv_kvp_daemon.c @@ -1433,7 +1433,7 @@ int main(int argc, char *argv[]) openlog("KVP", 0, LOG_USER); syslog(LOG_INFO, "KVP starting; pid is:%d", getpid()); - kvp_fd = open("/dev/vmbus/hv_kvp", O_RDWR); + kvp_fd = open("/dev/vmbus/hv_kvp", O_RDWR | O_CLOEXEC); if (kvp_fd < 0) { syslog(LOG_ERR, "open /dev/vmbus/hv_kvp failed; error: %d %s",