From patchwork Sat Nov 12 14:22:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 81922 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp259691qge; Sat, 12 Nov 2016 06:22:53 -0800 (PST) X-Received: by 10.98.163.199 with SMTP id q68mr17405283pfl.87.1478960573027; Sat, 12 Nov 2016 06:22:53 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z63si15326404pff.293.2016.11.12.06.22.52; Sat, 12 Nov 2016 06:22:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965873AbcKLOWv (ORCPT + 3 others); Sat, 12 Nov 2016 09:22:51 -0500 Received: from mail-lf0-f54.google.com ([209.85.215.54]:34397 "EHLO mail-lf0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964785AbcKLOWu (ORCPT ); Sat, 12 Nov 2016 09:22:50 -0500 Received: by mail-lf0-f54.google.com with SMTP id o141so30666102lff.1 for ; Sat, 12 Nov 2016 06:22:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=HKtWJJmieo8XFPBT0LThsjFrnhgdPjQAqNGIrlTYE0w=; b=gDHww88KQAglIOFtfHynCIJ2ojXNgwcEMKmGyYlVEq4XQhLeQNDoxVsV1qRM/8HPHt ZZlNONCeb3C3WzieW8T+J7vBBr1SMyv96Hx18A3NSRbW7xE9uj5eLYdpJuyybgVzJb+Q ujTcLldpSLt4qY8AbSNeX6U9sArZTXCK0GpfQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=HKtWJJmieo8XFPBT0LThsjFrnhgdPjQAqNGIrlTYE0w=; b=j60byJh6SMojE4ArGYDaglHHI/SyHTGudzCT62+R4pWK2vvqbAetDTDblqfCq+ZU13 nJBLEGofRpzdeAVTsyFVUyAUpsze0d7kxMXzSexbscT4jhyycJpvYu2qfZ48QJI3y+Y5 BRhuDdNYVsZiXeHALifza4cAwgsxgLiE7BX49Lcv3k+fwvPsy1VyuF6QtiXDYjOkbJ4+ 8MxWIWVilRtmMXu0FfVFk5oVZAJP1RbjDmWidnuzZExluRwv1o0PxSm6qzcULf7Isylu qyxjxm0n2qGjN4hjiVj0x6Te+uPLvM14zLsvvCl1wTnpKs4Th9HQa6HhAq3LHHmclEam faGw== X-Gm-Message-State: ABUngvdVvUFTW9bpbCFnceXD3Eh1tVyU2VXY7IRGr071GCzb804vNNZD6xYpjHpmmMCOq+GE X-Received: by 10.25.125.2 with SMTP id y2mr4306952lfc.51.1478960568934; Sat, 12 Nov 2016 06:22:48 -0800 (PST) Received: from fecusa.localdomain (c-357171d5.014-348-6c756e10.cust.bredbandsbolaget.se. [213.113.113.53]) by smtp.gmail.com with ESMTPSA id s127sm3286562lja.14.2016.11.12.06.22.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 12 Nov 2016 06:22:48 -0800 (PST) From: Linus Walleij To: Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org Cc: Lee Jones , Linus Walleij , stable@vger.kernel.org Subject: [PATCH] regulator: stw481x-vmmc: fix ages old enable error Date: Sat, 12 Nov 2016 15:22:38 +0100 Message-Id: <1478960558-19859-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The regulator has never been properly enabled, it has been dormant all the time. It's strange that MMC was working at all, but it likely worked by the signals going through the levelshifter and reaching the card anyways. Cc: stable@vger.kernel.org Fixes: 3615a34ea1a6 ("regulator: add STw481x VMMC driver") Signed-off-by: Linus Walleij --- drivers/regulator/stw481x-vmmc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/regulator/stw481x-vmmc.c b/drivers/regulator/stw481x-vmmc.c index 7d2ae3e9e942..342f5da79975 100644 --- a/drivers/regulator/stw481x-vmmc.c +++ b/drivers/regulator/stw481x-vmmc.c @@ -47,7 +47,8 @@ static struct regulator_desc vmmc_regulator = { .volt_table = stw481x_vmmc_voltages, .enable_time = 200, /* FIXME: look this up */ .enable_reg = STW_CONF1, - .enable_mask = STW_CONF1_PDN_VMMC, + .enable_mask = STW_CONF1_PDN_VMMC | STW_CONF1_MMC_LS_STATUS, + .enable_val = STW_CONF1_PDN_VMMC, .vsel_reg = STW_CONF1, .vsel_mask = STW_CONF1_VMMC_MASK, };