mbox series

[4.14,0/2] usb: gadget: use after free in dev_config

Message ID 20220301022608.10950-1-hbh25y@gmail.com
Headers show
Series usb: gadget: use after free in dev_config | expand

Message

Hangyu Hua March 1, 2022, 2:26 a.m. UTC 
Author: Hangyu Hua <hbh25y@gmail.com>
commit 89f3594d0de5 ("usb: gadget: don't release an existing dev->buf")

Author: Hangyu Hua <hbh25y@gmail.com>
commit 501e38a5531e ("usb: gadget: clear related members when goto fail")

Add two commits to all stable branches.

There are two bugs:
dev->buf does not need to be released if it already exists before
executing dev_config.
dev->config and dev->hs_config and dev->dev need to be cleaned if
dev_config fails to avoid UAF.

Hangyu Hua (2):
  usb: gadget: don't release an existing dev->buf
  usb: gadget: clear related members when goto fail

 drivers/usb/gadget/legacy/inode.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)