mbox series

[v2,0/2] Set CLEAR_PAYLOAD_ID_TABLE as broadcast request

Message ID 20210224101521.6713-1-Wayne.Lin@amd.com
Headers show
Series Set CLEAR_PAYLOAD_ID_TABLE as broadcast request | expand

Message

Wayne Lin Feb. 24, 2021, 10:15 a.m. UTC 
While testing MST hotplug events on daisy chain monitors, find out
that CLEAR_PAYLOAD_ID_TABLE is not broadcasted and payload id table
is not reset. Dig in deeper and find out two parts needed to be fixed.

1. Link_Count_Total & Link_Count_Remaining of Broadcast message are
incorrect. Should set lct=1 & lcr=6
2. CLEAR_PAYLOAD_ID_TABLE request message is not set as path broadcast
request message. Should fix this.

Changes since v1:
*Refer to the suggestion from Ville Syrjala. While preparing hdr-rad,
take broadcast case into consideration.

Wayne Lin (2):
  drm/dp_mst: Revise broadcast msg lct & lcr
  drm/dp_mst: Set CLEAR_PAYLOAD_ID_TABLE as broadcast

 drivers/gpu/drm/drm_dp_mst_topology.c | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

--
2.17.1

Comments

Wayne Lin Feb. 25, 2021, 2:32 a.m. UTC | #1 
[AMD Public Use]

Thanks Lyude!

Regards,
Wayne

> -----Original Message-----

> From: Lyude Paul <lyude@redhat.com>

> Sent: Thursday, February 25, 2021 2:09 AM

> To: Lin, Wayne <Wayne.Lin@amd.com>; dri-devel@lists.freedesktop.org

> Cc: ville.syrjala@linux.intel.com; stable@vger.kernel.org; Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com>; Wentland, Harry

> <Harry.Wentland@amd.com>; Zuo, Jerry <Jerry.Zuo@amd.com>; Brol, Eryk <Eryk.Brol@amd.com>; Zhuo, Qingqing

> <Qingqing.Zhuo@amd.com>

> Subject: Re: [PATCH v2 0/2] Set CLEAR_PAYLOAD_ID_TABLE as broadcast request

>

> also - I meant to reply to v2, not v1 :). Just so you don't worry that I pushed the wrong patch series version

>

> On Wed, 2021-02-24 at 18:15 +0800, Wayne Lin wrote:

> > While testing MST hotplug events on daisy chain monitors, find out

> > that CLEAR_PAYLOAD_ID_TABLE is not broadcasted and payload id table is

> > not reset. Dig in deeper and find out two parts needed to be fixed.

> >

> > 1. Link_Count_Total & Link_Count_Remaining of Broadcast message are

> > incorrect. Should set lct=1 & lcr=6 2. CLEAR_PAYLOAD_ID_TABLE request

> > message is not set as path broadcast request message. Should fix this.

> >

> > Changes since v1:

> > *Refer to the suggestion from Ville Syrjala. While preparing hdr-rad,

> > take broadcast case into consideration.

> >

> > Wayne Lin (2):

> >   drm/dp_mst: Revise broadcast msg lct & lcr

> >   drm/dp_mst: Set CLEAR_PAYLOAD_ID_TABLE as broadcast

> >

> >  drivers/gpu/drm/drm_dp_mst_topology.c | 17 ++++++++++++-----

> >  1 file changed, 12 insertions(+), 5 deletions(-)

> >

> > --

> > 2.17.1

> >

>

> --

> Sincerely,

>    Lyude Paul (she/her)

>    Software Engineer at Red Hat

>

> Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've asked me a question, are waiting for a review/merge on a

> patch, etc. and I haven't responded in a while, please feel free to send me another email to check on my status. I don't bite!