mbox series

[for-4.9,0/2] wlcore performance improvement fixes

Message ID 1494504741-9723-1-git-send-email-amit.pundir@linaro.org
Headers show
Series wlcore performance improvement fixes | expand

Message

Amit Pundir May 11, 2017, 12:12 p.m. UTC
Hi Greg,

Please consider following wlcore performance fixes for linux-4.9.y.

These wlcore patches add a functionality in which the firmware is able
to notify the driver that the aggregation window size must be changed,
and in turn the driver will notify mac80211. Here is the original
submission: http://www.spinics.net/lists/linux-wireless/msg153522.html

We run into a performance issue recently on android-4.9 and earlier
kernels with AOSP on Hikey(using wl1835 module). Here is the bug
report: https://bugs.96boards.org/show_bug.cgi?id=497. These two
patches fix this performance regression.

Maxim Altshul (2):
  wlcore: Pass win_size taken from ieee80211_sta to FW
  wlcore: Add RX_BA_WIN_SIZE_CHANGE_EVENT event

 drivers/net/wireless/ti/wl18xx/event.c | 28 ++++++++++++++++++++++++++++
 drivers/net/wireless/ti/wl18xx/event.h |  1 +
 drivers/net/wireless/ti/wl18xx/main.c  |  3 ++-
 drivers/net/wireless/ti/wlcore/acx.c   |  5 +++--
 drivers/net/wireless/ti/wlcore/acx.h   |  3 ++-
 drivers/net/wireless/ti/wlcore/main.c  |  6 ++++--
 6 files changed, 40 insertions(+), 6 deletions(-)

-- 
2.7.4

Comments

gregkh@linuxfoundation.org May 11, 2017, 12:27 p.m. UTC | #1
On Thu, May 11, 2017 at 05:42:19PM +0530, Amit Pundir wrote:
> Hi Greg,

> 

> Please consider following wlcore performance fixes for linux-4.9.y.

> 

> These wlcore patches add a functionality in which the firmware is able

> to notify the driver that the aggregation window size must be changed,

> and in turn the driver will notify mac80211. Here is the original

> submission: http://www.spinics.net/lists/linux-wireless/msg153522.html

> 

> We run into a performance issue recently on android-4.9 and earlier

> kernels with AOSP on Hikey(using wl1835 module). Here is the bug

> report: https://bugs.96boards.org/show_bug.cgi?id=497. These two

> patches fix this performance regression.


No objection from me.  Should these also to into 4.4-stable?

thanks,

greg k-h
Amit Pundir May 11, 2017, 12:32 p.m. UTC | #2
On 11 May 2017 at 17:57, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, May 11, 2017 at 05:42:19PM +0530, Amit Pundir wrote:

>> Hi Greg,

>>

>> Please consider following wlcore performance fixes for linux-4.9.y.

>>

>> These wlcore patches add a functionality in which the firmware is able

>> to notify the driver that the aggregation window size must be changed,

>> and in turn the driver will notify mac80211. Here is the original

>> submission: http://www.spinics.net/lists/linux-wireless/msg153522.html

>>

>> We run into a performance issue recently on android-4.9 and earlier

>> kernels with AOSP on Hikey(using wl1835 module). Here is the bug

>> report: https://bugs.96boards.org/show_bug.cgi?id=497. These two

>> patches fix this performance regression.

>

> No objection from me.  Should these also to into 4.4-stable?


Doesn't build in its current form for 4.4. I didn't spend any time
refactoring it for 4.4, but I'll send you a refactored version soon if
I can.

Regards,
Amit Pundir

>

> thanks,

>

> greg k-h
Amit Pundir May 11, 2017, 3:36 p.m. UTC | #3
On 11 May 2017 at 18:02, Amit Pundir <amit.pundir@linaro.org> wrote:
> On 11 May 2017 at 17:57, Greg KH <gregkh@linuxfoundation.org> wrote:

>> On Thu, May 11, 2017 at 05:42:19PM +0530, Amit Pundir wrote:

>>> Hi Greg,

>>>

>>> Please consider following wlcore performance fixes for linux-4.9.y.

>>>

>>> These wlcore patches add a functionality in which the firmware is able

>>> to notify the driver that the aggregation window size must be changed,

>>> and in turn the driver will notify mac80211. Here is the original

>>> submission: http://www.spinics.net/lists/linux-wireless/msg153522.html

>>>

>>> We run into a performance issue recently on android-4.9 and earlier

>>> kernels with AOSP on Hikey(using wl1835 module). Here is the bug

>>> report: https://bugs.96boards.org/show_bug.cgi?id=497. These two

>>> patches fix this performance regression.

>>

>> No objection from me.  Should these also to into 4.4-stable?

>

> Doesn't build in its current form for 4.4. I didn't spend any time

> refactoring it for 4.4, but I'll send you a refactored version soon if

> I can.


I have rebased these patches for linux-4.4.y along with 3 other
related mac80211 upstream fixes and they build fine. I'm waiting for
the test results before I send them across for 4.4.y.

Regards,
Amit Pundir

>

> Regards,

> Amit Pundir

>

>>

>> thanks,

>>

>> greg k-h