From patchwork Wed May 31 13:08:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Riku Voipio X-Patchwork-Id: 100755 Delivered-To: patch@linaro.org Received: by 10.182.202.35 with SMTP id kf3csp295958obc; Wed, 31 May 2017 06:15:29 -0700 (PDT) X-Received: by 10.55.198.20 with SMTP id b20mr26843561qkj.224.1496236528949; Wed, 31 May 2017 06:15:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1496236528; cv=none; d=google.com; s=arc-20160816; b=zaHECiHVLrcr5flX3kuwFuVUxPhJbWUzGQeaQ8NNp/v4ITPORnt2YhAVGd4wxfA+I+ FkTR22xnf4QdMsz+aJ4cc5Oi+oWypgeN6njQYr1b92x3KY+sPBru/x4HiyYaG/YxVS8r WHQ/ZB7AGj2jPzRXvKvb5759K7WN03A30QK7fXBYGKue2rXbdrHPiyjJgFBLaHRc8NwO YpK25aUKerQZNgSD1BKAYRK5llE6xdskR6OR6rw8VOIqJOeqOu4hL6Bl6gwsJt0KJMh3 V8SnoRYFn0ue54bayv1CO0djQ1nHJ34XtcKjABQFvFHnGgKETonD1h+ivYKjlAoM0G0X iSbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:references:in-reply-to:mime-version :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=PjOZls7NZMolpNsQ7O8k0by2eAKY9zLTC3EFc4tNE58=; b=ByPBaPgLPwFelx08Ix3teFy1hwmqwdeeVX+ZnMk//4zZaBpBo6Fsaqng2G/qr3RI9D AF21E63bMyaU2qqnB1L0n9/4guFsW4F3KvRVAcQbHI7beZlRuKqveK8XeyV92ttsL2Za hivz2vFSlUwagkjJpC6OE9MJosuQTS4xPVeaDrphoqbmAYopLHjk4hygsJCfHSB4Uz9f GAxhUpT6msmcJ7bNOJZ/+cfv00LPNajUxzZ1NbJse2HrNvon1CXEB5ey/D+6OMfQimUn j+Eam6rReK84Ddioa/5+ui1kTyO+ibMsvz8eZHVonvkBNkh/CMC4fZPxY2SETkvmBRrP Itsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id t18si15686337qta.84.2017.05.31.06.15.28 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 31 May 2017 06:15:28 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:59350 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dG3TC-0004gk-7r for patch@linaro.org; Wed, 31 May 2017 09:15:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dG3Mr-0007gw-SR for qemu-devel@nongnu.org; Wed, 31 May 2017 09:08:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dG3Mq-0003gF-UR for qemu-devel@nongnu.org; Wed, 31 May 2017 09:08:53 -0400 Received: from mail-lf0-x22b.google.com ([2a00:1450:4010:c07::22b]:34521) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dG3Mq-0003g8-NI for qemu-devel@nongnu.org; Wed, 31 May 2017 09:08:52 -0400 Received: by mail-lf0-x22b.google.com with SMTP id 99so8623986lfu.1 for ; Wed, 31 May 2017 06:08:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version:in-reply-to :references:content-transfer-encoding; bh=PjOZls7NZMolpNsQ7O8k0by2eAKY9zLTC3EFc4tNE58=; b=MdQbqeJBVAaLVRzxke25jzOF0b5VC63j09S5z2Fg1+hAHcN6CzVKezdluVaiSg2j+Z 1RTJhViNJlH3mS66t6UFfWWdcpH8h9lWh/RRcgJUzai4Q4Rgh2JqeW6dHGlZfDvS/w1d 4y3fc9OmX7hBFUOZbwj54PQZrMaQWvxpisJ+I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :in-reply-to:references:content-transfer-encoding; bh=PjOZls7NZMolpNsQ7O8k0by2eAKY9zLTC3EFc4tNE58=; b=M+5huGv25y17FEoNBc9CVsY394BcFP1ec3NpDqym7h1Iy775X3iFd8FxhuZBWvxr+J JuwSH3DbehW4um7inqdcUX0YYLi6T7x2eTCJlyTox9iQugXAqOY6oQi9hgeryUUwZvAU ELGrUg2EoFNUGP5B93pibjb5BEbzR6tKUQ7l9SuPcs5Xr42gt8C+CTwCwDuYQpPRCeoT egsRDmrSGUFhNQZSkrY89n5QqKnrJCPipfVcbtaRy5rk8KmO0t75b/ppilUePlUWj0bQ R54eiJsKwDqfLl4QtmBvOFb2iJUGNtnA8414R6JXeBpyKYMpTc1QpRCPNTsrvH6v4mD3 sQmg== X-Gm-Message-State: AODbwcDS2vOI+tNZiDd55Y70pnq8fBgH+qQCzPKplKEtME81eEIgEyZk eyZfaZ2PJVs1yKL0kJwliw== X-Received: by 10.46.83.24 with SMTP id h24mr7947167ljb.84.1496236131151; Wed, 31 May 2017 06:08:51 -0700 (PDT) Received: from localhost.localdomain (91-157-170-157.elisa-laajakaista.fi. [91.157.170.157]) by smtp.gmail.com with ESMTPSA id o101sm3741766lfg.3.2017.05.31.06.08.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 May 2017 06:08:50 -0700 (PDT) From: riku.voipio@linaro.org To: qemu-devel@nongnu.org Date: Wed, 31 May 2017 16:08:26 +0300 Message-Id: X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::22b Subject: [Qemu-devel] [PULL 14/15] linux-user: fix inconsistent spaces in print_siginfo() output X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, =?utf-8?b?TWlsb8WhIFN0b2phbm92acSH?= , stefanha@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Miloš Stojanović This patch improves the consistentcy of the output from print_siginfo() by removing spaces around the equal sign of si_pid, si_uid, si_timer1, si_timer2, si_band, si_fd, si_addr, si_status and si_sigval. This way they match si_signo and ci_code. Host strace was used as a reference for this chage. Prior to this commit, typical strace output used to look like this: Signed-off-by: Riku Voipio --- linux-user/strace.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.11.0 diff --git a/linux-user/strace.c b/linux-user/strace.c index 779cda1a5e..5fbe067fd5 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @@ -206,26 +206,26 @@ static void print_siginfo(const target_siginfo_t *tinfo) switch (si_type) { case QEMU_SI_KILL: - gemu_log(", si_pid = %u, si_uid = %u", + gemu_log(", si_pid=%u, si_uid=%u", (unsigned int)tinfo->_sifields._kill._pid, (unsigned int)tinfo->_sifields._kill._uid); break; case QEMU_SI_TIMER: - gemu_log(", si_timer1 = %u, si_timer2 = %u", + gemu_log(", si_timer1=%u, si_timer2=%u", tinfo->_sifields._timer._timer1, tinfo->_sifields._timer._timer2); break; case QEMU_SI_POLL: - gemu_log(", si_band = %d, si_fd = %d", + gemu_log(", si_band=%d, si_fd=%d", tinfo->_sifields._sigpoll._band, tinfo->_sifields._sigpoll._fd); break; case QEMU_SI_FAULT: - gemu_log(", si_addr = "); + gemu_log(", si_addr="); print_pointer(tinfo->_sifields._sigfault._addr, 1); break; case QEMU_SI_CHLD: - gemu_log(", si_pid = %u, si_uid = %u, si_status = %d" + gemu_log(", si_pid=%u, si_uid=%u, si_status=%d" ", si_utime=" TARGET_ABI_FMT_ld ", si_stime=" TARGET_ABI_FMT_ld, (unsigned int)(tinfo->_sifields._sigchld._pid), @@ -235,7 +235,7 @@ static void print_siginfo(const target_siginfo_t *tinfo) tinfo->_sifields._sigchld._stime); break; case QEMU_SI_RT: - gemu_log(", si_pid = %u, si_uid = %u, si_sigval = " TARGET_ABI_FMT_ld, + gemu_log(", si_pid=%u, si_uid=%u, si_sigval=" TARGET_ABI_FMT_ld, (unsigned int)tinfo->_sifields._rt._pid, (unsigned int)tinfo->_sifields._rt._uid, tinfo->_sifields._rt._sigval.sival_ptr);