From patchwork Wed May 18 16:40:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 68054 Delivered-To: patch@linaro.org Received: by 10.140.92.199 with SMTP id b65csp2743139qge; Wed, 18 May 2016 09:51:27 -0700 (PDT) X-Received: by 10.55.82.6 with SMTP id g6mr9241050qkb.40.1463590287163; Wed, 18 May 2016 09:51:27 -0700 (PDT) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id f37si7515196qgd.81.2016.05.18.09.51.27 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 18 May 2016 09:51:27 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Received: from localhost ([::1]:46103 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b34gw-00056m-KH for patch@linaro.org; Wed, 18 May 2016 12:51:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b34Ws-0004Vd-BP for qemu-devel@nongnu.org; Wed, 18 May 2016 12:41:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b34Wl-0001lO-8W for qemu-devel@nongnu.org; Wed, 18 May 2016 12:41:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51069) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b34Wl-0001lI-2O for qemu-devel@nongnu.org; Wed, 18 May 2016 12:40:55 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8E63B80E6A for ; Wed, 18 May 2016 16:40:54 +0000 (UTC) Received: from colepc.redhat.com (ovpn-116-31.phx2.redhat.com [10.3.116.31]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4IGeqjb018070; Wed, 18 May 2016 12:40:53 -0400 From: Cole Robinson To: qemu-devel@nongnu.org Date: Wed, 18 May 2016 12:40:50 -0400 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 18 May 2016 16:40:54 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 2/3] ui: spice: Exit if gl=on EGL init fails X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann , Cole Robinson Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The user explicitly requested spice GL, so if we know it isn't going to work we should exit Signed-off-by: Cole Robinson --- For example, trying to use spice GL with libvirt qemu:///system will fail here, since the the VM will lack permissions to access /dev/dir/renderD* ui/spice-core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/ui/spice-core.c b/ui/spice-core.c index 61db3c1..da05054 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -833,9 +833,11 @@ void qemu_spice_init(void) "incompatible with -spice port/tls-port"); exit(1); } - if (egl_rendernode_init() == 0) { - display_opengl = 1; + if (egl_rendernode_init() != 0) { + error_report("Failed to initialize EGL render node for SPICE GL"); + exit(1); } + display_opengl = 1; } #endif }