From patchwork Thu Oct 15 12:13:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Elena Afanasova X-Patchwork-Id: 302832 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D5A2C433DF for ; Thu, 15 Oct 2020 12:15:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B45B2223F for ; Thu, 15 Oct 2020 12:15:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="piCUUFby" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B45B2223F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kT2AF-0005R3-9L for qemu-devel@archiver.kernel.org; Thu, 15 Oct 2020 08:15:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kT29E-0004my-V9; Thu, 15 Oct 2020 08:14:20 -0400 Received: from mail-lf1-x142.google.com ([2a00:1450:4864:20::142]:44359) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kT297-0005z8-HE; Thu, 15 Oct 2020 08:14:18 -0400 Received: by mail-lf1-x142.google.com with SMTP id b1so3287896lfp.11; Thu, 15 Oct 2020 05:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:user-agent:mime-version :content-transfer-encoding; bh=dQmz9rhOlDq0/v2hbjxNx9h96+dAcVbZNubb/iXznIs=; b=piCUUFbyoL8Ed8g0hah127MyF62P6+tx+NjUy8QnB2rakG+vYa4M337ryABTzYSrFH mp0omeHkoSFd6qZyzlOcnUDTSKBQmL7EuDIGtokqJHbbA0Izio11nnX3/zWs9aduAdok B1uZ3SWX0TO/Knxs8QwFXKiXQzaq/xQ9bd8TE5IkucXlfX1Rpvh6WF8TFdm9XnOrtC++ +ldk0onjhfNOtwR0MRNFrCRtJSrANxv9E2NvwnqvJqMvBsu93i920jCK6msMoy5Rgjk/ jdbEKn4OMHTlR5M3Yi3rWNNkc2NsuRxLH5OxaURL7jYXWI3On5kNPBpv+dBrvd1UGvj9 qIbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:user-agent :mime-version:content-transfer-encoding; bh=dQmz9rhOlDq0/v2hbjxNx9h96+dAcVbZNubb/iXznIs=; b=jgGO2u/ISuiV0VXJ/pMAgom/cOEaDLWmBvLaK5NmGP2xZPE5JWxidboZD1+BY8CZCv 7agRmg+CN9Pk4ZJ8eeDRmFEr0RZYJoAkdqnIECWqIXi/rr9QzXjB3mpLDnvu1mnSHaSU ERanOMHw2aYqG74MwAAtALgYZuLFKxkJTNLG3h2E4mPuIaR7noxKS6+OBgMy8rqu2+j9 9G//Ej8v1K7aY1pZ3WlhAZvcjDuBIgZNFM4ywhZh/f8x8HlWE5shoyg5Egvzk8/svFL6 3bkgILHAq5TDJO5BKIcWkvYBwgYs0d0+FXciOnNVCtmfN/IBo2TjjVQI/A/wGoqtyqnt 39zw== X-Gm-Message-State: AOAM531WiDpHqQDELnKYIENvveNnFRvKD7ao4o42a70+noY8478uUbE0 Tfva3A12fvCOmI3VWRB66ZA= X-Google-Smtp-Source: ABdhPJwl+ckbQwZ5A6+trQDL3DF17h3m15WGRm1C+FykN+9z8Etyom+fr9XFodGBjqNjp94cGojoLQ== X-Received: by 2002:a19:7917:: with SMTP id u23mr974577lfc.543.1602764050366; Thu, 15 Oct 2020 05:14:10 -0700 (PDT) Received: from [192.168.167.128] (37-145-186-126.broadband.corbina.ru. [37.145.186.126]) by smtp.gmail.com with ESMTPSA id x8sm970036lff.222.2020.10.15.05.14.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2020 05:14:09 -0700 (PDT) Message-ID: Subject: [PATCH] block/qcow2-cluster: remove dead code From: Elena Afanasova To: kwolf@redhat.com, mreitz@redhat.com, qemu-block@nongnu.org Date: Thu, 15 Oct 2020 05:13:54 -0700 User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::142; envelope-from=eafanasova@gmail.com; helo=mail-lf1-x142.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Since handle_dependencies() returns 0 or -EAGAIN the following case can be removed. Spotted by PVS-Studio. Signed-off-by: Elena Afanasova --- block/qcow2-cluster.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index aa87d3e99b..e2e0db0cc9 100644 --- a/block/qcow2-cluster.c +++ b/block/qcow2-cluster.c @@ -1806,8 +1806,6 @@ again: * structs before starting over. */ assert(*m == NULL); goto again; - } else if (ret < 0) { - return ret; } else if (cur_bytes == 0) { break; } else {