From patchwork Wed Feb 15 15:13:23 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 6794 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 2AF0B23DEE for ; Wed, 15 Feb 2012 15:13:26 +0000 (UTC) Received: from mail-iy0-f180.google.com (mail-iy0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id DBD86A18964 for ; Wed, 15 Feb 2012 15:13:25 +0000 (UTC) Received: by iabz7 with SMTP id z7so2142049iab.11 for ; Wed, 15 Feb 2012 07:13:25 -0800 (PST) Received: by 10.50.188.234 with SMTP id gd10mr11988112igc.29.1329318805374; Wed, 15 Feb 2012 07:13:25 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.231.66.135 with SMTP id n7cs14114ibi; Wed, 15 Feb 2012 07:13:24 -0800 (PST) Received: by 10.229.69.33 with SMTP id x33mr15653798qci.30.1329318803621; Wed, 15 Feb 2012 07:13:23 -0800 (PST) Received: from mail-qw0-f50.google.com (mail-qw0-f50.google.com [209.85.216.50]) by mx.google.com with ESMTPS id y9si1438357qcx.62.2012.02.15.07.13.23 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 15 Feb 2012 07:13:23 -0800 (PST) Received-SPF: neutral (google.com: 209.85.216.50 is neither permitted nor denied by best guess record for domain of peter.maydell@linaro.org) client-ip=209.85.216.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.216.50 is neither permitted nor denied by best guess record for domain of peter.maydell@linaro.org) smtp.mail=peter.maydell@linaro.org Received: by qabg27 with SMTP id g27so1447495qab.16 for ; Wed, 15 Feb 2012 07:13:23 -0800 (PST) MIME-Version: 1.0 Received: by 10.229.134.196 with SMTP id k4mr15575986qct.29.1329318803203; Wed, 15 Feb 2012 07:13:23 -0800 (PST) Received: by 10.229.35.1 with HTTP; Wed, 15 Feb 2012 07:13:23 -0800 (PST) In-Reply-To: <1329316588-10830-7-git-send-email-peter.maydell@linaro.org> References: <1329316588-10830-1-git-send-email-peter.maydell@linaro.org> <1329316588-10830-7-git-send-email-peter.maydell@linaro.org> Date: Wed, 15 Feb 2012 15:13:23 +0000 Message-ID: Subject: Re: [Qemu-devel] [PATCH v5 6/7] arm_boot: Pass base address of GIC CPU interface, not whole GIC From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, =?UTF-8?Q?Andreas_F=C3=A4rber?= , Paul Brook X-Gm-Message-State: ALoCoQlTs8bdFK41YLICUQzIN73ffqdmSDk65vnMdj5Gd9H62NKIx2Pr3766kMTcFQYRDsh7sTMs On 15 February 2012 14:36, Peter Maydell wrote: > The arm_boot secondary boot loader code needs the address of > the GIC CPU interface. Obtaining this from the base address > of the private peripheral region was possible for A9 and 11MPcore, > but the A15 puts the GIC CPU interface in a different place. > So make boards pass in the GIC CPU interface address directly. > > Signed-off-by: Peter Maydell Post-exynos4-landing this is going to need an extra hunk: I'm not going to rebroadcast the patchset for this minor rebase fixup, unless anybody specifically wants me to... -- PMM diff --git a/hw/exynos4_boards.c b/hw/exynos4_boards.c index 329efbe..553a02b 100644 --- a/hw/exynos4_boards.c +++ b/hw/exynos4_boards.c @@ -112,7 +112,8 @@ static Exynos4210State *exynos4_boards_init_common( exynos4_board_binfo.kernel_filename = kernel_filename; exynos4_board_binfo.initrd_filename = initrd_filename; exynos4_board_binfo.kernel_cmdline = kernel_cmdline; - exynos4_board_binfo.smp_priv_base = EXYNOS4210_SMP_PRIVATE_BASE_ADDR; + exynos4_board_binfo.gic_cpu_if_addr = + EXYNOS4210_SMP_PRIVATE_BASE_ADDR + 0x100; PRINT_DEBUG("\n ram_size: %luMiB [0x%08lx]\n" " kernel_filename: %s\n"