From patchwork Wed Feb 19 10:35:26 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Riku Voipio X-Patchwork-Id: 24937 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f71.google.com (mail-oa0-f71.google.com [209.85.219.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 1B328201EE for ; Wed, 19 Feb 2014 10:36:46 +0000 (UTC) Received: by mail-oa0-f71.google.com with SMTP id g12sf747135oah.10 for ; Wed, 19 Feb 2014 02:36:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=CUUHXvN4yT2ohoX4Z6a9aDALLwV8rSZvd78Zfg4OY3A=; b=UUJLdW+RMr/VqvfOtBpCwN41XCcxkQd+Fqu/OXlAjJIyBWTPeC0WgBRqVcQqZs+dpc LSwBnakC/WDt1Ng7MtFSEwMvpdEI9tXJ0ROCahfBG36QlYVwf+5qtNA8EvOUzb4I3d7n teE0oefU0SVB1kvYe15tqGSrbzcQ8L1HWqZfg27J5PMmOjJHYeBROfgyinWmWb1d+656 TbCR7e3o8SjLsqixYAd9ZKLoAHzoSXUbT0k3fBU/GeKu69XkkQyAJR+GVQsIpH7cEO7z P+A26y7ShzCpOXJk46vFHmB76WYjfD7axl/c0ndWEK71Mz4K/bJxBmNAHUGLMeoVHo9K bDtw== X-Gm-Message-State: ALoCoQlEtWGHYa3/opGCsUwYpu8s3Bu7gglfRVag8UJnPNWOsbHTkMymeqf/HuCQuCvpO/tb8pIK X-Received: by 10.182.158.4 with SMTP id wq4mr15197932obb.18.1392806205574; Wed, 19 Feb 2014 02:36:45 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.85.35 with SMTP id m32ls39258qgd.81.gmail; Wed, 19 Feb 2014 02:36:45 -0800 (PST) X-Received: by 10.52.107.35 with SMTP id gz3mr20813313vdb.8.1392806205430; Wed, 19 Feb 2014 02:36:45 -0800 (PST) Received: from mail-ve0-f170.google.com (mail-ve0-f170.google.com [209.85.128.170]) by mx.google.com with ESMTPS id kp12si6596854vcb.91.2014.02.19.02.36.45 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 19 Feb 2014 02:36:45 -0800 (PST) Received-SPF: neutral (google.com: 209.85.128.170 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.170; Received: by mail-ve0-f170.google.com with SMTP id oz11so183090veb.1 for ; Wed, 19 Feb 2014 02:36:45 -0800 (PST) X-Received: by 10.52.61.168 with SMTP id q8mr7730442vdr.40.1392806205372; Wed, 19 Feb 2014 02:36:45 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.174.196 with SMTP id u4csp286925vcz; Wed, 19 Feb 2014 02:36:44 -0800 (PST) X-Received: by 10.236.44.34 with SMTP id m22mr29901484yhb.9.1392806204661; Wed, 19 Feb 2014 02:36:44 -0800 (PST) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id w3si29274321yhg.139.2014.02.19.02.36.44 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 19 Feb 2014 02:36:44 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:58084 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WG4WC-0008AD-4X for patch@linaro.org; Wed, 19 Feb 2014 05:36:44 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WG4V7-00076m-GZ for qemu-devel@nongnu.org; Wed, 19 Feb 2014 05:35:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WG4V2-0007C6-Io for qemu-devel@nongnu.org; Wed, 19 Feb 2014 05:35:37 -0500 Received: from afflict.kos.to ([92.243.29.197]:33838) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WG4V2-0007Ar-9M for qemu-devel@nongnu.org; Wed, 19 Feb 2014 05:35:32 -0500 Received: from localhost.localdomain (afflict [92.243.29.197]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by afflict.kos.to (Postfix) with ESMTPSA id 8BB9726561; Wed, 19 Feb 2014 11:35:30 +0100 (CET) From: riku.voipio@linaro.org To: qemu-devel@nongnu.org Date: Wed, 19 Feb 2014 12:35:26 +0200 Message-Id: <3a5d30bf272c8db8e16e1e7ad5b8953f08df3e82.1392805802.git.riku.voipio@linaro.org> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 92.243.29.197 Cc: Peter Maydell Subject: [Qemu-devel] [PATCH 3/6] linux-user/signal.c: Don't pass sigaction uninitialised sa_flags X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: riku.voipio@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.170 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Peter Maydell When forcing a fatal signal, we weren't initialising the sa_flags field in the struct sigaction we used to reset the signal handler to SIG_DFL. Signed-off-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/signal.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/signal.c b/linux-user/signal.c index 82e8592..04638e2 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -420,6 +420,7 @@ static void QEMU_NORETURN force_sig(int target_sig) * it to arrive. */ sigfillset(&act.sa_mask); act.sa_handler = SIG_DFL; + act.sa_flags = 0; sigaction(host_sig, &act, NULL); /* For some reason raise(host_sig) doesn't send the signal when