From patchwork Mon May 26 11:23:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 892616 Delivered-To: patch@linaro.org Received: by 2002:a5d:6e53:0:b0:3a3:61c9:c5d4 with SMTP id j19csp1148524wrz; Mon, 26 May 2025 04:24:21 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVA2klPeBEj12Y3vDgCsfdRd7NwLUPUJbNaR3L2XCw4/Jw9uJ120d2nOp6M6KHy1IvOmbFh5A==@linaro.org X-Google-Smtp-Source: AGHT+IENtPwYH+jRynTLTK34fLA2kpFbxapWPRTXyZjtrRjQuQFLXYUaSt2LBeL36YL9i96kIDIj X-Received: by 2002:a05:6602:3a02:b0:85c:96a5:dc2c with SMTP id ca18e2360f4ac-86cbb8bee7emr885136239f.14.1748258661011; Mon, 26 May 2025 04:24:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1748258661; cv=none; d=google.com; s=arc-20240605; b=S0ydS3A2P0RnANE+Mc1Us5AV5CwgqDjRCyaxJ8nCRV3A3/LDL98ClBrX9Qg7qR0Sww 2ZFQhWcUlucEqHgER3FWs01rrgdkes17Y3oCyMyACwmAR3E+I5SKBXldY7k9g/zyAF1L NFTluYEFGYPEqZ1aBZ+4+j/X/pT9GWIoFPXsPHh1TYBobYeNef7UfuXarCBpqOj545E+ HMYv+eF48XyHY4YEi5M6RmmA7vmJSkSPBbXRM2Uuq6n4c6zh5SirZc+Y89MZHD1igdvr JI3oH70qNqj2TbVUNst1gSu9SvGo9YUvVYwmbvIWwz8gXEIU836tGVQAUmjOFQEHgPEM jd1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jNvIkaGWqwIyyf3qPO21sauAQBsDAgapC08M3PdrX3U=; fh=qfHpdDdaM4WI+lgLvXBC+e4AosthDmrnhJWYYS0AQIA=; b=fGhfDzYnM39WQiThQm/lR0rKxi+j23YTeCSBhjt9w8roqG2IE8+KuL3s42sZ7YwdyA NgwgUNxtzWsNLeJGUY/xI5Da1o/or1qfwL/+QplYZj1EbNJ9Ugs5FzOUMvDy7jJrueWy L1RyZvh/y/M2n9jiJhbNeindP1tf3TpkPMIcfring80TLI8DeZ0N/k2i+8qvvxRBY/dL 36ESy9U/3DBbU34XfVNbnfTCoaFEV34hIOsf6pyq662Ag9/pgTHl6/OP0IQ12GpQpwgh RHPXRc8FdTlm9/Cuwm2fqc7CH1hTikMDS6tJ9UEEBRenim6OLLHy+AooliyQfGrTtisq sDvw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kIroOeab; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ca18e2360f4ac-86a235b9381si371668139f.13.2025.05.26.04.24.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 May 2025 04:24:20 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kIroOeab; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uJVw0-0006Fr-BD; Mon, 26 May 2025 07:24:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uJVvx-0006Eu-H0 for qemu-devel@nongnu.org; Mon, 26 May 2025 07:23:57 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uJVvv-0001pL-KC for qemu-devel@nongnu.org; Mon, 26 May 2025 07:23:57 -0400 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-3a36efcadb8so2082211f8f.0 for ; Mon, 26 May 2025 04:23:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748258633; x=1748863433; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jNvIkaGWqwIyyf3qPO21sauAQBsDAgapC08M3PdrX3U=; b=kIroOeabYqKJve8r3aKCpOjFzOlOpNwZcvtiIGBF9WEj2vOYPlRoVC6CnlqnPnFzol QqCvWMKmdVYjGNWej5qccFwGjHYiUKcv2fDk1tq/LU2J1MLqsiF5l75ff+Y33uhg+Zvs 2coAttz0uCs7r1X1bBORVb8AkOyADYIEAb6LkCz+tid0yKdfLyCb1cq9ldwOvSDJaDYf GJJ3zQRpF/DBMV7MPl/Wxm3O6PzwM3Bx6VU67MM5nuuc20SAWCJhsxJpqdeLJAXw1snw bS/VklvSpOdFo4+rXMxrip1KW7RxbYONFHwDWqx9kzzz07NDVysMchMUShWYa8mstdjc KVOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748258633; x=1748863433; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jNvIkaGWqwIyyf3qPO21sauAQBsDAgapC08M3PdrX3U=; b=A0iy832W2DM5s0bu330CZTZo4nbiG5J4xaFgISY71YWoCMSg06RA0JpHi7KOYZ/Ptj EHSBxm9/B0Xg+wqoEiKzyxbdrpvO/SOVL5IY5KDAeIqle7GN4wyqOhpupBeMwW27Gyaq /ULS80u8El78coBjzkK/Wkg4dSaPgkI+Y/nwl26iCgmS2QLN9tdCW0XpBeD+QRBRs2v+ g6wKzKpPB16S4bknK3rTthscQqXUfC/f0bOVT/zCta60oJj47w6WFMPVHD4OT8LgueR9 nAMi9JsYQqB4EP9yYEn3CPYaNwqdhTgM5sc9yU5S8jxw3SSfe/oZCxfeBurD5i+IbUzd Rm2A== X-Gm-Message-State: AOJu0YzhfkgrYFBUm/yW2iDQTprZ7nbLOcF3nOIg4trIOfqGtoVLZtWs TOPzwK8GZ4m1kY7TqrAqEutbPvXUhoNT9aqGQj8mEKstp1glEVAKtwKiaMlfRAiK8mtoZ3qR1lY kqyKaxUC7Ow== X-Gm-Gg: ASbGncvb/to9DBVl4QJjnGJfUG6mn6K+mnWlIAsDhVOlTq2TpasFSaUPBnpEw32PZ+u 3V42Rd12WjlwvAJP7J6xlOvEGyyuzJBncIY4nG+Z4d+g0yBOC6J/X+1OwvVyDFNb6YTV9sv9pU/ 3leNuGPGPl8rdQFO/7dGJehdb84Z+mHiAzZNUL7uMS0plQWsWj7o3fNMdsYc7lcvnteWS519XLA tQzE2MKoaCvdDyOH8fkH+NaMTR77lqh8Q/FDXQ7xw46D70ZcED/twuKpYhxs16/gKkdiRBEEz4f z4LZTnp3mlyjZYCRcexutIobNTwjLRfjkIV5dIkq+XY8yYZj7GzveVSocaX3ADGVycgXR+CAb+3 13IGGbLLVRka8FNRFTnykyrPLXcL+oeM= X-Received: by 2002:adf:f0cc:0:b0:3a4:d02e:84ac with SMTP id ffacd0b85a97d-3a4d02e8731mr4434127f8f.13.1748258632991; Mon, 26 May 2025 04:23:52 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4de9c9853sm549909f8f.27.2025.05.26.04.23.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 26 May 2025 04:23:52 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?b?RnLDqWTDqXJpYyBCYXJyYXQ=?= , "Michael S. Tsirkin" , Nicholas Piggin , Igor Mammedov , Daniel Henrique Barboza , qemu-ppc@nongnu.org, =?utf-8?q?C=C3=A9dric_Le_Goater?= , Ani Sinha , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH 1/3] hw/acpi: Build IPMI stubs when ACPI is disabled Date: Mon, 26 May 2025 13:23:44 +0200 Message-ID: <20250526112346.48744-2-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250526112346.48744-1-philmd@linaro.org> References: <20250526112346.48744-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=philmd@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org When ACPI is disabled, no ACPI code depends on IPMI, so we don't need the stubs. We need them when IPMI is enabled and ACPI disabled, otherwise when using '--without-default-devices' we get: Undefined symbols for architecture arm64: "_build_ipmi_dev_aml", referenced from: _isa_ipmi_bt_class_init in hw_ipmi_isa_ipmi_bt.c.o ld: symbol(s) not found for architecture arm64 Split the source set list to avoid a too long line. Signed-off-by: Philippe Mathieu-Daudé --- hw/acpi/meson.build | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/acpi/meson.build b/hw/acpi/meson.build index 73f02b96912..76948cdd00d 100644 --- a/hw/acpi/meson.build +++ b/hw/acpi/meson.build @@ -26,12 +26,18 @@ acpi_ss.add(when: 'CONFIG_ACPI_PCIHP', if_false: files('acpi-pci-hotplug-stub.c' acpi_ss.add(when: 'CONFIG_ACPI_VIOT', if_true: files('viot.c')) acpi_ss.add(when: 'CONFIG_ACPI_ICH9', if_true: files('ich9.c', 'ich9_tco.c', 'ich9_timer.c')) acpi_ss.add(when: 'CONFIG_ACPI_ERST', if_true: files('erst.c')) -acpi_ss.add(when: 'CONFIG_IPMI', if_true: files('ipmi.c'), if_false: files('ipmi-stub.c')) +acpi_ss.add(when: 'CONFIG_IPMI', if_true: files('ipmi.c')) acpi_ss.add(when: 'CONFIG_PC', if_false: files('acpi-x86-stub.c')) if have_tpm acpi_ss.add(files('tpm.c')) endif -system_ss.add(when: 'CONFIG_ACPI', if_false: files('acpi-stub.c', 'aml-build-stub.c', 'ghes-stub.c', 'acpi_interface.c')) +system_ss.add(when: 'CONFIG_ACPI', if_false: files( + 'acpi-stub.c', + 'acpi_interface.c', + 'aml-build-stub.c', + 'ghes-stub.c', + 'ipmi-stub.c', +)) system_ss.add(when: 'CONFIG_ACPI_PCI_BRIDGE', if_false: files('pci-bridge-stub.c')) system_ss.add_all(when: 'CONFIG_ACPI', if_true: acpi_ss) system_ss.add(files('acpi-qmp-cmds.c'))