From patchwork Tue Apr 15 19:24:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 881269 Delivered-To: patch@linaro.org Received: by 2002:adf:f902:0:b0:38f:210b:807b with SMTP id b2csp630526wrr; Tue, 15 Apr 2025 12:48:05 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWs/zKGyM4kgyySutl26AYXAE1AFPTE0z8EVn2owqvS6+pR3RkdwU+I/8mAJ/SxlOQayfoYqA==@linaro.org X-Google-Smtp-Source: AGHT+IHbo7/lB43z2ELQ4Sr4ogJCDsdidcWpos+BcFfzBxJq8BX2wrBaw1o9ipim8O/KyJ9Vrch6 X-Received: by 2002:a05:620a:40c5:b0:7c8:4616:2d90 with SMTP id af79cd13be357-7c9141e7979mr135976085a.27.1744746485726; Tue, 15 Apr 2025 12:48:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1744746485; cv=none; d=google.com; s=arc-20240605; b=LicL6NzwW9SHYXkOPYkQNBoIHwP+yak45zOILFONr4TfFZCeyYquJKX8Q+OqAjeoee qWXayrgDWeg8UViOMFzhdhoWnXjQU16snXvAVhuSDjMcJgy9zDs9CLotI5QPYI9crb2X YdFCu4/tRa0qHMTYWQEHFa1/AsCsTk2e1qEXsaY+3gdDePBFY/M9E8s/Y59Bi8mhTD5W +78c1+ELchLTaKqk1lKPLWojd1zKQYTtrGLHsmgpX+wc5sqP2XJeB5Gs79lCwrd0EyRU i0QDPll6nsB8ySUqFsyXDRgAf2XC0y/xIqDn53nXS4yn1K0+081mTo7ToC2YrIQK0MkA BlJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=d+Cq5dbLnJd6hOWUgmUjB0Xm4SgGbIkaG92dvcfgQB8=; fh=PnYt+qEB9tAfMKoqBm2xjKOFpYyFFGPudh5cVIoieJM=; b=KY2z6xl6WXtYzWceyG5kE1kVhANh8GckSD+DZqjCI1NLyigfLXfqGC5aTXWJPSP6Gv n+xRh1UGXNgcUTRZVGdeGAcgxa5QHRmcloT7d2Kz5iPitT7Pf7U+9Au5u/NkFeW+HLf8 cXGdrK1VL8oOdNnUD9ohqA9szMOkEu3xHSGy7kpRqP+5VcYjKXkY29IuggTBDs7ahrmT xYtlHz/uiknoEyeTxmMeBx00gwEpOGleooyWHKFo7dr+mOz/7cnQCUiHgP+xrlPNiRv8 C6v+xY+rmhzfkcYFDPOBiB9FB5HnZo4sw8BQk5ot/4gH1fJHwPRqyNebdsscQkWZUcq1 3a8A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tkSMkwS0; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7c7a8a20a0fsi1136026285a.565.2025.04.15.12.48.05 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Apr 2025 12:48:05 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tkSMkwS0; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u4mG2-0007mo-7z; Tue, 15 Apr 2025 15:47:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u4m2p-0004rM-A0 for qemu-devel@nongnu.org; Tue, 15 Apr 2025 15:34:11 -0400 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u4m1k-0002vs-DP for qemu-devel@nongnu.org; Tue, 15 Apr 2025 15:34:03 -0400 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-2255003f4c6so62457105ad.0 for ; Tue, 15 Apr 2025 12:32:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744745567; x=1745350367; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=d+Cq5dbLnJd6hOWUgmUjB0Xm4SgGbIkaG92dvcfgQB8=; b=tkSMkwS0C9VjGDu18affKsOpSHNfa7GufBHQ1MNjuGa34f6asprRU+H7Tjd9Ht+tx5 gFDrm80nXfIJNIxxmSu/86pZMRX5fUqhAnuHRfj/LBCweRx78qvLe6IgYM6rkyparSGT 75u7jPjXQ6TLCh75Pjj4UVKkYOx+yZtfcRcAb5wlMwDTAJJxTPvVH2Ob0Jqtm/Zuyqgj 2KxIXvwneQbzV19/dPvHiue4ccWE18v6bbxz0xGozCzfFtmoycT0Vm6Isyvwe6QGQzpJ Puj5Poqt53dJyFKtp0RhF+X5uPo4KxpgkHalC4RmFJxc00htaR10pdra3Q9RudHg5Suq TRYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744745567; x=1745350367; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d+Cq5dbLnJd6hOWUgmUjB0Xm4SgGbIkaG92dvcfgQB8=; b=wkBF7EZfyG7IDa5Hyv70UzO/qmU5ppMZJrjFREDZQq2uDxs8sh7aHYBzaigeiCQFmS G+jA9tcgX5iECelNRl0Cnu7Ju11Nxu8PT5Amrj9L4yGEOFPdOMog/AxZiHopeLCmZZDE 9h+lBWNtt+HrYyJZr8zET1jdgJyhFfw1pCvh7ugD8oggT1u3pgKeMkxi2h5v3By3FsiH Nyl1z2kEINbfAM4p1/S3xOY0jU0CTcZlG+u3GMWCPEo6wcysi2dZzSzleyycdu4SXFQL gwgwK11M0iblPapl+ThQAjy12xfDwXhlxYgWMNZ8nGR/TtT22Ur+80sv5FkyDBG9at0u JoMw== X-Gm-Message-State: AOJu0YyJCiVibeMEr7y104aI4SuOXEDNO4lvzbH8pS7RdUWfCYEchyiY unfvLbj9CtTpRY9f3JI+eM/81PanvO2dEA0lfeiJ3ZVmxy7MrF08BK4P3QTbNUIGbUthwJky3hy m X-Gm-Gg: ASbGnctBdzSdu46zV2+eY9ZeKNAI4QUQkdMmvODA8JK6Cg6TXpmTc9WekClAncgdoTx x6oQCy3shpIPTnbwOVMyHxoLUqgeww0KM84pBRadLhQ1BPY1A16zIMGflCF+k9ZBrLbFxSqcG/A NXbvAQYHdXNl8pvp0AANkLzJjZyPTZcjXWXgPwhHwa8NdEuCN8bsHSA60WsP0G+TpgUdYvjWKGn XH7TqgNgS0TAfP/1dS1wtgmnnAmL+/H8ttChP1XHHrv6H18EOaDWlTXRK7Y+sY9eUNHcTHkDNUi vBaJ9VL1hYj66ptKvkr+g8bsojmXRsVBDJ5qxiR91/2RcMaO9bWDgEB7ZP419ae3Ipk+DALscRo = X-Received: by 2002:a17:902:db0b:b0:224:255b:c934 with SMTP id d9443c01a7336-22c31abf758mr4333665ad.51.1744745567091; Tue, 15 Apr 2025 12:32:47 -0700 (PDT) Received: from stoup.. (71-212-47-143.tukw.qwest.net. [71.212.47.143]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7ccbd5esm122062355ad.248.2025.04.15.12.32.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 12:32:46 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v4 107/163] tcg: Expand fallback sub2 with 32-bit operations Date: Tue, 15 Apr 2025 12:24:18 -0700 Message-ID: <20250415192515.232910-108-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250415192515.232910-1-richard.henderson@linaro.org> References: <20250415192515.232910-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org No need to expand to i64 to perform the subtract. Signed-off-by: Richard Henderson Reviewed-by: Pierrick Bouvier --- tcg/tcg-op.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index 8b1356c526..127338b994 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op.c @@ -1123,14 +1123,15 @@ void tcg_gen_sub2_i32(TCGv_i32 rl, TCGv_i32 rh, TCGv_i32 al, if (TCG_TARGET_HAS_sub2_i32) { tcg_gen_op6_i32(INDEX_op_sub2_i32, rl, rh, al, ah, bl, bh); } else { - TCGv_i64 t0 = tcg_temp_ebb_new_i64(); - TCGv_i64 t1 = tcg_temp_ebb_new_i64(); - tcg_gen_concat_i32_i64(t0, al, ah); - tcg_gen_concat_i32_i64(t1, bl, bh); - tcg_gen_sub_i64(t0, t0, t1); - tcg_gen_extr_i64_i32(rl, rh, t0); - tcg_temp_free_i64(t0); - tcg_temp_free_i64(t1); + TCGv_i32 t0 = tcg_temp_ebb_new_i32(); + TCGv_i32 t1 = tcg_temp_ebb_new_i32(); + tcg_gen_sub_i32(t0, al, bl); + tcg_gen_setcond_i32(TCG_COND_LTU, t1, al, bl); + tcg_gen_sub_i32(rh, ah, bh); + tcg_gen_sub_i32(rh, rh, t1); + tcg_gen_mov_i32(rl, t0); + tcg_temp_free_i32(t0); + tcg_temp_free_i32(t1); } }