From patchwork Tue Mar 25 06:50:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 875987 Delivered-To: patch@linaro.org Received: by 2002:a5d:5f4c:0:b0:38f:210b:807b with SMTP id cm12csp2504101wrb; Mon, 24 Mar 2025 23:54:03 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXYDAJe1fCEQdW6jN4xlGV4Tt3o3IOHaT5+Thrz78w0BLS1PcCAqNzmEtXOG/yaj0Aanpz+Yg==@linaro.org X-Google-Smtp-Source: AGHT+IHoxp1ewGYQrBQCWQk6Cs4a+nu7jn98TVajl8TCstIwP7fN3XCfrweooVy/2gjU9AT1061e X-Received: by 2002:a5d:584f:0:b0:38d:e0a9:7e5e with SMTP id ffacd0b85a97d-399795567ebmr17047347f8f.6.1742885643626; Mon, 24 Mar 2025 23:54:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1742885643; cv=none; d=google.com; s=arc-20240605; b=QEAUy+Y90R6b36AkPW010cQeLwBaasBUvl3w3eI0NMH+RoYj8+zBheYQfP6GDhoR8Q BS+DrR8TE5dOShptM+xe9CtcRGQW2GK+OPE9QwiCGlz1sS2VvPJfjKklA+vJXsIF0s3/ JFhdKaICqmeCevEZCEwATmSC7+vtEZzs2P80YcIDkNWw7jQZY7n4/t+/ZujsxxYjbZt+ Zq1j6FjkOWDX/+UONQ46pltpc4sheAFJBbDDKLvMZwDD5onTgJFah8z62087KNwmTCsA fr0RXRJgBEFmGOektA0FL0avId/FXPhWW6vFSVb1nHYOidhF/LN9cpAWt5EnqAWyovKX 5+Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=0Rf5r/GAkATvkh9P61nsErZk+v07DWDDGqmhVIjYPz4=; fh=NoJ7n5JVE2hviRF6uNBFRIJvWH7igafuy1AIwg26ToM=; b=j6d66k1cK+Q2pcZqmqPKAw8RQUJzqafp7JFIVtOqWKQVIZeShTuSAg9DIOzpj9BOky imBpRQGVzr11OcmMmEYIThCujITtaf9SL0kTYFqPgb5NIPa7I5UVF1oUZID1XSrKrGxb VOsiNDxGqwq7YPhuvKM+AbXIC4zxPy4HPUzM4/cvqARpKlM7uBHCZAwKK9SA6ccWkujK HSPb9NCtW2IuWL9tlwlmh2wJE87Ff/Ngs+d6xHSnj1c35CwZFY69+SgY/wYa/IM4fN9T RTfYsw6ux2BEqFL2mVageqKz0p/JgJ9VQt9IUwzXC9/iGFLGzBGxNXzqSlqQqD05Zs/T UjNg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ffacd0b85a97d-3997f97d20csi7098897f8f.32.2025.03.24.23.54.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 24 Mar 2025 23:54:03 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1twy7m-0004cg-Eg; Tue, 25 Mar 2025 02:50:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twy7k-0004Zu-IJ; Tue, 25 Mar 2025 02:50:56 -0400 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twy7i-0001eN-Fn; Tue, 25 Mar 2025 02:50:56 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id A2CEF107D63; Tue, 25 Mar 2025 09:49:21 +0300 (MSK) Received: from gandalf.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with ESMTP id 459541D5E72; Tue, 25 Mar 2025 09:50:31 +0300 (MSK) Received: by gandalf.tls.msk.ru (Postfix, from userid 1000) id 3596A5702C; Tue, 25 Mar 2025 09:50:31 +0300 (MSK) From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Richard Henderson , Peter Maydell , Michael Tokarev Subject: [Stable-7.2.17 30/34] target/arm: Simplify pstate_sm check in sve_access_check Date: Tue, 25 Mar 2025 09:50:25 +0300 Message-Id: <20250325065031.3263718-4-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Richard Henderson In StreamingMode, fp_access_checked is handled already. We cannot fall through to fp_access_check lest we fall foul of the double-check assertion. Cc: qemu-stable@nongnu.org Fixes: 285b1d5fcef ("target/arm: Handle SME in sve_access_check") Signed-off-by: Richard Henderson Message-id: 20250307190415.982049-3-richard.henderson@linaro.org Reviewed-by: Peter Maydell [PMM: move declaration of 'ret' to top of block] Signed-off-by: Peter Maydell (cherry picked from commit cc7abc35dfa790ba6c20473c03745428c1c626b6) (Mjt: target/arm/tcg/translate-a64.c is target/arm/translate-a64.c) Signed-off-by: Michael Tokarev diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 00463a1e35..190574cb29 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -1208,23 +1208,23 @@ static bool fp_access_check(DisasContext *s) bool sve_access_check(DisasContext *s) { if (s->pstate_sm || !dc_isar_feature(aa64_sve, s)) { + bool ret; + assert(dc_isar_feature(aa64_sme, s)); - if (!sme_sm_enabled_check(s)) { - goto fail_exit; - } - } else if (s->sve_excp_el) { + ret = sme_sm_enabled_check(s); + s->sve_access_checked = (ret ? 1 : -1); + return ret; + } + if (s->sve_excp_el) { + /* Assert that we only raise one exception per instruction. */ + assert(!s->sve_access_checked); gen_exception_insn_el(s, 0, EXCP_UDEF, syn_sve_access_trap(), s->sve_excp_el); - goto fail_exit; + s->sve_access_checked = -1; + return false; } s->sve_access_checked = 1; return fp_access_check(s); - - fail_exit: - /* Assert that we only raise one exception per instruction. */ - assert(!s->sve_access_checked); - s->sve_access_checked = -1; - return false; } /*