From patchwork Sun Mar 23 17:37:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 875619 Delivered-To: patch@linaro.org Received: by 2002:a5d:5f4c:0:b0:38f:210b:807b with SMTP id cm12csp1807054wrb; Sun, 23 Mar 2025 10:38:20 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUWLhabsMKXq1mtgYZ3Ku6GYmSmMHBNuYH5sZ93DdM2bBVsJv+cXn8DxwZQGKSzTpq6005ZbQ==@linaro.org X-Google-Smtp-Source: AGHT+IE+CewLjP+IfGNiGlMMHqfNhj4rnPrXC24iTchXyQMmNuYSbPW7eBSjgADLd/aMtQni1piZ X-Received: by 2002:a05:620a:22b3:b0:7c5:a424:1f67 with SMTP id af79cd13be357-7c5ba184095mr1028041485a.29.1742751500432; Sun, 23 Mar 2025 10:38:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1742751500; cv=none; d=google.com; s=arc-20240605; b=Za9rYG8yduyO5SNWMbHOqOPjxY8u+pOWu0RNK32oId1HRH2Z+Nia3fAExdLBYMnJLu qWmpfzusU8fP5xtmZ97AvRvnr7s+iBimJsxbFBkJcmAowEkdFn1QEGGYVAHOKy13PFZ6 PR8zYV4mGPU9E2kqxfw6p+1zrNBa2rkW7fOwAD05weBLnW56bRBwdDjHojG1rq22loEc oB146HRR1yH9U+7NkTxVQl1QTgAgq8lBhd+pyjSDprKWNMQskBv+rD4MUOeLBlc+WSG0 owQ1i4v0hjT+/BNE6KQjyR93k4uo2sW+xGGJtxRcUXioUgCJS+AXcLZhELPj1o1O3miU c8Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=kuaWE3TjFjqiJm1M4aj1btd/FSbEJW/CWHj5+bscQKY=; fh=Pq5/+ra/32jR7ARhXA/UPD87Ay4JBQ4WSaLIekKYvL0=; b=DO1WHyoYr2gLBMokLGzW0BqIjbEqITy24XqeJ0YfxE5X+hjbK+1XWrUpGTMjnZ9tjN K1Fq0HMdaDb0rMP4HVRfPKmfR6fGBwLchGqwWSzSktRvkFORALRBUsuYFtuX/SmRR3bX OJEmwNwuQ2fdgsaP3iRuWzUl5RWVUdwyWQh2BjJz6cnKxDml9RwAoyRLqqwyoqXDqATc DGetBcAvotoBTiBgKpOXuOjlIZM/VQfbOUHreyOdu1UrHVsSocXrAqjvVXtnEPR5OXeB aGyzv+zXVpHpMAKGWPi2lVBv6lD9vrG50Ajbgzveab+bNnixt3fLLkw/WQt0fgHCebdz A6Rw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XA7+3wFz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7c5b9362f7csi602616585a.578.2025.03.23.10.38.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 23 Mar 2025 10:38:20 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XA7+3wFz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1twPGY-0005qr-Au; Sun, 23 Mar 2025 13:37:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twPGV-0005p0-NY for qemu-devel@nongnu.org; Sun, 23 Mar 2025 13:37:39 -0400 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1twPGU-0002tf-2W for qemu-devel@nongnu.org; Sun, 23 Mar 2025 13:37:39 -0400 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-22398e09e39so70809405ad.3 for ; Sun, 23 Mar 2025 10:37:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742751456; x=1743356256; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kuaWE3TjFjqiJm1M4aj1btd/FSbEJW/CWHj5+bscQKY=; b=XA7+3wFzxC1EOFvPNPWaoT7fPdib5G9Hz0r3gTTyaPVp75FhFx3PK8l6FaQqywFZjQ 80FhYeQcpxjP+QGCaJ3FPOkLJjlZ4FAq+0jS0Wn0JWZQUmAVAMLOWWdyhXrqy0y6767C 3OnPbl7xaARpw1lkxOgiAJ3awIJxrUoaJWV/Z2221xYJfXJViu6KSQYFR8M8FznAYb4x PxnvJFV1Cp1JLTsva+pAgPgp0K3lpc8fv0gq88C9yxlHaKpEF7ptte7it7IRwlcJKfCO KgviSL5ewJjNpC9FG1bylF8ik7YtNO9pgXTjVQa50Go5K13zx8GCow5Sm2LgX99p1ezX iZdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742751456; x=1743356256; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kuaWE3TjFjqiJm1M4aj1btd/FSbEJW/CWHj5+bscQKY=; b=CtmngcuAdpcK/0KvoBtE/DO0/WEjd5e3M+iqdH5xRQAqPWiQ3EQQRKun71CTN1ANe8 hB2pD2kUWky8n5qdNnZj/URfIjS/XsLqbbhLHG2o2hr8Lz76bR7hU0vCpm92l0Bwiiod qr7Z9I7N4jc3jWXxkx2pcPavbucI1KF0Xrs783wvIpjwEOT3W70C1JqH/eLItYzDaV8e TeSL+q27GpGdcAGz8BlDaBzX/QfWECgo4dulzrlNR/BcaWr1l0yRFVctj7KQjY0WcsZl uniIZMkL86JxBuiXPTmR0F6IjrY6SuZ26fsMi1ztgIIqX9hqPeKWbs/G0kl7VRDV1YSG P1Kw== X-Gm-Message-State: AOJu0Yw3Wu82VU98gov/ASmnGmYK8Qac9HxMZV5NOe0ZeF+IYxAb3YwE kISse1uJ7kiwdTYnVcUtRf+rMdHPsGqzXs6SFaWZdQBkALjXiib2EtZ3S4wjE4y8fcel6XRM7IB m X-Gm-Gg: ASbGncs/BClFXct3yjxPMTkO3OR53W+juDecpBJD/Anqo/d6cTcwAw2rEbvdIe72ogG X80POGeO1aTQ+CW4d6hJH+PYIv8y727D0hDb8OpidYS2PwFNiJIjJNi7+C6CV2N7bmzIjTTCA93 gyZ1xy8zyFT4lNPYc00jf6XkXTu9+pUqWd8Va7vzquFEY1LuMBAEudHbITa6lpoLbNtR9fmWtEI iqgnklQEWdg9RwLzy2e+GqBKoS7LWnct7ExH0il5Lu2XsXd9jrbyiKPMgMeJA2Epgq35X3RRMCs Rm6LjOCjYLdr3CGdVN4Lf0Swel+H7H3mczHMzcUu74FZ2p/68DHmjGsIPD16ECN8MXqu4km7v58 b X-Received: by 2002:a17:902:ecd0:b0:224:1eab:97b5 with SMTP id d9443c01a7336-22780c529e9mr144510455ad.1.1742751456529; Sun, 23 Mar 2025 10:37:36 -0700 (PDT) Received: from stoup.. (174-21-74-48.tukw.qwest.net. [174.21.74.48]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22781209ff3sm54075165ad.257.2025.03.23.10.37.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Mar 2025 10:37:36 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: mrolnik@gmail.com, philmd@linaro.org, pierrick.bouvier@linaro.org Subject: [PATCH 07/17] target/avr: Use do_stb in avr_cpu_do_interrupt Date: Sun, 23 Mar 2025 10:37:19 -0700 Message-ID: <20250323173730.3213964-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250323173730.3213964-1-richard.henderson@linaro.org> References: <20250323173730.3213964-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier --- target/avr/helper.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target/avr/helper.c b/target/avr/helper.c index 7cfd3d1093..9608e59584 100644 --- a/target/avr/helper.c +++ b/target/avr/helper.c @@ -88,14 +88,14 @@ void avr_cpu_do_interrupt(CPUState *cs) } if (avr_feature(env, AVR_FEATURE_3_BYTE_PC)) { - cpu_stb_data(env, env->sp--, (ret & 0x0000ff)); - cpu_stb_data(env, env->sp--, (ret & 0x00ff00) >> 8); - cpu_stb_data(env, env->sp--, (ret & 0xff0000) >> 16); + do_stb(env, env->sp--, ret, 0); + do_stb(env, env->sp--, ret >> 8, 0); + do_stb(env, env->sp--, ret >> 16, 0); } else if (avr_feature(env, AVR_FEATURE_2_BYTE_PC)) { - cpu_stb_data(env, env->sp--, (ret & 0x0000ff)); - cpu_stb_data(env, env->sp--, (ret & 0x00ff00) >> 8); + do_stb(env, env->sp--, ret, 0); + do_stb(env, env->sp--, ret >> 8, 0); } else { - cpu_stb_data(env, env->sp--, (ret & 0x0000ff)); + do_stb(env, env->sp--, ret, 0); } env->pc_w = base + vector * size;