From patchwork Sun Mar 23 17:37:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 875622 Delivered-To: patch@linaro.org Received: by 2002:a5d:5f4c:0:b0:38f:210b:807b with SMTP id cm12csp1807140wrb; Sun, 23 Mar 2025 10:38:40 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV7T2RrhnswlTQBs+F8TLz0fAh0d8G3lTvxoa5e93HJBnb9lyJ0hY8fkPTnpjjsUS55btxyng==@linaro.org X-Google-Smtp-Source: AGHT+IGOlgEk/faQTwNj0f4xkcnAlBX+/qLyOZOO923hzr86fSCMy7EwrDDHHImURR/kDGrputiv X-Received: by 2002:a05:622a:5c07:b0:472:1d98:c6df with SMTP id d75a77b69052e-4771de948ddmr168987711cf.52.1742751520022; Sun, 23 Mar 2025 10:38:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1742751520; cv=none; d=google.com; s=arc-20240605; b=VMSJjXhrQOPWCGNjz11PFQfALUlL+dE0a/7BtUIuJV2+UrLYkPbrLwprhPrldVLOMW FNtZTdOyfXGvh73zTFbu7+GpbP8cIUHAVw64CtP/PKq5K6qD0ieYyJCG22hdjrJK6ARe Sokwmsp+zhqCh1FB7CH2cVVjS6SwSOXE26qF67AAaOe/PcWvpDzwfruDq8zkNryTJDyy EdfppvGEzWL1VtFks+4MwwrGSGp6dAvfzgJ8K33ua35Y7kqpSupx0H7jO0i7NjRel56y 9TvGVb0t4ZVCqQiSu940jcFvb+NxKG9s6gSuCbX8Bdq2yTQexSFdqFrnj0Xq8ugLF2EL tXiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Ntv50KlP9/+Qy60eqjdM/5mfxACbQs3UzEcbO1R0LI0=; fh=Pq5/+ra/32jR7ARhXA/UPD87Ay4JBQ4WSaLIekKYvL0=; b=dXcqu+1CYVhgH4AdftDYs4wLziSTgRz4/W1t6OoEla6Wt/hFi5bk8QjeR2e1Vs3EtU rFuix723F7tgMqA+6XxBMtUXSu1BheIQwWQR+FY+EB4gmLBXamAlJaC2ETM4D/h2dx4J Qi/HCNI5BiUuTmGuI346fMS7SZEdR/A7HlHhkPl7PxBBjOlo9GZiCEUgGRpiY3HhI7cp r9Hweo7HaII5OPUgr/FzE4EbcI+oaeAV9kmzDp+ymDpTX30ucXztzDaqnT+dCm666tIB 5eHO3IEWk2YYNfuZ7Oy+kujx45bybhpx4r4ND9J7ua80sYAJt1rKp8O9oAMe2zikccOR NKWg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bDI58YWB; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-4771d50bb93si61322351cf.312.2025.03.23.10.38.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 23 Mar 2025 10:38:40 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bDI58YWB; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1twPGX-0005pz-A6; Sun, 23 Mar 2025 13:37:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twPGV-0005oR-BY for qemu-devel@nongnu.org; Sun, 23 Mar 2025 13:37:39 -0400 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1twPGT-0002tR-Fl for qemu-devel@nongnu.org; Sun, 23 Mar 2025 13:37:39 -0400 Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-3018f827c9bso4898054a91.0 for ; Sun, 23 Mar 2025 10:37:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742751456; x=1743356256; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ntv50KlP9/+Qy60eqjdM/5mfxACbQs3UzEcbO1R0LI0=; b=bDI58YWBXyeYvRCmsxbe2nHCfsK/ED2AI8YMSo+XispEf6bdMQRQx4TnQbti5b+3u1 yZRSS3DL/4FzS+Uo1J6/H3di2iiSK5coDRqDZnaipAgSvudPsqX/AS9cfvPvp4otewbG VDzJ8X+rcILbD/YgTzktM+ry2FC85kc4uNpnz8Vt3Ib1FljuplCPb7hUCVO37jE5mRgL dBifwnL5tfk5+x1vstKaSyyoTGIEWsBlePMB5WmP7aailJyor0yt/tr+kbFKMTgkeRqA gezLmoSvb7BFdPOOmPxXW5tO6T5ewXLELB5ziNSi8cCRgfjAfLZUX5bKupAhCfIE2q3+ 79Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742751456; x=1743356256; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ntv50KlP9/+Qy60eqjdM/5mfxACbQs3UzEcbO1R0LI0=; b=gfse2N1xbF2GDHynQOSbD5CfZXDq1MaJDW3DpYJrcObL3zBLW5w0dbciztHKhSrJmh 7pKmKBCP0R2KzdYfUhY1w8GZiDL9ZA9bhW5luoqGaotqMxP7MF/2UH6d2yAyR+pPC08J NvcHfQypHiAt0CbNs0H71uEP3V2prwbrdcfqGlRvUJ1lE9kKV0F4Jigopdlek1WKIumI Kj+y+JboSceeF+I8PEh4Bow+oF/qBtaH4A0UkgAkR0zYxqysM9kCGi9G0GQ2CvrfJdDT +8nLF9/WnSZCvdY8vrjp/DkUlbh2Kue+ARQz9Cqx3U3azE06bWuvWoQEiXhWUtPA27zI olgQ== X-Gm-Message-State: AOJu0YxfGzpyN/bzoHD4xoXXeHE0CxPnTQK/P0mqi0Q+DWS5eNUOPil+ g4UveD0A1nQhv6LMCiIewLKmj9REgqrDen+GbmaJGPEqxL8SG8Q6nEd1HZOpof76prUxSNYNAiR / X-Gm-Gg: ASbGnct6xduoS2/tQVKqfV8Y0Ii+fK48pIRZT9ssZ7d9LWptwvE5ljkXE4+NqUJdJ74 XTXMJG8vSAJtgXSTAQyNJzCy5rqfrAFe5yNmYsWP5Wlm4DCUokvQPfZWMsLy1WuMTsCKwBjxxen iHmnhnjo6SZzNFxr86HQpAjWKO570SoHzLlKbHfd7yL4NOXHBp9ni0warNngaI5G2kip+4vm9yR FV8jxSJgRB5P1z2p2is8JffohUlRtmOxhVJLm8hoHjjLV1L6lcaRQqTbwLzNSii6f4qQPfrYPXu OaEOythHlYGvjNA8VQzcOgsBRheouTPW74jvotxBJPdDITFg+vm1iS/1vjAP/UHNyXwpFdvSdBA Z X-Received: by 2002:a17:90b:2743:b0:2ff:4a8d:74f8 with SMTP id 98e67ed59e1d1-3030fe721dfmr14669091a91.6.1742751455820; Sun, 23 Mar 2025 10:37:35 -0700 (PDT) Received: from stoup.. (174-21-74-48.tukw.qwest.net. [174.21.74.48]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22781209ff3sm54075165ad.257.2025.03.23.10.37.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Mar 2025 10:37:35 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: mrolnik@gmail.com, philmd@linaro.org, pierrick.bouvier@linaro.org Subject: [PATCH 06/17] target/avr: Use cpu_stb_mmuidx_ra in helper_fullwr Date: Sun, 23 Mar 2025 10:37:18 -0700 Message-ID: <20250323173730.3213964-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250323173730.3213964-1-richard.henderson@linaro.org> References: <20250323173730.3213964-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1035.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Avoid direct use of address_space_memory. Make use of the softmmu cache of the i/o page. Signed-off-by: Richard Henderson Reviewed-by: Pierrick Bouvier --- target/avr/helper.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/target/avr/helper.c b/target/avr/helper.c index df7e2109d4..7cfd3d1093 100644 --- a/target/avr/helper.c +++ b/target/avr/helper.c @@ -23,10 +23,10 @@ #include "qemu/error-report.h" #include "cpu.h" #include "accel/tcg/cpu-ops.h" +#include "accel/tcg/getpc.h" #include "exec/cputlb.h" #include "exec/page-protection.h" #include "exec/cpu_ldst.h" -#include "exec/address-spaces.h" #include "exec/helper-proto.h" bool avr_cpu_exec_interrupt(CPUState *cs, int interrupt_request) @@ -67,6 +67,11 @@ bool avr_cpu_exec_interrupt(CPUState *cs, int interrupt_request) return false; } +static void do_stb(CPUAVRState *env, uint32_t addr, uint8_t data, uintptr_t ra) +{ + cpu_stb_mmuidx_ra(env, addr, data, MMU_DATA_IDX, ra); +} + void avr_cpu_do_interrupt(CPUState *cs) { CPUAVRState *env = cpu_env(cs); @@ -311,8 +316,7 @@ void helper_fullwr(CPUAVRState *env, uint32_t data, uint32_t addr) break; default: - address_space_stb(&address_space_memory, OFFSET_DATA + addr, data, - MEMTXATTRS_UNSPECIFIED, NULL); + do_stb(env, addr, data, GETPC()); break; } }