From patchwork Wed Mar 19 19:31:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 874747 Delivered-To: patch@linaro.org Received: by 2002:a5d:6a90:0:b0:38f:210b:807b with SMTP id s16csp580145wru; Wed, 19 Mar 2025 12:32:30 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCU3ro3Unvkvm8FUXZkwHhp1kzI5Oj5IPwFeBsGlAZIrqTZQEYVxhp6sALux3myKlcDAi1qVAw==@linaro.org X-Google-Smtp-Source: AGHT+IFM+nnYnivlksFBNKWEo3gJw1Fu7Q0m4OjCOg1xcOx/VhiNf6PRFmBe0Wo4hKS2B5O89MJ0 X-Received: by 2002:a05:600c:674f:b0:43c:e2dd:98ea with SMTP id 5b1f17b1804b1-43d43842641mr43034985e9.22.1742412750151; Wed, 19 Mar 2025 12:32:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1742412750; cv=none; d=google.com; s=arc-20240605; b=U4wh1O9hqazD14YqiKSQ0DgLStv1SjlE1rGWu9LqrlEYzr8t4jBCtmdl1QXVnYIbmy nH2cD3Wk/v/X3J80013OfEYiihh5EnD+Acdf38JkyF4TxxjG+2nkkleVr4SGulsBGP6V lATn86KBv8bJTAs3x+qfPUBkftqLq5vrNebc1n9hjQlJRKXAII4+bRV4hoV6/SGi+Ctb fScJwudTgrlT8ncY8IXu1YIVeDU3lV4ZgGyxZSd0zDviVL7RGYCsjs98nvBm9uaMmacD hsDV2cR8HZCx9TpLSowXBYNcWNJrLEsJoNRknYGpgLLldpa+950Jx6ZM1pYAGfwTuqFu bFKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=qL1c+a1aNYoFYFU2SSF4d7BI0nk3Z2oqN48usIOFSqg=; fh=6NxXR/tcQIxOhzKPO7cwT8TIBjk9bNv+OCF8B85DBkg=; b=cyp1Bby3gJHOJjLhBvjEB0Q47hPjRxyv3ZBy3zWyrWL80FiDYLhO3zjio42FeBNqy2 uKPOPVEFfHlgBCGytMendZxGkU5lb/EURAd7zNU9wJqFIalNRrEjDcWwReUMoTKxxeUY tsYczohqoY5zTvpleE4zYmST3GbAIYLwq6+ED0AWC/fxh7ItkNXnzeUKmfQ8rc/mr+Cn fM4J6UHuAuhcDhyW9Oga/0PzPjhwEFzRhiSIOBKwnZUpwGTVvM6UxeVqEcbcC1sIxWqC 7tAgai45D1dJ8RjbzMNir949+4qmt3RiLh0RtdJgixGF9g+GEY/cehgrYS6RE/0eMqRv kEnw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=g+n+Ki9W; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 5b1f17b1804b1-43d43f47b40si15007195e9.69.2025.03.19.12.32.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Mar 2025 12:32:30 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=g+n+Ki9W; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tuz8N-0004VT-Uc; Wed, 19 Mar 2025 15:31:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tuz8M-0004Uj-Uf for qemu-devel@nongnu.org; Wed, 19 Mar 2025 15:31:22 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tuz8H-0005P6-07 for qemu-devel@nongnu.org; Wed, 19 Mar 2025 15:31:22 -0400 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-394780e98easo4680500f8f.1 for ; Wed, 19 Mar 2025 12:31:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742412675; x=1743017475; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qL1c+a1aNYoFYFU2SSF4d7BI0nk3Z2oqN48usIOFSqg=; b=g+n+Ki9WtKWbQif1hNmbma+Y7oZ2Pd6ppP8LZk6NMlDeEKLCjXMuIvJ3+8LEk8nqbF bwjLMETA8dyKhi1d6KCLfmlXlfsCu7hqevNDF2F9beleLCjHh3ynQ4sXAMuiFY/UP2zc ieFPVRFyfjSdeCHLzN7vacH7AflVVC7KteO2Cmx+rNela7pPwuN2Q3OaVO/q0jq/gEs/ C1QklMCUgkIFwYx4R0J1uqm8mItFuGakb7IMbRlI7dZCrPMvBbAAZ0v+huWcvZxNgEkz xe3NCWNa8OTupqvIxzvxi8YMrXD6ovBQVlvP2oCAslRk58NRnCvWYyh3BVddK8YYp2Za LhXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742412675; x=1743017475; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qL1c+a1aNYoFYFU2SSF4d7BI0nk3Z2oqN48usIOFSqg=; b=uUogSfaK5NwnAf8aR4d+jHQFWgQwfv/X+kI7rPqGrxutk0Hgw6CU69q57wK+WyEFt4 WD1aRGtw8mAGorK/K47dxdqkA/JwvRJkLIHCuQxtIdvMoZPYqu2olWmCp9C9P9Ly47so B9S4LGe3WWgXjlrLMvmAOATsRvOhtz/TESkcnVpVUZ8ebItxoLBq6CLqS1MaPGt2/rvs JNOpqfxwHG6Tow369WFnThunAhambjNH9pnH49b38GL0MY6IMbLyErBp+aq+Rp7gqMMU aLxoSgLWY8RVnsYwiWaln6m7ruA9XoW2ULoyh3DyZrn/VoGpPiYg+CZLbBTi6Q8W6EFO ZFsQ== X-Gm-Message-State: AOJu0YzO4km7bDYfbCttbXbSpzOl0qroaHy2AiKAg5FUfk/on+MQflff woXhQ6MDE0c0//0GdTprQoR55+I67+CayRspcTf8793e+/QD9tVF+hxKHj7Kvko61ZoN5uzIXo3 y X-Gm-Gg: ASbGncvXFECOeciaBhx6OsbbGyKMX0QDqaOvMiytvVGgM0q25JI3zQ2QgHjBgvdh1ff IYcUM6/LkzIB9/3pSWzQdyEUR3gN8n/MG8SaPFLFEo3BWTX93OEvOdXMSPDm2mU4qhX9XmVbqJF ApgEu0igZmc//kp8+JimGLQ4gm5WOnpSj2hgApLXWbQ31LdsT23inD+T6kYqZPXbZf8KUF0EWuD LXuza1twC1mn7b4Qj39Xv7rJLA8Wa3uUyuGIN7vL5qY73il+Y/8SqMYAWy3L8fO93ze9T2fdfav UM98XBSpQk7jYG5HbKmurDIkhnePKDM0j/m/gc6RjTuaGWcnKIU= X-Received: by 2002:a5d:47ca:0:b0:391:2f2f:818 with SMTP id ffacd0b85a97d-399739bbc6cmr3665462f8f.9.1742412675417; Wed, 19 Mar 2025 12:31:15 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d43f47196sm26790495e9.16.2025.03.19.12.31.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Mar 2025 12:31:14 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: qemu-rust@nongnu.org, Paolo Bonzini , Tanish Desai Subject: [PATCH 1/2] rust: Kconfig: Factor out whether PL011 is Rust or C Date: Wed, 19 Mar 2025 19:31:09 +0000 Message-ID: <20250319193110.1565578-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250319193110.1565578-1-peter.maydell@linaro.org> References: <20250319193110.1565578-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Currently every board that uses the PL011 duplicates the logic that selects the Rust implementation if Rust was enabled and the C implementation if it does not. Factor this out into a separate Kconfig stanza, so that boards can go back to simply doing "select PL011" and get whichever implementation is correct for the build. This fixes a compilation failure if CONFIG_VMAPPLE is enabled in a Rust build, because hw/vmapple/Kconfig didn't have the "pick the Rust PL011 if Rust is enabled" logic in it. Fixes: 59f4d65584bd33 ("hw/vmapple/vmapple: Add vmapple machine type") Reported-by: Tanish Desai Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- hw/arm/Kconfig | 30 ++++++++++-------------------- hw/char/Kconfig | 6 ++++++ hw/char/meson.build | 2 +- 3 files changed, 17 insertions(+), 21 deletions(-) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 15200a2d7e7..a55b44d7bde 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -21,8 +21,7 @@ config ARM_VIRT select PCI_EXPRESS select PCI_EXPRESS_GENERIC_BRIDGE select PFLASH_CFI01 - select PL011 if !HAVE_RUST # UART - select X_PL011_RUST if HAVE_RUST # UART + select PL011 # UART select PL031 # RTC select PL061 # GPIO select GPIO_PWR @@ -75,8 +74,7 @@ config HIGHBANK select AHCI_SYSBUS select ARM_TIMER # sp804 select ARM_V7M - select PL011 if !HAVE_RUST # UART - select X_PL011_RUST if HAVE_RUST # UART + select PL011 # UART select PL022 # SPI select PL031 # RTC select PL061 # GPIO @@ -89,8 +87,7 @@ config INTEGRATOR depends on TCG && ARM select ARM_TIMER select INTEGRATOR_DEBUG - select PL011 if !HAVE_RUST # UART - select X_PL011_RUST if HAVE_RUST # UART + select PL011 # UART select PL031 # RTC select PL041 # audio select PL050 # keyboard/mouse @@ -108,8 +105,7 @@ config MUSCA default y depends on TCG && ARM select ARMSSE - select PL011 if !HAVE_RUST # UART - select X_PL011_RUST if HAVE_RUST # UART + select PL011 # UART select PL031 select SPLIT_IRQ select UNIMP @@ -173,8 +169,7 @@ config REALVIEW select WM8750 # audio codec select LSI_SCSI_PCI select PCI - select PL011 if !HAVE_RUST # UART - select X_PL011_RUST if HAVE_RUST # UART + select PL011 # UART select PL031 # RTC select PL041 # audio codec select PL050 # keyboard/mouse @@ -199,8 +194,7 @@ config SBSA_REF select PCI_EXPRESS select PCI_EXPRESS_GENERIC_BRIDGE select PFLASH_CFI01 - select PL011 if !HAVE_RUST # UART - select X_PL011_RUST if HAVE_RUST # UART + select PL011 # UART select PL031 # RTC select PL061 # GPIO select USB_XHCI_SYSBUS @@ -224,8 +218,7 @@ config STELLARIS select ARM_V7M select CMSDK_APB_WATCHDOG select I2C - select PL011 if !HAVE_RUST # UART - select X_PL011_RUST if HAVE_RUST # UART + select PL011 # UART select PL022 # SPI select PL061 # GPIO select SSD0303 # OLED display @@ -285,8 +278,7 @@ config VEXPRESS select ARM_TIMER # sp804 select LAN9118 select PFLASH_CFI01 - select PL011 if !HAVE_RUST # UART - select X_PL011_RUST if HAVE_RUST # UART + select PL011 # UART select PL041 # audio codec select PL181 # display select REALVIEW @@ -371,8 +363,7 @@ config RASPI default y depends on TCG && ARM select FRAMEBUFFER - select PL011 if !HAVE_RUST # UART - select X_PL011_RUST if HAVE_RUST # UART + select PL011 # UART select SDHCI select USB_DWC2 select BCM2835_SPI @@ -448,8 +439,7 @@ config XLNX_VERSAL select ARM_GIC select CPU_CLUSTER select DEVICE_TREE - select PL011 if !HAVE_RUST # UART - select X_PL011_RUST if HAVE_RUST # UART + select PL011 # UART select CADENCE select VIRTIO_MMIO select UNIMP diff --git a/hw/char/Kconfig b/hw/char/Kconfig index 3f702565e67..9d517f3e287 100644 --- a/hw/char/Kconfig +++ b/hw/char/Kconfig @@ -11,6 +11,12 @@ config PARALLEL config PL011 bool + # The PL011 has both a Rust and a C implementation + select PL011_C if !HAVE_RUST + select X_PL011_RUST if HAVE_RUST + +config PL011_C + bool config SERIAL bool diff --git a/hw/char/meson.build b/hw/char/meson.build index 86ee808cae7..4e439da8b9e 100644 --- a/hw/char/meson.build +++ b/hw/char/meson.build @@ -9,7 +9,7 @@ system_ss.add(when: 'CONFIG_ISA_BUS', if_true: files('parallel-isa.c')) system_ss.add(when: 'CONFIG_ISA_DEBUG', if_true: files('debugcon.c')) system_ss.add(when: 'CONFIG_NRF51_SOC', if_true: files('nrf51_uart.c')) system_ss.add(when: 'CONFIG_PARALLEL', if_true: files('parallel.c')) -system_ss.add(when: 'CONFIG_PL011', if_true: files('pl011.c')) +system_ss.add(when: 'CONFIG_PL011_C', if_true: files('pl011.c')) system_ss.add(when: 'CONFIG_SCLPCONSOLE', if_true: files('sclpconsole.c', 'sclpconsole-lm.c')) system_ss.add(when: 'CONFIG_SERIAL', if_true: files('serial.c')) system_ss.add(when: 'CONFIG_SERIAL_ISA', if_true: files('serial-isa.c'))