From patchwork Tue Mar 11 19:58:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierrick Bouvier X-Patchwork-Id: 872505 Delivered-To: patch@linaro.org Received: by 2002:a5d:64ce:0:b0:38f:210b:807b with SMTP id f14csp1664149wri; Tue, 11 Mar 2025 13:05:19 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWrRQ6Cn95tw4K8cDA30RqvKVXD/P/uH834dgxJAmwwZeyFyqv9WknvhdKsFbP+dT1T7RrKZg==@linaro.org X-Google-Smtp-Source: AGHT+IG4hfaJ1ISbtaP/Xl2wjkRSI9eePv3FvWvBx1TeoH6xjZl4ad1dlKTgIALm6p7fD+2f4GTC X-Received: by 2002:a05:6102:2c18:b0:4b2:9eee:666e with SMTP id ada2fe7eead31-4c34dd6eab4mr3269299137.4.1741723519544; Tue, 11 Mar 2025 13:05:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1741723519; cv=none; d=google.com; s=arc-20240605; b=IocHiTqMGGHV8FsNtgp9q8gyYwK7lO1Wv/xfsyY/voYEYu+WoRoIexhMKtnnFoW6+N UA1cIGQpybeYyW3MEuEc3GotmUqlU8yqyGG+IXQKbvTRJM9twji/wy9oYzFjQXdZDnur p/KOqYO9d1Zxdrx7W8FA0RCxLS8GtHtcx4CSI5n9qx0DrM+4yP6OxwNhiw3rtuFLGz68 hMPOw4UK57TKu+5b3MaMFNcnSUhDaeiwXPcryMyG7MKqM2WASYlTN/Xso+ZVtxZW+SF+ JTP6ooRROQPhwNSzr0FN9mmmquW7MCECio5sfwTaXASuw72g47LDdnikNk68spOfpY7E 8GwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/B5foK4Qy0OvFQVWNYpVAAsAF+tVTKpBxl4Jl8CdPFE=; fh=kEoQpoDeYKqqTWMOc0Iq2e1LPI+fIsbUMg+I80Y/mck=; b=c326TmWAMQVWXaeZVEl7j+2I54ecAECBA1eTe16jlUBIXr5eahseCPPLfo1aF+LIjY jIUvLIwkS/kfbJsOnYrt/i5QbyF6oaD49DLFCa1fFYWQ298IklRcs20mmyQeo8RVCEkx a0UQAbjC+4dGO9vvye8u9+0clTaPLmzX54UY4ITVZ/ND/P8S2guVkPiziBhUJrpbjrJg vOCVRC4HLiFpnLqiwnxOo9ocGv4TOrkqZrJlmooOtmPKAj/gvJNusLRH7wpgoGGGyAoC wRtz4XZFCRUgZb+FqZ7TUOInYPK84iOsJ09MSNigtd/vnF3DjuQm5XI+Gzb7McaVevy7 9C5Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fKUIl7sd; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ada2fe7eead31-4c2fbcf5ce7si2818057137.461.2025.03.11.13.05.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Mar 2025 13:05:19 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fKUIl7sd; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ts5lV-000487-Lp; Tue, 11 Mar 2025 15:59:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ts5kO-00014I-5U for qemu-devel@nongnu.org; Tue, 11 Mar 2025 15:58:41 -0400 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ts5kF-0000A5-EF for qemu-devel@nongnu.org; Tue, 11 Mar 2025 15:58:36 -0400 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-22185cddbffso3407015ad.1 for ; Tue, 11 Mar 2025 12:58:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741723108; x=1742327908; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/B5foK4Qy0OvFQVWNYpVAAsAF+tVTKpBxl4Jl8CdPFE=; b=fKUIl7sdE0EUMvdS4qpkgpG/tORRIIDbtwWqSt3ScaCVPUgLkZyIIAIjzoxgbFuY7O KFR/r0LpRJPoFYW9S+xTHbYLBkZVQFbio/BzmXej2kylrieUiVactUFgl6Fc7zr074YS UaTMSHG3irEUzmtrsCcZqrIlwwWVLPkMCM+dDV04CuYte2Tpz/6r9XmvG3FtGoikCGPR Y78g68GXBuQxKdLAVhBn4dIH4W4mZodV7Ap+iGCMlXj/aVJYJE+MKND6isBCv2FbU8ST ycb3Q49SIKQEIVCe85DPwiwQ0V5OHBtNZFocp+ALRrMyspsSIORgX27qDhpTgSCKUe6F gYKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741723108; x=1742327908; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/B5foK4Qy0OvFQVWNYpVAAsAF+tVTKpBxl4Jl8CdPFE=; b=qkfTcL7BAbxYbDAsxonD/15psOaY+uA1I7sHboxFrkxsaekungdIlLwAsWRBzQvVkU dmumj/vWjv4haboxR1fu7BH/IcR8NdPV8u5RWKdn+DpivA92GWPoXkKwUSFWJyJLCge2 B15TQfeAbA8ZWOiOLEH9/c7/PLZ0XMHTOstDxj5d6Jo4B9m4UppcKuHkZZdVnuLE2RFk go725n90a0QX0Jb2RVLV8TzQL77TfH2B57DZG0Xs5IbTw0FE9HgisA8E9PRpZyN/5iyw JVC8VC9qOtBUxXDnLXIPRdOyOBDWnK9z0DMullNfSGBWIFaaVHV7A5ehEQTMAGugUcZH 4Xig== X-Gm-Message-State: AOJu0Yxb7mFvP6XD1byIghoL24z3iAKMXEbTCOWcrOB58u0BIGAcjZcj t+XzuFH8fhfQ0C2pBx0QF2tW2+wmmV1mwoBIasenQsqPR3C3jDrItEk6CeJ8+fN/ZtmODP+tSxH T/Sc= X-Gm-Gg: ASbGnctL5ZULAXS8hB1T9Wc37Ko/8GZcSZHmuolcDzdvgTGsva35EYrmrmoWncFSnyZ Z66x2MkhhFlnQfbpK2gqa4uE2sXUYflKUYI3JJi9s3rgQ18tOwLcjazHM1FrOdBKpXsFjeViwml h3hnJUM36ehRvMkDKDcwP0Q6H/oe67Q5TKCabLwyoTvsbJMC/41TcxqZGuRyiVqQKxNTs0Wmjmy DzlxdZqDs/dJryBCc+J7Hoo9wfTpQysP0XHMWv3BuRMDbf0fRsMNn1ZL66brVjgcZSs1C4Jhf82 IekF/0nVwEGrIO8s9LW7mTYSHt0yYx6hYx4iilFfZb7Q X-Received: by 2002:a05:6a00:638b:b0:732:57d3:f004 with SMTP id d2e1a72fcca58-736ec5f1748mr5532672b3a.6.1741723107984; Tue, 11 Mar 2025 12:58:27 -0700 (PDT) Received: from pc.. ([38.39.164.180]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-736a6e5c13asm9646981b3a.157.2025.03.11.12.58.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Mar 2025 12:58:27 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: David Hildenbrand , Stefano Stabellini , "Edgar E. Iglesias" , Anthony PERARD , xen-devel@lists.xenproject.org, Nicholas Piggin , Richard Henderson , Weiwei Li , kvm@vger.kernel.org, Palmer Dabbelt , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Paul Durrant , Liu Zhiwei , Daniel Henrique Barboza , manos.pitsidianakis@linaro.org, Peter Xu , Harsh Prateek Bora , Alistair Francis , alex.bennee@linaro.org, Yoshinori Sato , qemu-riscv@nongnu.org, qemu-ppc@nongnu.org, Pierrick Bouvier Subject: [PATCH v3 15/17] include/exec/memory: move devend functions to memory-internal.h Date: Tue, 11 Mar 2025 12:58:01 -0700 Message-Id: <20250311195803.4115788-16-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250311195803.4115788-1-pierrick.bouvier@linaro.org> References: <20250311195803.4115788-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pl1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Only system/physmem.c and system/memory.c use those functions, so we can move then to internal header. Signed-off-by: Pierrick Bouvier --- include/exec/memory-internal.h | 19 +++++++++++++++++++ include/exec/memory.h | 18 ------------------ 2 files changed, 19 insertions(+), 18 deletions(-) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index b729f3b25ad..c75178a3d6b 100644 --- a/include/exec/memory-internal.h +++ b/include/exec/memory-internal.h @@ -43,5 +43,24 @@ void address_space_dispatch_free(AddressSpaceDispatch *d); void mtree_print_dispatch(struct AddressSpaceDispatch *d, MemoryRegion *root); + +/* returns true if end is big endian. */ +static inline bool devend_big_endian(enum device_endian end) +{ + QEMU_BUILD_BUG_ON(DEVICE_HOST_ENDIAN != DEVICE_LITTLE_ENDIAN && + DEVICE_HOST_ENDIAN != DEVICE_BIG_ENDIAN); + + if (end == DEVICE_NATIVE_ENDIAN) { + return target_words_bigendian(); + } + return end == DEVICE_BIG_ENDIAN; +} + +/* enum device_endian to MemOp. */ +static inline MemOp devend_memop(enum device_endian end) +{ + return devend_big_endian(end) ? MO_BE : MO_LE; +} + #endif #endif diff --git a/include/exec/memory.h b/include/exec/memory.h index 70177304a92..a3bb0542bf6 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -3138,24 +3138,6 @@ address_space_write_cached(MemoryRegionCache *cache, hwaddr addr, MemTxResult address_space_set(AddressSpace *as, hwaddr addr, uint8_t c, hwaddr len, MemTxAttrs attrs); -/* returns true if end is big endian. */ -static inline bool devend_big_endian(enum device_endian end) -{ - QEMU_BUILD_BUG_ON(DEVICE_HOST_ENDIAN != DEVICE_LITTLE_ENDIAN && - DEVICE_HOST_ENDIAN != DEVICE_BIG_ENDIAN); - - if (end == DEVICE_NATIVE_ENDIAN) { - return target_words_bigendian(); - } - return end == DEVICE_BIG_ENDIAN; -} - -/* enum device_endian to MemOp. */ -static inline MemOp devend_memop(enum device_endian end) -{ - return devend_big_endian(end) ? MO_BE : MO_LE; -} - /* * Inhibit technologies that require discarding of pages in RAM blocks, e.g., * to manage the actual amount of memory consumed by the VM (then, the memory