From patchwork Sat Feb 1 16:39:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 861276 Delivered-To: patch@linaro.org Received: by 2002:adf:fb05:0:b0:385:e875:8a9e with SMTP id c5csp1264632wrr; Sat, 1 Feb 2025 08:48:37 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCW/QTJ9UHfEcdgOFls4/Fy+Iyvw31VeUeQ9CYZ+cdw9d3bHr00ev5ZoC0LROeKdhKHawckVcA==@linaro.org X-Google-Smtp-Source: AGHT+IEJOgMblkzItlea9FQppdNzajERoR7E4eZUlmre/tME9JH+SVaNLB4gPC1d9P32PJ5fTdzm X-Received: by 2002:a05:622a:5a11:b0:46c:8336:ae1 with SMTP id d75a77b69052e-46fd0b94e4emr221551951cf.51.1738428516986; Sat, 01 Feb 2025 08:48:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1738428516; cv=none; d=google.com; s=arc-20240605; b=DLzzR5sL9rETMUfEl/48s+OaCcvkGleh9mFDTfdEpn4ggy+RmmHDhRtECJWKj4PQX0 WUksxLVt2Yyg4UEm2opOkRogkAzRCbU0ZARCDfoYcL+CZcasvmlhJSJ04X5Sk46A7mbW 4NALq41FeaGVb+R8YYRGL6SPDhX4WlUInt/wLyuA6id9j31FpGNhrY5yDbhjoajU4HC8 Bf/iuTo7VDMNThktPvH+K0bId4yjI7TCUhA9UiIEB1cpRruTTVBYvBdxo6B+zKT1jiWo h4uECioyZ/Q7JdeARPJ8Sfjrinwz36zgG3ihTItEsPYt/9Co1+1L905KMKu+Hmmsc5dS Lrkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=ltVozOB1txcRK3IvpG6N/vre3VyLEVZMby7Yj63zzG4=; fh=/tUAbMZib2nxAlZRUGN4UxzRTgzBME9ADk0XhPn3kyQ=; b=FL4iv555mm9dTXyFHORvOfosAGqxI3OB8Y65jNCTMzmrFMBW4o72/dw2hgJpDNiNJy rPy59QKRGo1OvehZ4fJB+ltdAeiq6sjkGSQyb3fz1s8SH81E5N/q6EPIwn6TVrlWMzqI hFDQUp27bCqmiE0cUN7mfRvPK2PAeft9ZGeJjseZukj8NJiqPH/Q7zbDHlpDGhI/X7z/ gM7mtcf7O0scBucDufFfO8Lcmq6bwWP/jD28hBElhhpt4l8XjDnphAOnrotB8o+FR9Re UoM5iG5JrFbO2egusQyBc7gxQN2/DIs/6KB0NLPE1x9FIuInxNEJNM2Xs7loS6PsuYJ6 kS3g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Vepi+5Gl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-46fdf0aac87si62599741cf.7.2025.02.01.08.48.36 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 01 Feb 2025 08:48:36 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Vepi+5Gl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1teGYO-0006fL-N9; Sat, 01 Feb 2025 11:41:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1teGYL-0006ag-R5 for qemu-devel@nongnu.org; Sat, 01 Feb 2025 11:41:05 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1teGYJ-0001Dj-Px for qemu-devel@nongnu.org; Sat, 01 Feb 2025 11:41:05 -0500 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4363ae65100so35343965e9.0 for ; Sat, 01 Feb 2025 08:41:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738428062; x=1739032862; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ltVozOB1txcRK3IvpG6N/vre3VyLEVZMby7Yj63zzG4=; b=Vepi+5GlxyOXxyEi+L7kofhN/MyxsSqHMk21wS5sTXahNS/KCaWdYxVKW+5uLcTk6R GIUiQi81t/QZherrKtjOVCcFbrDitEcEDZlMd0G8Ldk7X6mu2hCeiUdv48pzIxBKummO OAcIF3ab0gPp4ZL1Af16XOizAO9J8JoQUjD4UvhFMp6ocAmPdGJfF3X4kCLWD9rgZoe6 YWxWlkVYzqZXe41RodfyVW1zDZBijjVDdSxAVWIyrUop76eO2zITawAresD9hXiKn5OT VfMMrh8pUr89c/yHGBlG/NGx8VHHOaj1pcRteRm9rcQjy53vTtc/A0IkMHpc1s3Vq30x lnKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738428062; x=1739032862; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ltVozOB1txcRK3IvpG6N/vre3VyLEVZMby7Yj63zzG4=; b=g+GK+iwaUIvSEliZmx0CcKMM0/AajQrooD83YZJJqbhbY7SU0zbsI7D8IggWsZtVez VxS1vLFtjGZ221pFnid3OGlgk2xt15mRBururqjdg0Ym9W3Jzdofe29wDZFP/kqNan5R 356dMZayrbX7poW/FfmzsrjRhAjW7ZXTjH74h3ltdfJgT5suZhEza4kO7CsMMYxs5mcE 4Fa75IE4uj3HOqQLxrxA9er9w5/rnz9Hnl2oS6BPCZJu7RCqMOamVj6gct+JprUmpCP2 xf/gyl/RtUpy4XQ8MnYuYzZUq6RXR/8dejq4QLzdSzvQKUnaUJG1KEg59lxw1k9FoOt6 Hi8w== X-Forwarded-Encrypted: i=1; AJvYcCWOR5GpfIW9y8g37zNxFmkS3Afu07Faw9DNlWzN/fTCYyVzDWknTDuMCPneFX0t0YdZbXRROJ7FyGTV@nongnu.org X-Gm-Message-State: AOJu0YxDHGJfbK0H2+JqIQRyEBbRT9RQ7xsWOaAGp10FeZ0JyRcUIeTL A+eRifikXKFYMwZUZ/s0oS+9cB/0thEcDNF/3hfGSCi06+edBRYHusmM/zS8f2g= X-Gm-Gg: ASbGnctqjWEyLiiLj4FfrtMsP6wi/s8CP9ywdT0a1cPGZOzp9vR5QpvKpoNVU2HZuDR IcZ1/CABa210FCJdioLTUEvyU6/EANnHNoVJ5P8gd8mTWizMCi/0qVEld+q5+IqvaiCFGLPh7VO quR3OaVUsUUVCN5OiQ/Dn2Iyy2MMc2FzOyAkE1ybd1kHIs1HyZFu3SoZcO2ESL0JXb3NGSPuM/i kpmzXXFutiINSGoxWojm59OWvGiDyaR+3AsNTYR+B4VPJBw8WSKw4lv8zYadVS3YSrOJywt8ifQ F3HeDMmbw4ix77oPXCmB X-Received: by 2002:a05:600c:4d26:b0:434:f131:1e71 with SMTP id 5b1f17b1804b1-438e01febebmr148973575e9.8.1738428062401; Sat, 01 Feb 2025 08:41:02 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438dcc81d74sm127401525e9.37.2025.02.01.08.41.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Feb 2025 08:41:01 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH v2 35/69] target/arm: Handle FPCR.AH in SVE FABS Date: Sat, 1 Feb 2025 16:39:38 +0000 Message-Id: <20250201164012.1660228-36-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250201164012.1660228-1-peter.maydell@linaro.org> References: <20250201164012.1660228-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Make SVE FABS honour the FPCR.AH "don't negate the sign of a NaN" semantics. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/tcg/helper-sve.h | 4 ++++ target/arm/tcg/sve_helper.c | 8 ++++++++ target/arm/tcg/translate-sve.c | 7 ++++++- 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/target/arm/tcg/helper-sve.h b/target/arm/tcg/helper-sve.h index 867a6d96e04..ff12f650c87 100644 --- a/target/arm/tcg/helper-sve.h +++ b/target/arm/tcg/helper-sve.h @@ -541,6 +541,10 @@ DEF_HELPER_FLAGS_4(sve_fabs_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) DEF_HELPER_FLAGS_4(sve_fabs_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) DEF_HELPER_FLAGS_4(sve_fabs_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) +DEF_HELPER_FLAGS_4(sve_ah_fabs_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) +DEF_HELPER_FLAGS_4(sve_ah_fabs_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) +DEF_HELPER_FLAGS_4(sve_ah_fabs_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) + DEF_HELPER_FLAGS_4(sve_fneg_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) DEF_HELPER_FLAGS_4(sve_fneg_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) DEF_HELPER_FLAGS_4(sve_fneg_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) diff --git a/target/arm/tcg/sve_helper.c b/target/arm/tcg/sve_helper.c index 976f3be44e0..5ce7d736475 100644 --- a/target/arm/tcg/sve_helper.c +++ b/target/arm/tcg/sve_helper.c @@ -879,6 +879,14 @@ DO_ZPZ(sve_fabs_h, uint16_t, H1_2, DO_FABS) DO_ZPZ(sve_fabs_s, uint32_t, H1_4, DO_FABS) DO_ZPZ_D(sve_fabs_d, uint64_t, DO_FABS) +#define DO_AH_FABS_H(N) (float16_is_any_nan(N) ? (N) : DO_FABS(N)) +#define DO_AH_FABS_S(N) (float32_is_any_nan(N) ? (N) : DO_FABS(N)) +#define DO_AH_FABS_D(N) (float64_is_any_nan(N) ? (N) : DO_FABS(N)) + +DO_ZPZ(sve_ah_fabs_h, uint16_t, H1_2, DO_AH_FABS_H) +DO_ZPZ(sve_ah_fabs_s, uint32_t, H1_4, DO_AH_FABS_S) +DO_ZPZ_D(sve_ah_fabs_d, uint64_t, DO_AH_FABS_D) + #define DO_FNEG(N) (N ^ ~((__typeof(N))-1 >> 1)) DO_ZPZ(sve_fneg_h, uint16_t, H1_2, DO_FNEG) diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c index 4d5de2004f0..646d0171d99 100644 --- a/target/arm/tcg/translate-sve.c +++ b/target/arm/tcg/translate-sve.c @@ -783,7 +783,12 @@ static gen_helper_gvec_3 * const fabs_fns[4] = { NULL, gen_helper_sve_fabs_h, gen_helper_sve_fabs_s, gen_helper_sve_fabs_d, }; -TRANS_FEAT(FABS, aa64_sve, gen_gvec_ool_arg_zpz, fabs_fns[a->esz], a, 0) +static gen_helper_gvec_3 * const fabs_ah_fns[4] = { + NULL, gen_helper_sve_ah_fabs_h, + gen_helper_sve_ah_fabs_s, gen_helper_sve_ah_fabs_d, +}; +TRANS_FEAT(FABS, aa64_sve, gen_gvec_ool_arg_zpz, + s->fpcr_ah ? fabs_ah_fns[a->esz] : fabs_fns[a->esz], a, 0) static gen_helper_gvec_3 * const fneg_fns[4] = { NULL, gen_helper_sve_fneg_h,