From patchwork Sat Feb 1 16:39:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 861253 Delivered-To: patch@linaro.org Received: by 2002:adf:fb05:0:b0:385:e875:8a9e with SMTP id c5csp1263569wrr; Sat, 1 Feb 2025 08:45:23 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWxro5ftP+88/Qq8aFpWNdYZAznUFRc/yH9fUyw992LjDT4keZDAx/n7gv2w1/W9wm7c9XHgA==@linaro.org X-Google-Smtp-Source: AGHT+IHPyOYEBHxyjr1DkKK8NauIStHVv05g3eHx/L2DAVjamg5jk7AfqxjLcDPIwCaaA6xT050p X-Received: by 2002:a05:620a:40c1:b0:7b6:d97a:2608 with SMTP id af79cd13be357-7bffcce8cb0mr2148094685a.17.1738428323524; Sat, 01 Feb 2025 08:45:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1738428323; cv=none; d=google.com; s=arc-20240605; b=PCOx+FHhGxPuj2xbcXKMVHY6v6Enc+ccw6ljC29E8QEaO8Jd0YIEwY9LPopMzZ833a gs6AA7GPJwmGD8LZmcANUQ4eC3N3rdNnB8RpH9gf4zWACbhRrcTZrkNYAdqnwhfeol7M RA2X5qP8WV3VuMbSpZ/Tv7d81OWOPTcF724sR+K2XU+BVBgv3YzPUtY3wq1iJx+uxrV/ jpiflJQMWhyWCrdrVN0GUhPZlHK9dMzlL8fk6hHUQ3j6JMTVgP5NhYQjaFASIiCGhZck 2X8OyKl69cuFE8LcV7MN4NKUPe8cvzveAM0ItOa3UUgl2wo0xzJGYMvblSZknQ+odtxD OVWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=vpMSdd/6TkdfCRr5FCGHe6DC8lmbsXPDu8N06iR71b8=; fh=WOdwHk511y482Gs9Ihzmu6AijRxoI8a67d/qjAr+s8Q=; b=b5wEHJFMZvuwfVUSYUZCkBZ3ktA4XU+p/hig56jY1bMGSUjar03VzoR6QMVP3Jmfn8 7JuDhDmMbW1tyKb0+r+wetALvKdatY9/3PG/0aCKVn6OcgwOy88duDIjQDIjWAZ0AFzd HhJtIPpqLF/+nSryAaL4QfZqNcn+isd4aj6bvS5VUItbLRFBha1NGso1n8BVw6jhwjt4 HQSNPFirUX+fpsInB/KuecwYLNweo41EHf+Vc8+DHugDaKgHj0jRdeOHnesl+d7xZTXE rsYyZBY1rxPCKDu8VJNrmrFVkcRfYMad80Pbm/uS+ZpaYYb2hXIt92artv6m1L4UtfDF mKow==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=W+fnfKXA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7c00a9043e1si593445285a.242.2025.02.01.08.45.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 01 Feb 2025 08:45:23 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=W+fnfKXA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1teGYD-0006L9-Ar; Sat, 01 Feb 2025 11:40:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1teGYB-0006J8-3K for qemu-devel@nongnu.org; Sat, 01 Feb 2025 11:40:55 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1teGY9-0001Aw-Bb for qemu-devel@nongnu.org; Sat, 01 Feb 2025 11:40:54 -0500 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-38a8b35e168so1825828f8f.1 for ; Sat, 01 Feb 2025 08:40:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738428052; x=1739032852; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=vpMSdd/6TkdfCRr5FCGHe6DC8lmbsXPDu8N06iR71b8=; b=W+fnfKXAHxNd11GVJe8XfgbUnp0j6bMQ5X69kNssREYBq9X8IlDtRbdUiuxiW+ZZ2K S08dJXBaE9VxooHwswqQncH2RzbqzTQ0wZFv/cmWgU5Zmrgo1A/odGnSNS0+o4LDJ1C0 u1fQWFueapgf3J8CtUigXuo0qAbo0FMrIHjAkch8AQNbv4P/yNvrjOydlwAZrZw7dcwG C6x/iYFzkCYZinWQGr8GUbro8rBr3m/NLDdv3QfErPdcMuj1Lqkd97+NEfFEvv0ba7r5 0wYTxgB9M7OZRrVV0ukYGfIRsWZFtQeS/vv8bpLS9YUKxp1Mv59zhn2gYFrc9tI5ZnDP nJEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738428052; x=1739032852; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vpMSdd/6TkdfCRr5FCGHe6DC8lmbsXPDu8N06iR71b8=; b=gsmygBeUs1uQzuQs+G8xlKxR7CG3IuJPsGjXLDgZVCWmeOQyxm6QsAiA9iy5RiMtm7 5dVfJkBJKpbB6ZYzl91/6RzhE2m3lIRsy80/zPN91LCQyZ+NH5GgPCE+Hk1zu3xmsjGX VnndUIW8hcGrbbheWEmGYNmTuqPrVq5WVA48nmikPfA9VSTNO2fOGErE2PMAzrrvb3rj TnhS4uFG3TTkZjz8ZwXVQRtWJrDq0rshKxtTQNZiG7xl1uazLz0Y55DDg4OmBZ5gTGLv HWaFGChU2Jx0agPH97KqI99yP0n7M6w8wYEdfjPGFKAAHdqXFcTGddbyY46n/4e40MTi 95Wg== X-Forwarded-Encrypted: i=1; AJvYcCXisx7DVHt4Jbwqy4Nef3wheJpaU96faT9/dTco/e7+erUjWvBfnYBVOuLzn43dxb+v76J8ceu9dvKg@nongnu.org X-Gm-Message-State: AOJu0YzON6eQZXKkiqdxTIoeujsBxCerXYGlnRUvsz6nUoW9slQ4DhdO 4ut9ZMhcqC5TE7QNWfRAFn9LwooN7/zy+nkh7Qtj3ky8vhgeWon9/rabkD3Ie8g= X-Gm-Gg: ASbGncsdi8FVl6GKb2/Sef9ESuGU+NVSxulE2JpJEMhSj7TDUC+I3gCNP/yBjAk2YKF CLG11ohMpCE4fIiyWpi76Z2yNmh8VZPd6CcHx7CtySECo9qX3RjLs3kCPQYXY2ulCGmPF9HRRIX XoqW1sljelIZwo49CXdoaWZwOZ4x5tyfoktls6o1t8M3KEDFev4IRKUtiLzOa3s0AWWXUdcroHZ KfbKZlIVqG21AFGJo3oZHZLID9ZvUGVMpDJKWV+yEdIXuaVFo7BGOItVekcbvHSVMHHnUlaKKeG C0kLVTknMxgUAhi6RC+t X-Received: by 2002:a5d:6d84:0:b0:386:3672:73e7 with SMTP id ffacd0b85a97d-38c60f149e9mr5800661f8f.9.1738428051902; Sat, 01 Feb 2025 08:40:51 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438dcc81d74sm127401525e9.37.2025.02.01.08.40.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Feb 2025 08:40:51 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH v2 27/69] target/arm: Implement FPCR.AH semantics for FMINP and FMAXP Date: Sat, 1 Feb 2025 16:39:30 +0000 Message-Id: <20250201164012.1660228-28-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250201164012.1660228-1-peter.maydell@linaro.org> References: <20250201164012.1660228-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Implement the FPCR.AH semantics for the pairwise floating point minimum/maximum insns FMINP and FMAXP. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/tcg/helper-sve.h | 14 ++++++++++++++ target/arm/tcg/translate-a64.c | 25 +++++++++++++++++++++---- target/arm/tcg/vec_helper.c | 10 ++++++++++ 3 files changed, 45 insertions(+), 4 deletions(-) diff --git a/target/arm/tcg/helper-sve.h b/target/arm/tcg/helper-sve.h index f1b4606f763..8349752e99b 100644 --- a/target/arm/tcg/helper-sve.h +++ b/target/arm/tcg/helper-sve.h @@ -986,6 +986,20 @@ DEF_HELPER_FLAGS_5(gvec_ah_fmin_s, TCG_CALL_NO_RWG, DEF_HELPER_FLAGS_5(gvec_ah_fmin_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32) +DEF_HELPER_FLAGS_5(gvec_ah_fmaxp_h, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, fpst, i32) +DEF_HELPER_FLAGS_5(gvec_ah_fmaxp_s, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, fpst, i32) +DEF_HELPER_FLAGS_5(gvec_ah_fmaxp_d, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, fpst, i32) + +DEF_HELPER_FLAGS_5(gvec_ah_fminp_h, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, fpst, i32) +DEF_HELPER_FLAGS_5(gvec_ah_fminp_s, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, fpst, i32) +DEF_HELPER_FLAGS_5(gvec_ah_fminp_d, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, fpst, i32) + DEF_HELPER_FLAGS_4(sve_faddv_h, TCG_CALL_NO_RWG, i64, ptr, ptr, fpst, i32) DEF_HELPER_FLAGS_4(sve_faddv_s, TCG_CALL_NO_RWG, diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c index 80a6562ed51..7af727b606d 100644 --- a/target/arm/tcg/translate-a64.c +++ b/target/arm/tcg/translate-a64.c @@ -5776,14 +5776,24 @@ static gen_helper_gvec_3_ptr * const f_vector_fmaxp[3] = { gen_helper_gvec_fmaxp_s, gen_helper_gvec_fmaxp_d, }; -TRANS(FMAXP_v, do_fp3_vector, a, 0, f_vector_fmaxp) +static gen_helper_gvec_3_ptr * const f_vector_ah_fmaxp[3] = { + gen_helper_gvec_ah_fmaxp_h, + gen_helper_gvec_ah_fmaxp_s, + gen_helper_gvec_ah_fmaxp_d, +}; +TRANS(FMAXP_v, do_fp3_vector_2fn, a, 0, f_vector_fmaxp, f_vector_ah_fmaxp) static gen_helper_gvec_3_ptr * const f_vector_fminp[3] = { gen_helper_gvec_fminp_h, gen_helper_gvec_fminp_s, gen_helper_gvec_fminp_d, }; -TRANS(FMINP_v, do_fp3_vector, a, 0, f_vector_fminp) +static gen_helper_gvec_3_ptr * const f_vector_ah_fminp[3] = { + gen_helper_gvec_ah_fminp_h, + gen_helper_gvec_ah_fminp_s, + gen_helper_gvec_ah_fminp_d, +}; +TRANS(FMINP_v, do_fp3_vector_2fn, a, 0, f_vector_fminp, f_vector_ah_fminp) static gen_helper_gvec_3_ptr * const f_vector_fmaxnmp[3] = { gen_helper_gvec_fmaxnump_h, @@ -6775,9 +6785,16 @@ static bool do_fp3_scalar_pair(DisasContext *s, arg_rr_e *a, const FPScalar *f) return true; } +static bool do_fp3_scalar_pair_2fn(DisasContext *s, arg_rr_e *a, + const FPScalar *fnormal, + const FPScalar *fah) +{ + return do_fp3_scalar_pair(s, a, s->fpcr_ah ? fah : fnormal); +} + TRANS(FADDP_s, do_fp3_scalar_pair, a, &f_scalar_fadd) -TRANS(FMAXP_s, do_fp3_scalar_pair, a, &f_scalar_fmax) -TRANS(FMINP_s, do_fp3_scalar_pair, a, &f_scalar_fmin) +TRANS(FMAXP_s, do_fp3_scalar_pair_2fn, a, &f_scalar_fmax, &f_scalar_fmax_ah) +TRANS(FMINP_s, do_fp3_scalar_pair_2fn, a, &f_scalar_fmin, &f_scalar_fmin_ah) TRANS(FMAXNMP_s, do_fp3_scalar_pair, a, &f_scalar_fmaxnm) TRANS(FMINNMP_s, do_fp3_scalar_pair, a, &f_scalar_fminnm) diff --git a/target/arm/tcg/vec_helper.c b/target/arm/tcg/vec_helper.c index 9f77aa6b919..61e6e54570c 100644 --- a/target/arm/tcg/vec_helper.c +++ b/target/arm/tcg/vec_helper.c @@ -2444,6 +2444,16 @@ DO_3OP_PAIR(gvec_fminnump_h, float16_minnum, float16, H2) DO_3OP_PAIR(gvec_fminnump_s, float32_minnum, float32, H4) DO_3OP_PAIR(gvec_fminnump_d, float64_minnum, float64, ) +#ifdef TARGET_AARCH64 +DO_3OP_PAIR(gvec_ah_fmaxp_h, helper_vfp_ah_maxh, float16, H2) +DO_3OP_PAIR(gvec_ah_fmaxp_s, helper_vfp_ah_maxs, float32, H4) +DO_3OP_PAIR(gvec_ah_fmaxp_d, helper_vfp_ah_maxd, float64, ) + +DO_3OP_PAIR(gvec_ah_fminp_h, helper_vfp_ah_minh, float16, H2) +DO_3OP_PAIR(gvec_ah_fminp_s, helper_vfp_ah_mins, float32, H4) +DO_3OP_PAIR(gvec_ah_fminp_d, helper_vfp_ah_mind, float64, ) +#endif + #undef DO_3OP_PAIR #define DO_3OP_PAIR(NAME, FUNC, TYPE, H) \