From patchwork Fri Jan 31 21:05:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 861037 Delivered-To: patch@linaro.org Received: by 2002:adf:fb05:0:b0:385:e875:8a9e with SMTP id c5csp930376wrr; Fri, 31 Jan 2025 13:10:24 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUh8QuS3yQWpZ+3WkeJe3l/5DmnstVPcCqTmDfahnjVvmncZaGiv2fRyavgwlGvNGSMHK5ouw==@linaro.org X-Google-Smtp-Source: AGHT+IG9qGNf1/FHInhaEOAQXs+ED327hJNcbat/TGtM9xmPUdE4iSK6vL8FIbXOwrJKegEMI6V0 X-Received: by 2002:a05:6214:29e3:b0:6d8:d5f6:8c75 with SMTP id 6a1803df08f44-6e243bb8d4dmr127260366d6.12.1738357824546; Fri, 31 Jan 2025 13:10:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1738357824; cv=none; d=google.com; s=arc-20240605; b=CuVZbrWqWNIY8h3tv+QgDfPv1jIvxCv6Mq64YcwlvLX6ADCB8owMZ26ff1JgG/MIvh QRk2MtrXDd2ePTn+hX+GcjLBTwGLGJ+o7ejPLl7Y4JG+9YIBPGEyttjlKQAXxUdG+Nn7 vFNKg4h9hKvUNYKdwv3L1qxbEqV/yX4WeZJiTefrV2/HFtrY+uCZMl1h9ENo1jdwJgkY s395DaFYT0SZJYtdc/fVVv2Enu8ekxcVK9kdkpJRlt4nurSkbCv1EHOXvtMsQmgEEtGK REcDcc4ZdeDbMWKyiNABXjEf20DLMUoKg3UJCZBsOaXfObuLM2+9O/tc+80MEhWqPobo L3Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=8oFzU0KJNpu3qZQuyVEhKtfFAAIRsXmhtD1aPMM/s0s=; fh=hrttvYDQ/RHeq9ZPl6fx8GLJN/+EeLQ90pmG86Kf6FU=; b=NPCdy+/O5wLgb/46ONhq34lsXirFkKCtdDd+eOvgAAgv3ZA2cLUaK0BKvQlCeG+6v6 md+VAG1x9M0ple9zr3EpjCStmIIcq3+OqEtYgL2wO8wBIEpamhLJn+uRFlqNfCTNjHB0 9ndlFG0o8adGiEj2F0ReLod+L/UT4cKiokhougTnwszG6OTz9OsgGBU9tvqYes1B2ZV7 JYCgqTDrE1s8UaenBs/GHeXZWDOHYK53vmOx4zNGOSe2n9cqn7FXAoTB7k2fy7JKnRgr XEUAAYTuQb9tQ8MrMs5RAaK+6S3JSWxP4XjljbYUQl1svOn6Kb6Ili5+v81rYe0CxINK 1GWw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=s1isZdHw; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6e25497273esi45540396d6.208.2025.01.31.13.10.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 31 Jan 2025 13:10:24 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=s1isZdHw; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tdyFU-0005gn-H7; Fri, 31 Jan 2025 16:08:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tdyFJ-0004GY-7c for qemu-devel@nongnu.org; Fri, 31 Jan 2025 16:08:14 -0500 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tdyFH-00081l-I7 for qemu-devel@nongnu.org; Fri, 31 Jan 2025 16:08:13 -0500 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-3862b40a6e0so1588553f8f.0 for ; Fri, 31 Jan 2025 13:08:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738357689; x=1738962489; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8oFzU0KJNpu3qZQuyVEhKtfFAAIRsXmhtD1aPMM/s0s=; b=s1isZdHwFPbBDVMdH/KjesIftd6tKDIGafZVp4jtESUZnsRE6uASXAyf2NkL3cSd50 ionYtTgfCRoR8bC2x50kBtNnYMu+jaP0f/JfgVbOuANVZKvlVGKB1nVEtPdDXZdTTtvm 9Oi2OAsYzSKAtelQ8pQR3IMp/xre+7S4yd/10K6wtqztCHnWFbPTgdaEyeKSrGumoMrd KC7iBoaKwvKY1CziQDIxG1mFW13Qbr2+WX8HOEyYbBNagUfX+jjGVIeoIXpiVQasIN0n T7HcrUuX+tmoOBy4BWXs3vuOR+ttBTMaCX2KymfXXdsBXyyYsSqtTRNQOpPjq/WdPGeG brnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738357689; x=1738962489; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8oFzU0KJNpu3qZQuyVEhKtfFAAIRsXmhtD1aPMM/s0s=; b=jt8dsrDcMUWxmbWQkqSdWCGqynMDSrMnLhI6HMKDazHR8e7JeXUWRriVCR9qrffYLD sdBnxmAIxdZ6xaYvqC6CwaCaRF+CYo91O7lB69c/WVoPtkFcOvrKfIEv1I/843VHNvEk treGRCe/1hSb0gRfMZ6IaZmKS+/wYmgyFDOorUKgoD82krXQYX2X198dBjnvklVGUuBt xrhiEbc/5Njx+EDErPJLG2xtEL7OxPAx/aqeBykBbbi+crlsUzF4022bchVJr00vwyjl zSX7KkUEN1coAszxOvQRc6cKwskE8tW0Dp8dE4t4Ys+ukznhHPoRQWag/MC9Z37VzPLA qRuw== X-Gm-Message-State: AOJu0YxRuJOay9/8D2Ce/IT+9Ttp5tsc8Iop69ZyZnsHle6GvaLy/6xU h9cckMq5FxOOBO2xwB2UlPBQHy7zeatzz6x5/rIn9plKXOP837VzXllv446ModGOGbw3TdFnj9n LQ9U= X-Gm-Gg: ASbGncsOPIMGE39XNomKPVZdAl8PQrVbvBR3Dl71KY0sQQvLWZSQ17xvCcAfjsgXHlK LTO8CWGVa/yyCQCkjWYiiZFJjZ9ALdsUPyZ/ovUnNvVqKT50CLNkcd8HhnYfzhxACgWMi8dTXPV 8QWS356rMpgL0PyiD8BkXllqvTmRpRIBioICYSxruqA8qgQuxD8sqlI+fkMn95Z/jJVVvKn43e8 JqJ7ZNcMoJJ2grycifYdBCyPLhpKStsIP8v6qpgAIYdY8bgHxhFWiPzhRaWllnNH/la7QOf9Y8/ ptfhG3nyUL4tsn4o4FCikeDuMr32P2w/v2DQaJY0ao8tKcVNc96HNIVNFfCqddYfzw== X-Received: by 2002:a5d:584b:0:b0:38a:8b2c:53ad with SMTP id ffacd0b85a97d-38c51e91b14mr12618716f8f.39.1738357689555; Fri, 31 Jan 2025 13:08:09 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438dcc2ede0sm102340385e9.21.2025.01.31.13.08.08 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 31 Jan 2025 13:08:09 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Peter Maydell , Richard Henderson , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= Subject: [PULL 34/36] hw/sd: Remove unused 'enable' method from SDCardClass Date: Fri, 31 Jan 2025 22:05:17 +0100 Message-ID: <20250131210520.85874-35-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250131210520.85874-1-philmd@linaro.org> References: <20250131210520.85874-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Peter Maydell The SDCardClass has an 'enable' method, but nothing actually invokes it. The underlying implementation is sd_enable(), which is documented in sdcard_legacy.h as something that should not be used and was only present for the benefit of the now-removed nseries boards. Unlike all the other method pointers in SDCardClass, this one doesn't have an sdbus_foo() function wrapper in hw/sd/core.c. Remove the unused method. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20250128104519.3981448-10-peter.maydell@linaro.org> Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sd/sd.h | 1 - hw/sd/sd.c | 1 - 2 files changed, 2 deletions(-) diff --git a/include/hw/sd/sd.h b/include/hw/sd/sd.h index f2458f37b3c..d6bad175131 100644 --- a/include/hw/sd/sd.h +++ b/include/hw/sd/sd.h @@ -119,7 +119,6 @@ struct SDCardClass { void (*set_voltage)(SDState *sd, uint16_t millivolts); uint8_t (*get_dat_lines)(SDState *sd); bool (*get_cmd_line)(SDState *sd); - void (*enable)(SDState *sd, bool enable); bool (*get_inserted)(SDState *sd); bool (*get_readonly)(SDState *sd); void (*set_cid)(SDState *sd); diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 0330d432fd0..f781fd1641d 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -2831,7 +2831,6 @@ static void sdmmc_common_class_init(ObjectClass *klass, void *data) sc->read_byte = sd_read_byte; sc->receive_ready = sd_receive_ready; sc->data_ready = sd_data_ready; - sc->enable = sd_enable; sc->get_inserted = sd_get_inserted; sc->get_readonly = sd_get_readonly; }