From patchwork Thu Jan 30 18:24:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 860885 Delivered-To: patch@linaro.org Received: by 2002:adf:fb05:0:b0:385:e875:8a9e with SMTP id c5csp329089wrr; Thu, 30 Jan 2025 10:26:53 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVnuO0S1W1z1jccUXIdHGxK0aBrky6dhul9w6Rtx0wGTSPZOIbsHloAVT1y/gwhTt7xuD/QRQ==@linaro.org X-Google-Smtp-Source: AGHT+IHs0bviQLQhwM6dGTUZGY6OXyol6kSu8MTsDCqfTKRJ1EFCV2wxwbs4pSbWkiWfA17dtSek X-Received: by 2002:a05:620a:1d0e:b0:7be:6f05:1b2a with SMTP id af79cd13be357-7bffcd9f0b7mr1510309185a.56.1738261613232; Thu, 30 Jan 2025 10:26:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1738261613; cv=none; d=google.com; s=arc-20240605; b=TD5RE4KkWtjd0GIXKImS4AmA+9HL3Fzsw2kqf3aiwk0riJE4n+xBanKHy416WYK/f+ LV2o+pA6sqAvELP79pcaMoPK50FY1Wq0UaBoqoXcg1pxripNNYvVgBKOv8FA9B7za7Il lUa58iXxswmDIkWxTweN6lEELbjyQk7TVivnqX72IWbUJ3ABBUzXQU4XmDGZJTDH0PzY CoR0R9KKAiKkmtymaO8T4ViRF5DSJlf+srkUvm81j6O1b4NBE5VZwyACuEty68c8IWUD x/Y8QZWNu+a2nmbTgWVqhpafq3TT2eM9lnogexqIUFWUeFDvSEcoGRnQDoEaAB2LJXIE a5EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=t2o07b5g0HyyxOGpJQed/+y7o4V48M+fBcZRdRcyuiw=; fh=SthhPtpqdehNGJNgy7ndeFIc3MS4iW7BmkhpFgvGJVQ=; b=B81W0Vzp9Z/Cvt77G933dbhteYbmcIXADOUGMFFrdKpHtXiDoOwcSmH6FPXd+rz5tT 86qyOVVhiyH7XmbV0lp2zt58/RmiFVW3mdQkRdIrbq/RLdZqjmoxzO9p789YdnHBBRzX tkSdo9CJX3TToianAvtcuMfjUUhjZRIQ2+Z+WlF3ErOs5T+t2hTwEDZl4rDmMo2uS2U9 0qeWGFOa+SYU+loQ1jv0yfzVR+sVmpBElY9Rza+iX5vzpbYElhGrnTW525cHsdHYPpH/ nYIr+UCxLnFUCMFLtBTS6qwYlsrw3FvMUXx0qNWpHRWy4YbxR8wdw5RuOD8GHFgbsjWG dhtQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PwILAHdr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7c00a903acbsi212934285a.315.2025.01.30.10.26.53 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Jan 2025 10:26:53 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PwILAHdr; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tdZEl-0001Q1-4Z; Thu, 30 Jan 2025 13:26:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tdZEL-0000kX-GJ for qemu-devel@nongnu.org; Thu, 30 Jan 2025 13:25:33 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tdZEJ-00014j-QO for qemu-devel@nongnu.org; Thu, 30 Jan 2025 13:25:33 -0500 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-3862b40a6e0so785198f8f.0 for ; Thu, 30 Jan 2025 10:25:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738261530; x=1738866330; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t2o07b5g0HyyxOGpJQed/+y7o4V48M+fBcZRdRcyuiw=; b=PwILAHdr1WZj/+x/ejnmhC/tD7zPsERQNUOwSvHjj71pcwdElvf0y4lUKXzzXUPBhP gy4R1rl5sr3Hylt8H8FjfxKMV5vWQvtbP0FMNUBsAWf9PHICxbrr6YzcWc6nmyr4YIUK WSrGkxmah73cJVaRAtCJjOh7UOfOhIT3krE2xtNLMqDKhqwASwvvYKpM/e4hj83RBow0 WKwPBl4Wf/HnvSPfw0eTxLioUwxOp9CFjlUvjh69byKfhlchner4faop/d/JQ/sq1DgT JF3GfySerCQKn9GW3Wpcc7JLzJOtjRIz82c+nC/KWZ9jGzNiGkrzsAIVCjgTWpFvzbJ2 ebxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738261530; x=1738866330; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t2o07b5g0HyyxOGpJQed/+y7o4V48M+fBcZRdRcyuiw=; b=gXikOKBz2e+cYQ5y6SG6ICW/rS7zk2+ZUdPdwYp0ZXEsQNbJhOu+j4CXL5EsAT9C8K IFf6E8Hs0sQRwMmy3p2XyxEa8KkhljcbpZuaZ+Ij0lw+YRD6napGlT7aJGXVxRm/8ANn E/HH6JIg19guzoOIGkjuAX4cv/KFOon2mDu8vOdV93wSjlTbJBf1R+kc9nRIHrn2z+8a KpMhStd6/OPl8QKNa4vN1ualiUtzz8wNdI4sLwfbJ1IbV2tbPCtr/AUx7RhFu0S4f4k/ HhZJk5SX+s8wfPM4Lf2txwDrzUMGAqy6m02EKvUo47Fw3IDPOzmHqV/fRvETxqdCKuaI jjFg== X-Gm-Message-State: AOJu0YzNWkog5ReFyks8XEAfF2xc186DZVoDmGE9p28mtCJ4qIfq3VSY USGv3ewEB2rKHLm8qLcV95gGBLWTRi1XgFQjPn3byd/65/NHqVPLdvnl7/RvftC6SX/2hq1FvYX XYco= X-Gm-Gg: ASbGncsPYy9PY8J6hAM7SeBs1P0QN8KYwffi6K/oGioBtRjh2MwPmfZk4HCkbE7QKHb waL7lez3k+vDWnsbEh3N93yYmC2ePODnFMVjgSfBMES2Rp9j0TZJpFuHM0zmNcFGE3KvKABiqqx unwAvEEg4kzjKaVFFYj7N5i6oIC/UwbyhGBsPLqPJG88AiQjUubg2QRsqfU63uaALKONzZ7QkLX 1gzkQ28Yot3mux3x3YqjfyB82Z6qSfgs9suIShQpYXfRbylcjfx0LJghqpi8FaZpO7243Imywiv w6vFf9W334q6LxBOZSY0d4jaZkirXelSse26rPa1fLTRUMCT0n/tntfk+FWAvb8hVw== X-Received: by 2002:a05:6000:1788:b0:385:ef39:6ce9 with SMTP id ffacd0b85a97d-38c5194c69amr9501640f8f.21.1738261529733; Thu, 30 Jan 2025 10:25:29 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c5c13a0efsm2733042f8f.60.2025.01.30.10.25.25 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 30 Jan 2025 10:25:29 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Edgar E. Iglesias" , Rob Herring , qemu-arm@nongnu.org, Peter Maydell , Alistair Francis , Igor Mitsyanko , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= Subject: [PATCH 1/8] hw/arm/exynos4210: Replace magic 32 by proper 'GIC_INTERNAL' definition Date: Thu, 30 Jan 2025 19:24:34 +0100 Message-ID: <20250130182441.40480-2-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250130182441.40480-1-philmd@linaro.org> References: <20250130182441.40480-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The 32 IRQ lines skipped are the GIC internal ones. Use the GIC_INTERNAL definition for clarity. No logical change. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/exynos4210.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c index dd0edc81d5c..99b05a175d6 100644 --- a/hw/arm/exynos4210.c +++ b/hw/arm/exynos4210.c @@ -393,8 +393,9 @@ static void exynos4210_init_board_irqs(Exynos4210State *s) } } if (irq_id) { + irq_id -= GIC_INTERNAL; qdev_connect_gpio_out(splitter, splitin, - qdev_get_gpio_in(extgicdev, irq_id - 32)); + qdev_get_gpio_in(extgicdev, irq_id)); } } for (; n < EXYNOS4210_MAX_INT_COMBINER_IN_IRQ; n++) { @@ -413,6 +414,7 @@ static void exynos4210_init_board_irqs(Exynos4210State *s) } if (irq_id) { + irq_id -= GIC_INTERNAL; assert(splitcount < EXYNOS4210_NUM_SPLITTERS); splitter = DEVICE(&s->splitter[splitcount]); qdev_prop_set_uint16(splitter, "num-lines", 2); @@ -421,7 +423,7 @@ static void exynos4210_init_board_irqs(Exynos4210State *s) s->irq_table[n] = qdev_get_gpio_in(splitter, 0); qdev_connect_gpio_out(splitter, 0, qdev_get_gpio_in(intcdev, n)); qdev_connect_gpio_out(splitter, 1, - qdev_get_gpio_in(extgicdev, irq_id - 32)); + qdev_get_gpio_in(extgicdev, irq_id)); } else { s->irq_table[n] = qdev_get_gpio_in(intcdev, n); }