From patchwork Tue Jan 28 14:21:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 860409 Delivered-To: patch@linaro.org Received: by 2002:a5d:6b8c:0:b0:385:e875:8a9e with SMTP id n12csp376304wrx; Tue, 28 Jan 2025 06:24:15 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXd4dA81ZT2/2JoBCMY7OrNjZm1KFOH29v6HrGfFyVUpuV0xMOIiXsd8LP7I/5vuYUdGOq6JA==@linaro.org X-Google-Smtp-Source: AGHT+IGYMcnkKrHhalYN36++Dpxo8Z7A1lsqz8VROF/Or4lqlMNu7xEOBt/hLe/NgqGJDvDYJ6ga X-Received: by 2002:ac8:7e90:0:b0:46a:1932:b07f with SMTP id d75a77b69052e-46e12b94a7emr742703031cf.39.1738074255205; Tue, 28 Jan 2025 06:24:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1738074255; cv=none; d=google.com; s=arc-20240605; b=e50qPMKY1OirWZjy59x3PqQffbGps/HLxi0CHZ/x1Bq+UrANHFnOv2+TJYcLwEIMIq Y7N7Rv0maP2on7i33b/TVBKtPSkMrVdK6kSinWz3BPZvCYQzBsobouG40qAWLYRC9Ogw a6370Myi8gtQNb0xj1xW49vI4JBZptuQRkHjE9w6sDjPj73mZXtwCZElHwA5f2bPmaFo bt3pKWWDvjdhDreKQ8SsbjcZjHfB1hwUbwbtp8aKdyS/4+1le1INvngWXJgHQ0yqo9EW S/m/Hjth0GGNSjUnp5eOO7hYwHhDWUzW6KeQinA0K79CXGH1/cO8/YNzIaR3NXEAhAI1 /1YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jN7tNGrfnQkH1jp+7zEAfhWZCNwGy2KakJL6oRXbHIo=; fh=U6T2d4RqSCGJNf6LOIblgdoe4xaHu2Qwae+meUOhpik=; b=C+LZCuF1an81iyURigVLrsii7yScGn++Jv5Tqm+SeeLW5Mk3J/OyQBU0V9Fo6/Lukq v9UEFZm/EpZ0X+KPH+mAGHF1foN8XMmf3AFe5c+zvGqu+fzW6Am3c1Cp6Oot8gSDr9VP TfCDI4QvcfxDXff+/KHi/e8m+XQoCtvtKXNLubpL04GIw8SEdfpU50mq2PsSuRUwS8QG S17j5YV8h/l7vUTVsgzZgQKkeCa+G6qfe6PUtvPwaC5EVFarXCsBJcQYCcDjn8UHRn2o rZaINEW55V9zJd4f8xITotl7Q2eAy6ouvBRsO0QSRqI5RCafzWJ+u2vGyhKfEnP2SyA/ /umQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TV29y09R; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-46e6688811dsi126445081cf.166.2025.01.28.06.24.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Jan 2025 06:24:15 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TV29y09R; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tcmUn-0000N3-EO; Tue, 28 Jan 2025 09:23:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tcmUG-0008EY-3z for qemu-devel@nongnu.org; Tue, 28 Jan 2025 09:22:44 -0500 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tcmUD-0002O9-Ia for qemu-devel@nongnu.org; Tue, 28 Jan 2025 09:22:42 -0500 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-3863c36a731so4736889f8f.1 for ; Tue, 28 Jan 2025 06:22:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738074159; x=1738678959; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jN7tNGrfnQkH1jp+7zEAfhWZCNwGy2KakJL6oRXbHIo=; b=TV29y09RKOW9xtqH++5r4H5mCmJPqDWmlztjWX8yRMiZkGVo/Jbw3GEhZWYSVjX4PY y/ge17IxfBxPD7KroxTHrSd3mgQEdltaM3SJuGG7OLzCbZ3FRTx6XV39yMRAgf7C4sCs lZsj7kKnPaq2dFuzjFufnDXAWvvz8krjU40TSOWItbvPXzuAVyXgoZtr0ysWfq9tzn9D dM3+W+B8SzrnrK0PR1Ec19OP+xP8dobdnzCpHGeWOJAwgm/8OThYMN7ANvhLqoREpImH 8uv65GqO0CDCtfYp3tNGFcy7MbkvuJA0zl6UGq2TaXVEAG6JGhBfZx92nxwEmCWPzyBQ Wc0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738074159; x=1738678959; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jN7tNGrfnQkH1jp+7zEAfhWZCNwGy2KakJL6oRXbHIo=; b=h5llxzRwTo168iBSOCU7YWSm3IogJsnPkEjRA4+p+H1AJdhKE6GhMDx3G5AQDhGfz4 L+9SAV1efDii9jlcak2U2lSy5Ncx8HRY9KFGnaBP5cPjUgrNXXSEDGm7NErIPkyMphZC /wU7Gqx2O0R5XljtArKlQ91IrGRo5WIK9ET7ztt+u87mMjeA3jk4MH/TCjDI6foMp7Pp bUZwZ/rLrtdphhHAFHaciHbJ7PliLQNDZxHRcGL6hVr8gX/QqmuuVT9U9KYLeftBYFlN a42Jqn/B7Um/cXafQyjn+SJHUiOUgefID2taxFSmZi87WFC1nukX6dMjeRsqZJVwqqah /leg== X-Gm-Message-State: AOJu0YwbPHk3RKoAtkIAjBLp27r9e3nyVmMGjrR6IpjjnOGzP7/5BBFr gOu9KmS75Tiw4n4c0JxkOiBO+pqFykJjV7l0qALmj1gjLGkT6npDG0gzluVwSBpizaE0xl5Ruav PjmM= X-Gm-Gg: ASbGncuhnzDNKHuzXOgk5Hr2Slz2Gge4iNeCVS/Vvm+EnWQv/k2P/LKbrNExNnRJ7xx 1PqhaAkXloKsQ/GIWoLmx9vLHZCeOT5ZRq0VvIUyBC0trBg13tNzafM+jRpAeIAzWVccSjrRpl2 uar7iz/zJKsJdCx32yWEB02E1Ck6z76+o8YjmJ29HwG2U6wXUHt6qyjDqrcfCwsU7IrRHXQOfAR gE5e9Jmr2awzxDjBlzywTlvcauK6ZUm05m3Ge8bXVHma+NmRj9I4R7B6O37SXXNRUJSrx6far8V J3iKvOr0JDGtw4+zNsl+woGVmsfATRLXdVAioE1RNiGoBmbqNuPY339z1rHz3P8NVQ== X-Received: by 2002:a5d:64e9:0:b0:38a:88bc:bae4 with SMTP id ffacd0b85a97d-38bf5784ab8mr43777014f8f.18.1738074159686; Tue, 28 Jan 2025 06:22:39 -0800 (PST) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a176434sm14462219f8f.13.2025.01.28.06.22.38 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 28 Jan 2025 06:22:39 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Peter Maydell , Yanan Wang , Eduardo Habkost , Harsh Prateek Bora , kvm@vger.kernel.org, Zhao Liu , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Markus Armbruster , Igor Mammedov , Marcel Apfelbaum , Peter Xu , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Paolo Bonzini , Richard Henderson Subject: [PATCH 9/9] accel/kvm: Remove unreachable assertion in kvm_dirty_ring_reap*() Date: Tue, 28 Jan 2025 15:21:52 +0100 Message-ID: <20250128142152.9889-10-philmd@linaro.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250128142152.9889-1-philmd@linaro.org> References: <20250128142152.9889-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Previous commit passed all our CI tests, this assertion being never triggered. Remove it as dead code. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- accel/kvm/kvm-all.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index cb56d120a91..814b1a53eb8 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -830,13 +830,6 @@ static uint32_t kvm_dirty_ring_reap_one(KVMState *s, CPUState *cpu) uint32_t ring_size = s->kvm_dirty_ring_size; uint32_t count = 0, fetch = cpu->kvm_fetch_index; - /* - * It's not possible that we race with vcpu creation code where the vcpu is - * put onto the vcpus list but not yet initialized the dirty ring - * structures. - */ - assert(cpu->created); - assert(dirty_gfns && ring_size); trace_kvm_dirty_ring_reap_vcpu(cpu->cpu_index);