From patchwork Tue Jan 28 10:45:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 860387 Delivered-To: patch@linaro.org Received: by 2002:a5d:6b8c:0:b0:385:e875:8a9e with SMTP id n12csp286972wrx; Tue, 28 Jan 2025 02:48:50 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUd1np0G2zaFKOd4uvEZOQYqUhtGB3nNgSKrmJ+gQCxRZFsiTEZePVzXwNyYz4ZPK/VxFqCXQ==@linaro.org X-Google-Smtp-Source: AGHT+IFRy+wcWKGsNyPYWj5lyeYd4S1C7c4fDNXbDg4Ctlg30djQOvN4cn1RSCv03Vis3qEoVqmo X-Received: by 2002:a05:622a:28e:b0:467:81f0:6d63 with SMTP id d75a77b69052e-46e12a3fae5mr650894671cf.17.1738061330762; Tue, 28 Jan 2025 02:48:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1738061330; cv=none; d=google.com; s=arc-20240605; b=luuL0jTySq+Kc9eHuaC7AkaiPhu8dFzmag5rT1387NlcRpWw8/Qr/ygaKwSyquNolC FrmdaCpRF1YmdgUbWtBUSlTmIpUuekx12F3Raosj3TAldCozmO3dgPkZxIwZNs6MyVKv PVNTBq9sgqlK5EUhMUE6iCkZO2gMsRO7nV7m6MYB1BROwgs3oMf/mAt20EdZkrk32IS6 V/TE35RlTyVjKH0N4cdbrZnmmqyhpr13CpZusqqAw12Vy35zkQfp3iD3HEunF96ie4B4 WrY/k1lZDiiVjqhdjTz1scuT/P5Re6sxoHMQGk4bSDuCf/cfr7mTdo4rZB6sdOL0SkZo XeLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=P84lmvWRoPuZSyE7d4+2LbnhWUe5f771b5Xano3sRNQ=; fh=Br6zGeTT6Byp3mOOotirFMXiT+Fp9gimwRY/HFEUedA=; b=Z25jyL5MfeTC6NWJd/zJY0Q/CzNJsGRhJEb1Ob+ShfKgUUrCKjCnGjUt17WtP7j4Dj oHNR5y/VFWJyeV5Q5pLKeCf2lX4R36FEIJLZiS1AE2NKlyCsR5lnQa+yAiewttqvX+vO nIIw+wu152xfZcBt8NbcawjEWtFChNfN3fXhHh0jvxddZ7MoYxjLDP8lgC/6LiLpVKf/ 0jityamOhV6tYEP0VZ505a9ACG37MxJcuQIgKgu623HAtSop4pptH7MW7zUnl4pzkkcC Q7cVIOcRbdXK8dPohA9X5tDvjJ0mYUVzQIu6JsKDCj5DLpeg1ycck6R9qgfyE5561DUM EVTw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OQ3aaO2w; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-46e66ba75b8si126889131cf.497.2025.01.28.02.48.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Jan 2025 02:48:50 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OQ3aaO2w; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tcj7V-0002Qu-7F; Tue, 28 Jan 2025 05:47:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tcj6E-0001B3-Ux for qemu-devel@nongnu.org; Tue, 28 Jan 2025 05:45:48 -0500 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tcj66-0003a2-Ck for qemu-devel@nongnu.org; Tue, 28 Jan 2025 05:45:42 -0500 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-4363dc916ceso40570275e9.0 for ; Tue, 28 Jan 2025 02:45:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1738061131; x=1738665931; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P84lmvWRoPuZSyE7d4+2LbnhWUe5f771b5Xano3sRNQ=; b=OQ3aaO2wabwlC+BpjNqzVUObLquPwFMMt1Pp53vcDoOjZJ75SvT4Q2ov2CzqDE2cm1 mHS5miJyb0dfd+Yz3ITcs6DNSssPhO6SrbeDJ/zlxHuYMjVWcJDWB6qmxR0/8Rfx13z1 1hLY74PKeqUEBFH833plgPMxvDGqVaKJdsSUa7keXQVvASzLpdEmOXmss/CdOPmaY/DH hb0yKcjaFeHONxyEUlgzA9Zrzq+kdF1Dhl/BtrNty9UH02RnlBCYiPLie1WlSdLmw7H7 aiR989cnHWl3FQQwu3iVUq4Ku3mKHN7P1bFeQ8sdSoxiCdEC84uiTJ6YSLafnU4dLqA0 6wvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738061131; x=1738665931; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P84lmvWRoPuZSyE7d4+2LbnhWUe5f771b5Xano3sRNQ=; b=YZB+QQAgBIBCAilBlGAk0CxH4OGoc3hTL7ejo71R5lxuIXtfQYQXwbkeQQxWvt9YkZ RIpPyw/wixGFfdrjVc23xRlOpbJdlPILFh74gzsv+RZz/xgnXTWh3eyLkZ6pBJW3zyWP P/h5RChzLZNRhmC+RLGkRHRt4cPwcCAXm/qFe/G+X2CuScAzz+BfWEueBMi6jc0eOlJr V2QULR3PrPapvmI3N14kXXOIraFDE5oiJt6UODUQzZHfYSCfFcAcE0q5uajQc6KZ7xij Kd56cEEz4eJOt4pMLXc9+hUq+eNqls1vWBfhZnTKHKguW1SXMcJ3+dIX9FN99L0iemQ0 0dPA== X-Forwarded-Encrypted: i=1; AJvYcCXicfR5gwNACaKNBxO8BnuS4CbsWtkTgqWuYagR89kf0ZrMcq0xQiSxb5m+MtUhKypl0S3asNA0UyKt@nongnu.org X-Gm-Message-State: AOJu0Yxe7I16MgGQdm3/QpDrCzQaPuuQ7jLMCwMoOmW7JSilew1mPosJ nI9w7ok8zJLeLM67uqgMvgVJG6S2f1X8hrq8eHOLMoIi2rS2GmtcWrUkLObqtPM= X-Gm-Gg: ASbGncumxY3BX7fvGG2r8gzOxf/hVDtmOfrQv9KYuyGwj8LX2dlaJPaaCh3rG3JqXOj SBHl/qSuqJ8miiYHMKig64SI/Fjrf9wbvtj3RaYXSMU8uDTZ3oNtJKoh2cnyPjqPTSzdmNgvNxx t+DZADCjt1L9f4E2d4GV+CuBU8IhdH5l1GvZ7gIuiR9ql0O7lDsIAP1HT08AsxPdOrJLTbSnUD1 jVTHltQ2UaCHzeOrUHODszbwnL2rHakeZURr/Fc4s/PP+uDVeE4rJ461jLc/n4OGWtb/KP7g9mj zdFtP8gJzKC6BtOip2XI X-Received: by 2002:adf:fb84:0:b0:385:e328:8908 with SMTP id ffacd0b85a97d-38c49a5d44dmr1754140f8f.29.1738061131513; Tue, 28 Jan 2025 02:45:31 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a1c418esm13920133f8f.95.2025.01.28.02.45.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jan 2025 02:45:30 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Bin Meng , Bernhard Beschow Subject: [PATCH 09/11] hw/sd: Remove unused 'enable' method from SDCardClass Date: Tue, 28 Jan 2025 10:45:17 +0000 Message-Id: <20250128104519.3981448-10-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250128104519.3981448-1-peter.maydell@linaro.org> References: <20250128104519.3981448-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The SDCardClass has an 'enable' method, but nothing actually invokes it. The underlying implementation is sd_enable(), which is documented in sdcard_legacy.h as something that should not be used and was only present for the benefit of the now-removed nseries boards. Unlike all the other method pointers in SDCardClass, this one doesn't have an sdbus_foo() function wrapper in hw/sd/core.c. Remove the unused method. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- include/hw/sd/sd.h | 1 - hw/sd/sd.c | 1 - 2 files changed, 2 deletions(-) diff --git a/include/hw/sd/sd.h b/include/hw/sd/sd.h index f2458f37b3c..d6bad175131 100644 --- a/include/hw/sd/sd.h +++ b/include/hw/sd/sd.h @@ -119,7 +119,6 @@ struct SDCardClass { void (*set_voltage)(SDState *sd, uint16_t millivolts); uint8_t (*get_dat_lines)(SDState *sd); bool (*get_cmd_line)(SDState *sd); - void (*enable)(SDState *sd, bool enable); bool (*get_inserted)(SDState *sd); bool (*get_readonly)(SDState *sd); void (*set_cid)(SDState *sd); diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 0330d432fd0..f781fd1641d 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -2831,7 +2831,6 @@ static void sdmmc_common_class_init(ObjectClass *klass, void *data) sc->read_byte = sd_read_byte; sc->receive_ready = sd_receive_ready; sc->data_ready = sd_data_ready; - sc->enable = sd_enable; sc->get_inserted = sd_get_inserted; sc->get_readonly = sd_get_readonly; }