From patchwork Thu Nov 14 20:59:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 843208 Delivered-To: patch@linaro.org Received: by 2002:adf:9bcc:0:b0:382:184f:390f with SMTP id e12csp506046wrc; Thu, 14 Nov 2024 13:05:05 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVHmNMUJAeZAtowtmUD7Pwv1U29FRSXQe8DxnOL5uWmMY81TwzIXfoXUZCRIiSAW3Lg8nJo/w==@linaro.org X-Google-Smtp-Source: AGHT+IHgXdF/Oo5XWMwP82e15N4BKIGcak1hLi0GReXGkYnXsbDBWvE5FDmGy7Wcd9ELlEITaga9 X-Received: by 2002:ac8:6909:0:b0:460:ad75:300a with SMTP id d75a77b69052e-46363e924a3mr3791941cf.37.1731618305474; Thu, 14 Nov 2024 13:05:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1731618305; cv=none; d=google.com; s=arc-20240605; b=F7X9XDxCz4KQHgUxEB9sgI8pIjrm1v581cihruCURtxpa/RIlC4k5klH45MZTK4drl 4WPYZU2iJ6+LOqmWBCd7Qtx2VYGChOt3xp6u83KAk3rrVD16mnRAZkTtpTnxkLjAW6hN Rezu3fPjwaSmC3Doi9rpWCE5WSt2bDy3EXDsHAQ0uLPsVvN4pXvEJkotvIURu1tNZ77G kainQn+ZvDRC1vLtL6mA/CEHIxoT+1S4hqv06B7KXAJtUZwQYhDijLdVB5ESB3lmyLGQ VtWFiNifsXk0/S9QSlyrEm0rX9JqWzAO12EkqF/+BMCzkA8HYmStlvB1PXRRkEzXweIF WORw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YlgtA2w+nkGpq6odlZPv7GuJkitbYlthMfvxp2Wzgbg=; fh=IRuGWMvTeecxgxjKSI7QmRflMkYktes0sVu/RVhAZQM=; b=LoRUaH11LoQlQvnrg4iCYO3zb1Ij6fahGSVmQg5h3wYNyA9kYwgLvo1H0RCtldSsml rsz459d0xVipRAhkhYVboitq+ghCXAT5UfOnVU80ygZBZRvSH90zvGyTDHBBS2rXdhz2 vnlG6zOWaAydaxLL/x5Jdxny7nW2EhIUaucZm7N/dj53I8Yru4hA/zRiGuIe3YVd9MPX fztdrm8FaDDeSIHONWeLHEnrnI6pZ4q/rXBBY3vf+DvkVidh5H1MiJSL0k3PAbPUwV/7 NUVOLssmgkMYjltLhId0mJ9SAvORgfCISlJJ9I6KJvCiLhsjilNeqjPAUudl501Ata2i vJSA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zvaJYErv; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-4635aaedc0csi18162171cf.462.2024.11.14.13.05.05 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Nov 2024 13:05:05 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zvaJYErv; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tBgxK-0008VM-5P; Thu, 14 Nov 2024 16:00:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tBgxD-0008SH-1L for qemu-devel@nongnu.org; Thu, 14 Nov 2024 16:00:39 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tBgxB-0007wQ-8U for qemu-devel@nongnu.org; Thu, 14 Nov 2024 16:00:38 -0500 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-37d495d217bso862914f8f.0 for ; Thu, 14 Nov 2024 13:00:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1731618031; x=1732222831; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YlgtA2w+nkGpq6odlZPv7GuJkitbYlthMfvxp2Wzgbg=; b=zvaJYErv6yAaQHqckRPX1UP5Y7IdpEwqrsrbq9Ey+Obw9tvf5QuP6V1o0wki/qJCOZ rECy69YCd83DvWK1eq7Aq4Ebmi8dfD6zFi//piSW5QRY8+9DUNEwy8IXD8YGjbc+EYc1 8JmDe7nXzNedO0WAEvaW6YC7skJ8BqmN7ovwdGuxPuY+mWPuiseDVs35BehWivGMX/MK 0hbiwRchaqZU8rh/pXqG9oFOWVIm64zocaaoz0r5l8EfNMh2SqSir5+WmHvcaktxO4Fx oCHGOP3fPQA61yMJ3urKnnNA1EXBnTFWDJAkYa01TG3hXcFqZ8q/4brCWzOYdYjpO9/6 37DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731618031; x=1732222831; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YlgtA2w+nkGpq6odlZPv7GuJkitbYlthMfvxp2Wzgbg=; b=VHk2sXVF5Mv8bSfIH2Ujn5b68ynj+g51xY9VciADbS7h0N0cBNK2BTk0FE09BxLfNL qiyefAJdylz5IYRPQF6xyEzeRWVWI/GvDON1e3u3eRBmVrLSoUJ/cBGkvJg/5Ij/lB2H 5F3KkbJD4XwXMtSeQ3FD7kh/Kk3wGHvuWWaY2LOV6QMCSk4LML/lZDui5xvV5K11xxAb jUI4Jbqib3PtPYwOfKOae4P0YKOCR8deHLJPdxQwx+EnBpl2ryvt8rF3VB+3IPmngU7R r1h6SGlTLPlsXUd5v9UmIOTldATDb4RsyeLd+804L47C/hGa/HGpMMvDFrOaWVDDyB9i 2i3g== X-Gm-Message-State: AOJu0YxaD32yk7ZQENo3K3ljfCPodXwMhTcNzuFRcfSrzi+dwDAJ0JX5 zBmqbA8anJMvaNHfmaXcmUERwn2eeEsSPoit5fAFhScXUS0N6NRK3ty2Ftli0bX6RDGtgOYPrww s X-Received: by 2002:a5d:5e02:0:b0:381:f603:ff62 with SMTP id ffacd0b85a97d-38225a454ddmr179821f8f.20.1731618030678; Thu, 14 Nov 2024 13:00:30 -0800 (PST) Received: from localhost.localdomain ([176.187.209.228]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3821ae16827sm2464974f8f.76.2024.11.14.13.00.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 14 Nov 2024 13:00:30 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Edgar E. Iglesias" , qemu-arm@nongnu.org, Richard Henderson , Thomas Huth , Anton Johansson , Bernhard Beschow , Alistair Francis , Paolo Bonzini , Gustavo Romero , =?utf-8?q?Marc-Andr=C3=A9_Lurea?= =?utf-8?q?u?= , Peter Maydell , Jason Wang , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , "Edgar E . Iglesias" Subject: [PATCH RESEND v2 02/19] hw/net/xilinx_ethlite: Convert some debug logs to trace events Date: Thu, 14 Nov 2024 21:59:53 +0100 Message-ID: <20241114210010.34502-3-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241114210010.34502-1-philmd@linaro.org> References: <20241114210010.34502-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Edgar E. Iglesias --- hw/net/xilinx_ethlite.c | 5 +++-- hw/net/trace-events | 4 ++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c index e84b4cdd35..bb330a233f 100644 --- a/hw/net/xilinx_ethlite.c +++ b/hw/net/xilinx_ethlite.c @@ -30,6 +30,7 @@ #include "hw/irq.h" #include "hw/qdev-properties.h" #include "net/net.h" +#include "trace.h" #define D(x) #define R_TX_BUF0 0 @@ -198,13 +199,13 @@ static ssize_t eth_rx(NetClientState *nc, const uint8_t *buf, size_t size) return size; if (s->regs[rxbase + R_RX_CTRL0] & CTRL_S) { - D(qemu_log("ethlite lost packet %x\n", s->regs[R_RX_CTRL0])); + trace_ethlite_pkt_lost(s->regs[R_RX_CTRL0]); return -1; } D(qemu_log("%s %zd rxbase=%x\n", __func__, size, rxbase)); if (size > (R_MAX - R_RX_BUF0 - rxbase) * 4) { - D(qemu_log("ethlite packet is too big, size=%x\n", size)); + trace_ethlite_pkt_size_too_big(size); return -1; } memcpy(&s->regs[rxbase + R_RX_BUF0], buf, size); diff --git a/hw/net/trace-events b/hw/net/trace-events index d0f1d8c0fb..2b36cd967e 100644 --- a/hw/net/trace-events +++ b/hw/net/trace-events @@ -511,3 +511,7 @@ xen_netdev_connect(int dev, unsigned int tx, unsigned int rx, int port) "vif%u t xen_netdev_frontend_changed(const char *dev, int state) "vif%s state %d" xen_netdev_tx(int dev, int ref, int off, int len, unsigned int flags, const char *c, const char *d, const char *m, const char *e) "vif%u ref %u off %u len %u flags 0x%x%s%s%s%s" xen_netdev_rx(int dev, int idx, int status, int flags) "vif%u idx %d status %d flags 0x%x" + +# xilinx_ethlite.c +ethlite_pkt_lost(uint32_t rx_ctrl) "rx_ctrl:0x%" PRIx32 +ethlite_pkt_size_too_big(uint64_t size) "size:0x%" PRIx64