From patchwork Thu Nov 14 16:01:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 843165 Delivered-To: patch@linaro.org Received: by 2002:adf:9bcc:0:b0:382:184f:390f with SMTP id e12csp365897wrc; Thu, 14 Nov 2024 08:11:55 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVoNdsDeqoM299ElceaPu+rnAGxrSnLSpoi+lir6VatWtJX+BTuHOpkH+0f7S/EYzsMkhLn7g==@linaro.org X-Google-Smtp-Source: AGHT+IHWDcvV1XffSnUsuaFwUe0zKc5LVkjfgCHaV7ifbPyWv38WC7jJFeVU9MiSqhIKuzElV1ih X-Received: by 2002:a05:620a:19aa:b0:7b1:1223:5a02 with SMTP id af79cd13be357-7b35283b67bmr912518685a.8.1731600715437; Thu, 14 Nov 2024 08:11:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1731600715; cv=none; d=google.com; s=arc-20240605; b=gbGUwSui2gsiZvP301EeUw3lRKbXBZ6pDsX2IETeW6FeNksYX4jGbzreQ3mgNres58 rItpFOQH9jcWkUaFC050nqrB/gxLPeHlBl/8mkHEpOyElAidZ+nNhMbZtAZ/4eg2P5zO Q87zsV/xuVgpGkzZRVNog9VIxCXQspv0x6Vul7wdf4luHy5VnMtP8THOpcjTIRIav/l8 H3ci46DF1GfVhKhSj1eoZoQSHTAjrmbgjwb+CAlR+7KDS/Zr7XlBXnEPZ80lBRxIWTAF Tt6i354BA6AurLCSId6VUuJ5aFJuLuDovFZr5RCIRQhswIPm7cP4LzkQK4GMnn+gBKdR U5TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=l6VeKTlRuD0Xy07QiXe4r1yW5BzO376HoZWUmX4DLoU=; fh=PnYt+qEB9tAfMKoqBm2xjKOFpYyFFGPudh5cVIoieJM=; b=QrcG4lAnI6cLs83Zkkmrst4V1PqdTFUr28CWAvnRNzFFA1aNyuX9WS9vkdpGD5kMQ7 acDLUr7r9KkqrzVe7j84/+kOc12Gw5gb3p/VWcOsCecXhUEihYslmCw4EpG3QE3PYueh cC8dsJiJQkSXx3Qy+S4TH7V//c+samzZRP/E83cu0T1biMPia5bZ5xzihJnUQu03CrYY Bg41Xww1iWIcO9eKGn6BfNGxJxgDCVDiFFX/JgAVzqM0ZY+8GMliiRmZEZYyiTZpXfP6 lcAAYWyaQJuPJh9KCsVEqPEB/fBGH+AK5Z2FZRf/J0ZOJVVSJz1gmSWk9KFo2JZbedyo wUZQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ga9lUu8L; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7b35c9877bfsi142236485a.178.2024.11.14.08.11.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Nov 2024 08:11:55 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ga9lUu8L; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tBcIb-00059P-Lo; Thu, 14 Nov 2024 11:02:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tBcIO-00053L-9s for qemu-devel@nongnu.org; Thu, 14 Nov 2024 11:02:13 -0500 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tBcIL-0002JE-9r for qemu-devel@nongnu.org; Thu, 14 Nov 2024 11:02:12 -0500 Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-2e31af47681so652330a91.2 for ; Thu, 14 Nov 2024 08:02:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1731600128; x=1732204928; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=l6VeKTlRuD0Xy07QiXe4r1yW5BzO376HoZWUmX4DLoU=; b=ga9lUu8Lch3Ve1RO2rV7glzYz/sSC/u2UKPn+xqVKlfxvl79ff9+VRNPqppKL6Olbn L0edK1GuLHkXpHwJuw5320905ElB+EvdTiH0Ay51X9R99IMCoZF+5xkmiooDfBJRMb5N uAP3gjyJn/oIWOx/nHhP6xKFaaFfW4ZfhME+dVokU7Z2JlZM8f5oQB2TXUE9+srIC1ym j5A+lIk+NMHfc2matmw5k0sIr55YqQMlcX2go5cPfdnPzwcjfUAW47jxd1N6AhxEGsy+ 9JSYCBg0yFon88/1MOZtfuVbxDyKh40xdtDzV3tPKFeZRX1pMP6voVMK2XbDD2lT+Svj 0bvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731600128; x=1732204928; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l6VeKTlRuD0Xy07QiXe4r1yW5BzO376HoZWUmX4DLoU=; b=p16Cwty/6Kv2Tt7+gKWxGVC7Tfz/OCsyTa9A31Aq8rrzskeaNBPU+sWH8oM8/1U3u7 kz9tWj3EQ/AMxGsRyx2a0hf/H9LByNiYQfe/rqjTDnIGn+gk5y/ahtIoASspniphmoFM XggQGYk/tO3Aqi1zIdEVrmB0bqSKijdQnBtYYXAHEnvKlWAKT358YgdoQfS+2zeIJ7CP JS54ewyWIPTMstQq5ZUxsP+qC+ZNgT2TTahARXquL36F/9uQDQN1baGsYWeRfbqpNERT x0uwZ5joa213HodejhzKPk2GWkyUn9fweOyuGpxMs7k/PCUfxxCpHvAfzGbiXxieDrtE eizA== X-Gm-Message-State: AOJu0Yz7vHibg7w5VHb+AgfVEzBXECUyOmDFW0g3als0JzQkDeBBVxz1 iE7RNMXL33FID/+KggTQ8rSR4zDBWv9oORS3GNABns6IpIHCIQjrNPk6+vMdcUxmGusbp8P+c1q Z X-Received: by 2002:a17:90b:2548:b0:2e2:e092:5323 with SMTP id 98e67ed59e1d1-2e9f2d5cc36mr9029570a91.29.1731600127730; Thu, 14 Nov 2024 08:02:07 -0800 (PST) Received: from stoup.. ([71.212.136.242]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ea024ec723sm1484438a91.46.2024.11.14.08.02.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Nov 2024 08:02:06 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 39/54] target/m68k: Do not call tlb_set_page in helper_ptest Date: Thu, 14 Nov 2024 08:01:15 -0800 Message-ID: <20241114160131.48616-40-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241114160131.48616-1-richard.henderson@linaro.org> References: <20241114160131.48616-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1035.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The entire operation of ptest is performed within get_physical_address as part of ACCESS_PTEST. There is no need to install the page into softmmu. Signed-off-by: Richard Henderson Reviewed-by: Pierrick Bouvier --- target/m68k/helper.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/target/m68k/helper.c b/target/m68k/helper.c index 1decb6f39c..0a54eca9bb 100644 --- a/target/m68k/helper.c +++ b/target/m68k/helper.c @@ -1460,7 +1460,6 @@ void HELPER(ptest)(CPUM68KState *env, uint32_t addr, uint32_t is_read) hwaddr physical; int access_type; int prot; - int ret; target_ulong page_size; access_type = ACCESS_PTEST; @@ -1476,14 +1475,7 @@ void HELPER(ptest)(CPUM68KState *env, uint32_t addr, uint32_t is_read) env->mmu.mmusr = 0; env->mmu.ssw = 0; - ret = get_physical_address(env, &physical, &prot, addr, - access_type, &page_size); - if (ret == 0) { - tlb_set_page(env_cpu(env), addr & TARGET_PAGE_MASK, - physical & TARGET_PAGE_MASK, - prot, access_type & ACCESS_SUPER ? - MMU_KERNEL_IDX : MMU_USER_IDX, page_size); - } + get_physical_address(env, &physical, &prot, addr, access_type, &page_size); } void HELPER(pflush)(CPUM68KState *env, uint32_t addr, uint32_t opmode)